Better test cases

Author: ErikQQY

lib/BoundaryValueDiffEqCore/test/runtests.jl

@@ -11,35 +11,4 @@ using InteractiveUtils, Test
         Aqua.test_piracies(BoundaryValueDiffEqCore)
         Aqua.test_ambiguities(BoundaryValueDiffEqCore; recursive = false)
     end
-
-    @testset "__extract_lcons_ucons length" begin
-        # Regression test: the function must return vectors matching the actual
-        # constraint vector length (= length(resid_prototype)), not a reconstruction
-        # from (M, N, ...) which was wrong for several solvers.
-        using BoundaryValueDiffEqCore: __extract_lcons_ucons
-        using SciMLBase: BVProblem
-
-        f!(du, u, p, t) = (du[1] = u[2]; du[2] = -u[1])
-        bc!(res, u, p, t) = (res[1] = u(0.0)[1]; res[2] = u(1.0)[1])
-
-        # Fallback path (isnothing(prob.lcons)): both vectors have length == constraint_length
-        prob = BVProblem(f!, bc!, [0.0, 0.0], (0.0, 1.0); bcresid_prototype = zeros(2))
-        lc, uc = __extract_lcons_ucons(prob, Float64, 42)
-        @test length(lc) == 42
-        @test length(uc) == 42
-        @test all(iszero, lc)
-        @test all(iszero, uc)
-
-        # User-provided lcons/ucons: values preserved, padded with zeros to constraint_length
-        prob2 = BVProblem(f!, bc!, [0.0, 0.0], (0.0, 1.0);
-            bcresid_prototype = zeros(2),
-            lcons = [-1.0, -2.0], ucons = [1.0, 2.0])
-        lc2, uc2 = __extract_lcons_ucons(prob2, Float64, 10)
-        @test length(lc2) == 10
-        @test length(uc2) == 10
-        @test lc2[1:2] == [-1.0, -2.0]
-        @test uc2[1:2] == [1.0, 2.0]
-        @test all(iszero, lc2[3:end])
-        @test all(iszero, uc2[3:end])
-    end
 end

lib/BoundaryValueDiffEqCore/test/util_tests.jl

@@ -0,0 +1,32 @@
+@testset "__extract_lcons_ucons length" begin
+    # Regression test: the function must return vectors matching the actual
+    # constraint vector length (= length(resid_prototype)), not a reconstruction
+    # from (M, N, ...) which was wrong for several solvers.
+    using BoundaryValueDiffEqCore: __extract_lcons_ucons
+    using SciMLBase: BVProblem
+
+    f!(du, u, p, t) = (du[1] = u[2]; du[2] = -u[1])
+    bc!(res, u, p, t) = (res[1] = u(0.0)[1]; res[2] = u(1.0)[1])
+
+    # Fallback path (isnothing(prob.lcons)): both vectors have length == constraint_length
+    prob = BVProblem(f!, bc!, [0.0, 0.0], (0.0, 1.0); bcresid_prototype = zeros(2))
+    lc, uc = __extract_lcons_ucons(prob, Float64, 42)
+    @test length(lc) == 42
+    @test length(uc) == 42
+    @test all(iszero, lc)
+    @test all(iszero, uc)
+
+    # User-provided lcons/ucons: values preserved, padded with zeros to constraint_length
+    prob2 = BVProblem(
+        f!, bc!, [0.0, 0.0], (0.0, 1.0);
+        bcresid_prototype = zeros(2),
+        lcons = [-1.0, -2.0], ucons = [1.0, 2.0]
+    )
+    lc2, uc2 = __extract_lcons_ucons(prob2, Float64, 10)
+    @test length(lc2) == 10
+    @test length(uc2) == 10
+    @test lc2[1:2] == [-1.0, -2.0]
+    @test uc2[1:2] == [1.0, 2.0]
+    @test all(iszero, lc2[3:end])
+    @test all(iszero, uc2[3:end])
+end

lib/BoundaryValueDiffEqMIRK/test/mirk_basic_tests.jl

@@ -648,6 +648,7 @@ end
     @test_nowarn sol = solve(prob, MIRK4(; optimize = IpoptOptimizer()), dt = 0.05)
 end
 
+# https://github.com/SciML/BoundaryValueDiffEq.jl/pull/473
 @testitem "StandardBVProblem optimize path without user lcons/ucons" begin
     # Regression test: previously, `__extract_lcons_ucons` in the Nothing-
     # f_prototype dispatch returned vectors of length N*M (decision-variable
@@ -662,13 +663,12 @@ end
         du[2] = -9.81 * sin(u[1])
     end
     function bc!(residual, u, p, t)
-        residual[1] = u(0.0)[1] - pi / 2
+        residual[1] = u(pi / 4)[1] + pi / 2
         residual[2] = u(pi / 2)[1] - pi / 2
     end
     # StandardBVProblem, no lcons/ucons — hits the fallback branch.
     prob = BVProblem(
-        simplependulum!, bc!, [pi / 2, pi / 2], tspan;
-        bcresid_prototype = zeros(2)
+        simplependulum!, bc!, [pi / 2, pi / 2], tspan
     )
     @test_nowarn solve(prob, MIRK4(; optimize = IpoptOptimizer()), dt = 0.05)
 end