QA: run_qa v1.6 form + ExplicitImports (root + sublibs)

ChrisRackauckas · claude · ChrisRackauckas · commit b88dbf11b05e · 2026-06-25T13:16:10.000-04:00
Convert the root QA env and every lib/<Sub>/test/qa env to the SciMLTesting v1.6 run_qa form with ExplicitImports enabled. Each qa.jl becomes `using SciMLTesting, <ThatModule>, Test` (+ `using JET` at the root, which keeps the JET package check) and a single `run_qa(<ThatModule>; explicit_imports = true, ...)` call. Genuine Aqua tweaks are preserved as aqua_kwargs: the root keeps `ambiguities = false` and the `treat_as_own = [SciMLBase.BVProblem]` piracies allowance; Core keeps `ambiguities = (; recursive = false)` and `stale_deps = (; ignore = [:TimerOutputs])`; Shooting keeps `persistent_tasks = false`. ExplicitImports is run in every env. The live checks pass except for a set of pre-existing findings (bare-`using` implicit imports, stale Core-internal imports, non-public upstream/sibling accesses) which are marked `@test_broken` via `ei_broken` so the lanes stay green and auto-flag once fixed; the root's qualified-access of `SciMLBase.__init/__solve` and `Base.get_extension` is ignore-listed. All tracked in #519. The root QA group's separate qa/jet.jl is folded into run_qa's JET check and removed; runtests.jl's QA body now includes only qa/qa.jl. SciMLTesting is added to each QA env ([deps] + [compat] "1.6"); the [sources] develop wiring is preserved verbatim. ExplicitImports is supplied transitively by SciMLTesting and is not listed. Verified locally on Julia 1.10 against released SciMLTesting 1.6.0 (0 Fail): - root: 16 Pass, 1 Broken - Core: 13 Pass, 4 Broken - MIRK: 12 Pass, 5 Broken - Shooting: 11 Pass, 5 Broken Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff --git a/lib/BoundaryValueDiffEqAscher/test/qa/Project.toml b/lib/BoundaryValueDiffEqAscher/test/qa/Project.toml
@@ -2,6 +2,7 @@
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BoundaryValueDiffEqAscher = "7227322d-7511-4e07-9247-ad6ff830280e"
 BoundaryValueDiffEqCore = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -12,5 +13,6 @@ BoundaryValueDiffEqCore = {path = "../../../BoundaryValueDiffEqCore"}
 Aqua = "0.8"
 BoundaryValueDiffEqAscher = "1"
 BoundaryValueDiffEqCore = "2"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/lib/BoundaryValueDiffEqAscher/test/qa/qa.jl b/lib/BoundaryValueDiffEqAscher/test/qa/qa.jl
@@ -1,7 +1,13 @@
+using SciMLTesting
 using BoundaryValueDiffEqAscher
-using Aqua
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(BoundaryValueDiffEqAscher)
-end
+run_qa(
+    BoundaryValueDiffEqAscher;
+    explicit_imports = true,
+    # Pre-existing ExplicitImports findings, tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (
+        :no_implicit_imports, :no_stale_explicit_imports,
+        :all_qualified_accesses_are_public, :all_explicit_imports_are_public,
+    ),
+)
diff --git a/lib/BoundaryValueDiffEqCore/test/qa/Project.toml b/lib/BoundaryValueDiffEqCore/test/qa/Project.toml
@@ -1,6 +1,7 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BoundaryValueDiffEqCore = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -9,5 +10,6 @@ BoundaryValueDiffEqCore = {path = "../.."}
 [compat]
 Aqua = "0.8"
 BoundaryValueDiffEqCore = "2"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/lib/BoundaryValueDiffEqCore/test/qa/qa.jl b/lib/BoundaryValueDiffEqCore/test/qa/qa.jl
@@ -1,10 +1,17 @@
+using SciMLTesting
 using BoundaryValueDiffEqCore
-using Aqua
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(BoundaryValueDiffEqCore; piracies = false, ambiguities = false, stale_deps = false)
-    Aqua.test_stale_deps(BoundaryValueDiffEqCore; ignore = [:TimerOutputs])
-    Aqua.test_piracies(BoundaryValueDiffEqCore)
-    Aqua.test_ambiguities(BoundaryValueDiffEqCore; recursive = false)
-end
+run_qa(
+    BoundaryValueDiffEqCore;
+    explicit_imports = true,
+    aqua_kwargs = (;
+        ambiguities = (; recursive = false),
+        stale_deps = (; ignore = [:TimerOutputs]),
+    ),
+    # Pre-existing ExplicitImports findings, tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (
+        :no_implicit_imports, :no_stale_explicit_imports,
+        :all_qualified_accesses_are_public, :all_explicit_imports_are_public,
+    ),
+)
diff --git a/lib/BoundaryValueDiffEqFIRK/test/qa/Project.toml b/lib/BoundaryValueDiffEqFIRK/test/qa/Project.toml
@@ -2,6 +2,7 @@
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BoundaryValueDiffEqCore = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
 BoundaryValueDiffEqFIRK = "85d9eb09-370e-4000-bb32-543851f73618"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -12,5 +13,6 @@ BoundaryValueDiffEqFIRK = {path = "../.."}
 Aqua = "0.8"
 BoundaryValueDiffEqCore = "2"
 BoundaryValueDiffEqFIRK = "1"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/lib/BoundaryValueDiffEqFIRK/test/qa/qa.jl b/lib/BoundaryValueDiffEqFIRK/test/qa/qa.jl
@@ -1,7 +1,14 @@
+using SciMLTesting
 using BoundaryValueDiffEqFIRK
-using Aqua
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(BoundaryValueDiffEqFIRK)
-end
+run_qa(
+    BoundaryValueDiffEqFIRK;
+    explicit_imports = true,
+    # Pre-existing ExplicitImports findings, tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (
+        :no_implicit_imports, :no_stale_explicit_imports,
+        :all_explicit_imports_via_owners,
+        :all_qualified_accesses_are_public, :all_explicit_imports_are_public,
+    ),
+)
diff --git a/lib/BoundaryValueDiffEqMIRK/test/qa/Project.toml b/lib/BoundaryValueDiffEqMIRK/test/qa/Project.toml
@@ -2,6 +2,7 @@
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BoundaryValueDiffEqCore = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
 BoundaryValueDiffEqMIRK = "1a22d4ce-7765-49ea-b6f2-13c8438986a6"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -12,5 +13,6 @@ BoundaryValueDiffEqMIRK = {path = "../.."}
 Aqua = "0.8"
 BoundaryValueDiffEqCore = "2"
 BoundaryValueDiffEqMIRK = "1"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/lib/BoundaryValueDiffEqMIRK/test/qa/qa.jl b/lib/BoundaryValueDiffEqMIRK/test/qa/qa.jl
@@ -1,7 +1,14 @@
+using SciMLTesting
 using BoundaryValueDiffEqMIRK
-using Aqua
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(BoundaryValueDiffEqMIRK)
-end
+run_qa(
+    BoundaryValueDiffEqMIRK;
+    explicit_imports = true,
+    # Pre-existing ExplicitImports findings, tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (
+        :no_implicit_imports, :no_stale_explicit_imports,
+        :all_explicit_imports_via_owners,
+        :all_qualified_accesses_are_public, :all_explicit_imports_are_public,
+    ),
+)
diff --git a/lib/BoundaryValueDiffEqMIRKN/test/qa/Project.toml b/lib/BoundaryValueDiffEqMIRKN/test/qa/Project.toml
@@ -2,6 +2,7 @@
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BoundaryValueDiffEqCore = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
 BoundaryValueDiffEqMIRKN = "9255f1d6-53bf-473e-b6bd-23f1ff009da4"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -12,5 +13,6 @@ BoundaryValueDiffEqMIRKN = {path = "../.."}
 Aqua = "0.8"
 BoundaryValueDiffEqCore = "2"
 BoundaryValueDiffEqMIRKN = "1"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/lib/BoundaryValueDiffEqMIRKN/test/qa/qa.jl b/lib/BoundaryValueDiffEqMIRKN/test/qa/qa.jl
@@ -1,7 +1,14 @@
+using SciMLTesting
 using BoundaryValueDiffEqMIRKN
-using Aqua
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(BoundaryValueDiffEqMIRKN)
-end
+run_qa(
+    BoundaryValueDiffEqMIRKN;
+    explicit_imports = true,
+    # Pre-existing ExplicitImports findings, tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (
+        :no_implicit_imports, :no_stale_explicit_imports,
+        :all_explicit_imports_via_owners,
+        :all_qualified_accesses_are_public, :all_explicit_imports_are_public,
+    ),
+)
diff --git a/lib/BoundaryValueDiffEqShooting/test/qa/Project.toml b/lib/BoundaryValueDiffEqShooting/test/qa/Project.toml
@@ -2,6 +2,7 @@
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BoundaryValueDiffEqCore = "56b672f2-a5fe-4263-ab2d-da677488eb3a"
 BoundaryValueDiffEqShooting = "ed55bfe0-3725-4db6-871e-a1dc9f42a757"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -12,5 +13,6 @@ BoundaryValueDiffEqShooting = {path = "../.."}
 Aqua = "0.8"
 BoundaryValueDiffEqCore = "2"
 BoundaryValueDiffEqShooting = "1"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/lib/BoundaryValueDiffEqShooting/test/qa/qa.jl b/lib/BoundaryValueDiffEqShooting/test/qa/qa.jl
@@ -1,7 +1,15 @@
+using SciMLTesting
 using BoundaryValueDiffEqShooting
-using Aqua
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(BoundaryValueDiffEqShooting; persistent_tasks = false)
-end
+run_qa(
+    BoundaryValueDiffEqShooting;
+    explicit_imports = true,
+    aqua_kwargs = (; persistent_tasks = false),
+    # Pre-existing ExplicitImports findings, tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (
+        :no_implicit_imports, :no_stale_explicit_imports,
+        :all_explicit_imports_via_owners,
+        :all_qualified_accesses_are_public, :all_explicit_imports_are_public,
+    ),
+)
diff --git a/test/qa/Project.toml b/test/qa/Project.toml
@@ -9,6 +9,7 @@ BoundaryValueDiffEqMIRKN = "9255f1d6-53bf-473e-b6bd-23f1ff009da4"
 BoundaryValueDiffEqShooting = "ed55bfe0-3725-4db6-871e-a1dc9f42a757"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -31,5 +32,6 @@ BoundaryValueDiffEqMIRKN = "1"
 BoundaryValueDiffEqShooting = "1"
 JET = "0.9, 0.10, 0.11"
 SciMLBase = "3"
+SciMLTesting = "1.6"
 Test = "1.10"
 julia = "1.10"
diff --git a/test/qa/jet.jl b/test/qa/jet.jl
diff --git a/test/qa/qa.jl b/test/qa/qa.jl
@@ -1,11 +1,24 @@
+using SciMLTesting
 using BoundaryValueDiffEq
-using Aqua
 using SciMLBase
+using JET
 using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(
-        BoundaryValueDiffEq; ambiguities = false,
-        piracies = (broken = false, treat_as_own = [SciMLBase.BVProblem])
-    )
-end
+run_qa(
+    BoundaryValueDiffEq;
+    explicit_imports = true,
+    aqua_kwargs = (;
+        ambiguities = false,
+        piracies = (; treat_as_own = [SciMLBase.BVProblem]),
+    ),
+    # BoundaryValueDiffEq is an umbrella that re-exports the solver algorithms
+    # (Shooting, MIRK*, RadauIIa*, LobattoIII*, Ascher*, ...) from its sublibraries
+    # via `using <Sublibrary>` + `export`, which ExplicitImports flags as implicit.
+    # Tracked in SciML/BoundaryValueDiffEq.jl#519.
+    ei_broken = (:no_implicit_imports,),
+    ei_kwargs = (;
+        # SciMLBase.__init/__solve (extending the solve interface) and
+        # Base.get_extension (querying loaded weakdeps) are other-package internals.
+        all_qualified_accesses_are_public = (; ignore = (:__init, :__solve, :get_extension)),
+    ),
+)
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -99,10 +99,10 @@ else
         qa = (;
             env = joinpath(@__DIR__, "qa"),
             body = function ()
-                # QA (Aqua + JET) runs on release + LTS Julia only; skip on prerelease.
+                # QA (Aqua + JET + ExplicitImports) runs on release + LTS Julia only;
+                # skip on prerelease.
                 isempty(VERSION.prerelease) || return nothing
-                @time @safetestset "Quality Assurance" include("qa/qa.jl")
-                return @time @safetestset "JET" include("qa/jet.jl")
+                return @time @safetestset "Quality Assurance" include("qa/qa.jl")
             end,
         ),
         # The original ran the Misc and QA groups for the default GROUP="All", but
