Use correct solve

Author: ErikQQY

lib/BoundaryValueDiffEqAscher/src/ascher.jl

@@ -181,7 +181,7 @@ function __perform_ascher_iteration(cache::AscherCache{iip, T}, abstol, adaptive
     solve_alg = __concrete_solve_algorithm(nlprob, cache.alg.nlsolve, cache.alg.optimize)
     kwargs = __concrete_kwargs(
         cache.alg.nlsolve, cache.alg.optimize, cache.nlsolve_kwargs, cache.optimize_kwargs)
-    nlsol = solve(nlprob, solve_alg; kwargs...)
+    nlsol = __solve(nlprob, solve_alg; kwargs...)
     error_norm = 2 * abstol
     info = nlsol.retcode
 

lib/BoundaryValueDiffEqMIRK/src/mirk.jl

@@ -192,7 +192,7 @@ function __perform_mirk_iteration(cache::MIRKCache, abstol, adaptive::Bool, cont
     solve_alg = __concrete_solve_algorithm(nlprob, cache.alg.nlsolve, cache.alg.optimize)
     kwargs = __concrete_kwargs(
         cache.alg.nlsolve, cache.alg.optimize, cache.nlsolve_kwargs, cache.optimize_kwargs)
-    sol_nlprob = solve(nlprob, solve_alg; kwargs...)
+    sol_nlprob = __solve(nlprob, solve_alg; kwargs...)
     recursive_unflatten!(cache.y₀, sol_nlprob.u)
 
     error_norm = 2 * abstol

lib/BoundaryValueDiffEqMIRKN/src/mirkn.jl

@@ -119,7 +119,7 @@ function __perform_mirkn_iteration(cache::MIRKNCache)
     solve_alg = __concrete_solve_algorithm(nlprob, cache.alg.nlsolve, cache.alg.optimize)
     kwargs = __concrete_kwargs(
         cache.alg.nlsolve, cache.alg.optimize, cache.nlsolve_kwargs, cache.optimize_kwargs)
-    sol_nlprob = solve(nlprob, solve_alg; kwargs...)
+    sol_nlprob = __solve(nlprob, solve_alg; kwargs...)
     recursive_unflatten!(cache.y₀, sol_nlprob.u)
 
     return sol_nlprob, sol_nlprob.retcode

lib/BoundaryValueDiffEqShooting/src/multiple_shooting.jl

@@ -148,7 +148,7 @@ function __solve_nlproblem!(
         u_at_nodes, prob.p, M, length(nodes), nothing)
 
     nlsolve_alg = __concrete_solve_algorithm(nlprob, alg.nlsolve, alg.optimize)
-    solve(nlprob, nlsolve_alg; kwargs...)
+    __solve(nlprob, nlsolve_alg; kwargs...)
 
     return nothing
 end
@@ -223,7 +223,7 @@ function __solve_nlproblem!(::StandardBVProblem, alg::MultipleShooting, bcresid_
         prob, alg, loss_fn, jac_fn, jac_prototype, resid_prototype,
         u_at_nodes, prob.p, M, length(nodes), nothing)
     nlsolve_alg = __concrete_solve_algorithm(nlprob, alg.nlsolve, alg.optimize)
-    solve(nlprob, nlsolve_alg; kwargs...)
+    __solve(nlprob, nlsolve_alg; kwargs...)
 
     return nothing
 end

lib/BoundaryValueDiffEqShooting/src/single_shooting.jl

@@ -80,7 +80,7 @@ function SciMLBase.__solve(prob::BVProblem, alg_::Shooting; abstol = 1e-6,
     solve_alg = __concrete_solve_algorithm(nlprob, alg.nlsolve, alg.optimize)
     kwargs = __concrete_kwargs(alg.nlsolve, alg.optimize, nlsolve_kwargs, optimize_kwargs)
     #TODO: add verbose kwarg
-    nlsol = solve(nlprob, solve_alg; kwargs...)
+    nlsol = __solve(nlprob, solve_alg; kwargs...)
 
     # There is no way to reinit with the same cache with different cache. But not saving
     # the internal values gives a significant speedup. So we just create a new cache

test/misc/default_solvers.jl

@@ -1,24 +1,24 @@
 @testitem "Default Solvers" begin
     using BoundaryValueDiffEq, Test
-    
+
     function f(du, u, p, t)
         (x, v) = u
         du[1] = v
         du[2] = -x
     end
-    
+
     function bc!(resid, sol, p, t)
         resid[1] = sol[1][1]
         resid[2] = sol[end][1] - 1
     end
-    
+
     tspan = (0.0, 100.0)
     u0 = [0.0, 1.0]
     bvp = BVProblem(f, bc!, u0, tspan)
     resid_f = Array{Float64}(undef, 2)
     sol = solve(bvp, Shooting(Tsit5()))
     sol2 = solve(bvp)
-    
+
     @test sol2.alg == Tsit5()
     @test all(sol.u .== sol2.u)
-end
+end

test/misc/qa_tests.jl

@@ -1,10 +1,8 @@
 @testitem "Quality Assurance" begin
     using Aqua
 
-    Aqua.test_all(BoundaryValueDiffEq; 
-        ambiguities = false,
-        piracies = (broken = false, 
-                   treat_as_own = [SciMLBase.BVProblem]))
+    Aqua.test_all(BoundaryValueDiffEq; ambiguities = false,
+        piracies = (broken = false, treat_as_own = [SciMLBase.BVProblem]))
 end
 
 @testitem "JET Package Test" begin