Commit d11a29b
committed
Fix more RAT-v4 iteration semantics misses
Three more spots that iterate or index `AbstractVectorOfArray`
with pre-RAT-v4 semantics, surfaced by CI on the previous commit:
1. `lib/BoundaryValueDiffEqMIRK/src/adaptivity.jl:39,93,148` —
`[maximum(abs, d) for d in errors]` where `cache.errors` is
a `VectorOfArray`. Under RAT v4 this iterates **scalars**,
producing a `Vector{Float64}` of length `prod(size(errors))`
instead of one entry per timestep, which then fails
`ŝ ./= mesh_dt` with `DimensionMismatch`. Fix: iterate
`errors.u`. (Lines 204–205 already had this fix.)
2. `lib/BoundaryValueDiffEqFIRK/src/adaptivity.jl:263` —
identical pattern with `defect`.
3. `lib/BoundaryValueDiffEqShooting/src/multiple_shooting.jl:531-532`
— `length(first(u0_))` / `similar(first(u0_), …)` where `u0_`
is the `VectorOfArray` returned by `__initial_guess_on_mesh`.
Under RAT v4 `first(u0_)` is the first scalar, so
`similar(::Float64, ::Int)` throws `MethodError`. Fix:
`first(u0_.u)`.
Bumps MIRK / FIRK / Shooting patch versions to 1.16.1.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>1 parent 6c1eac1 commit d11a29b
6 files changed
Lines changed: 9 additions & 9 deletions
File tree
- lib
- BoundaryValueDiffEqFIRK
- src
- BoundaryValueDiffEqMIRK
- src
- BoundaryValueDiffEqShooting
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | | - | |
| 263 | + | |
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
| 148 | + | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
528 | 528 | | |
529 | 529 | | |
530 | 530 | | |
531 | | - | |
532 | | - | |
| 531 | + | |
| 532 | + | |
533 | 533 | | |
534 | 534 | | |
535 | 535 | | |
| |||
0 commit comments