Merge pull request #459 from ChrisRackauckas-Claude/use-warn-on-resize

Use PreallocationTools warn_on_resize instead of NullLogger workaround

Author: ChrisRackauckas

lib/BoundaryValueDiffEqCore/Project.toml

@@ -13,7 +13,6 @@ ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
 Integrals = "de52edbc-65ea-441a-8357-d3a637375a31"
 LineSearch = "87fe0de2-c867-4266-b59a-2f0a94fc965b"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
-Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
 NonlinearSolveBase = "be0214bd-f91f-a760-ac4e-3421ce2b2da0"
 NonlinearSolveFirstOrder = "5959db7a-ea39-4486-b5fe-2dd0bf03d60d"
 OptimizationBase = "bca83a33-5cc9-4baa-983d-23429ab6bcbb"
@@ -40,11 +39,10 @@ Integrals = "4.7.1, 5"
 InteractiveUtils = "<0.0.1, 1"
 LineSearch = "0.1.4"
 LinearAlgebra = "1.10"
-Logging = "1.10"
 NonlinearSolveBase = "2.11.2"
 NonlinearSolveFirstOrder = "1.2, 2"
 OptimizationBase = "3.2.0, 4, 5"
-PreallocationTools = "0.4, 1"
+PreallocationTools = "1.2"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
 SciMLBase = "2.152.1"

lib/BoundaryValueDiffEqCore/src/BoundaryValueDiffEqCore.jl

@@ -8,7 +8,6 @@ using ConcreteStructs: @concrete
 using DiffEqBase: DiffEqBase, solve
 using ForwardDiff: ForwardDiff, pickchunksize
 using Integrals: Integrals, IntegralProblem
-using Logging: Logging
 using LinearAlgebra
 using LineSearch: BackTracking
 using NonlinearSolveFirstOrder: NonlinearSolvePolyAlgorithm

lib/BoundaryValueDiffEqCore/src/types.jl

@@ -171,19 +171,15 @@ end
 end
 
 function __maybe_allocate_diffcache(x, chunksize, jac_alg)
-    return __needs_diffcache(jac_alg) ? DiffCache(x, chunksize) : x
+    return __needs_diffcache(jac_alg) ?
+        DiffCache(x, chunksize; warn_on_resize = false) : x
 end
-__maybe_allocate_diffcache(x::DiffCache, chunksize) = DiffCache(zero(x.du), chunksize)
-
-## get_tmp shows a warning as it should on cache expansion, this behavior however is
-## expected for adaptive BVP solvers so we write our own `get_tmp` and drop the warning logs
-
-@inline function get_tmp(dc, u)
-    return Logging.with_logger(Logging.NullLogger()) do
-        PreallocationTools.get_tmp(dc, u)
-    end
+function __maybe_allocate_diffcache(x::DiffCache, chunksize)
+    return DiffCache(zero(x.du), chunksize; warn_on_resize = false)
 end
 
+@inline get_tmp(dc, u) = dc
+
 # DiffCache
 struct DiffCacheNeeded end
 struct NoDiffCacheNeeded end