test: isolate root QA into canonical test/qa sub-environment

Move the root package's Quality Assurance tests (Aqua + JET) into an
isolated test/qa/ Project so the QA tooling dependencies no longer enter
the main test target's resolve, matching the canonical OrdinaryDiffEq
lib/<Name>/test/qa/ structure.

- Add test/qa/Project.toml: deps Aqua, JET, Optimization, Test;
  [sources] Optimization = {path = "../.."}; [compat] for each + julia 1.10.
- Move test/qa.jl -> test/qa/qa.jl (Aqua + JET tests preserved verbatim;
  add `using Test` so the file is self-contained in the isolated env).
- runtests.jl: add activate_qa_env() (Pkg.activate(test/qa) + instantiate,
  plus develop-by-path on Julia < 1.11 where [sources] is ignored). The QA
  safetestset now runs last in the Core group after activating the qa env,
  so the main-environment tests above are unaffected. CI dispatches only
  GROUP=Core, so QA continues to run exactly as before.
- Remove Aqua and JET from the main Project.toml [extras], [targets].test,
  and [compat]; they now live solely in the qa environment.

Verified on Julia 1.11 in an isolated depot: the qa env instantiates and
resolves (Aqua 0.8.16, JET 0.9.20, Optimization 5.6.1 via ../.., Test
1.11.0); the Aqua testset runs green (10/10 pass). No sublibrary runs QA
today (the three that list Aqua in [extras] never call it), so per the
preserve-existing-behavior rule none were given a qa env.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: ChrisRackauckas

Project.toml

@@ -34,7 +34,6 @@ path = "lib/OptimizationOptimisers"
 
 [compat]
 ADTypes = "1.18"
-Aqua = "0.8"
 ArrayInterface = "7.10"
 BenchmarkTools = "1"
 Boltz = "1"
@@ -48,7 +47,6 @@ Flux = "0.13, 0.14, 0.15, 0.16"
 ForwardDiff = "0.10, 1"
 Ipopt = "1"
 IterTools = "1.3"
-JET = "0.9, 0.10, 0.11"
 LinearAlgebra = "1.10"
 LinearSolve = "3.64.0"
 Logging = "1.10"
@@ -83,7 +81,6 @@ Zygote = "0.6, 0.7"
 julia = "1.10"
 
 [extras]
-Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
 Boltz = "4544d5e4-abc5-4dea-817f-29e4c205d9c8"
 ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
@@ -94,7 +91,6 @@ Flux = "587475ba-b771-5e3f-ad9e-33799f191a9c"
 ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
 Ipopt = "b6b21f68-93f8-5de0-b562-5493be1d77c9"
 IterTools = "c8e1da08-722c-5040-9ed9-7db0dc04731e"
-JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 Lux = "b2108857-7c20-44ae-9111-449ecde12c47"
 MLUtils = "f1d291b0-491e-4a28-83b9-f70985020b54"
@@ -120,4 +116,4 @@ Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
 Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [targets]
-test = ["Aqua", "BenchmarkTools", "Boltz", "ComponentArrays", "DiffEqFlux", "Enzyme", "FiniteDiff", "Flux", "ForwardDiff", "Ipopt", "IterTools", "JET", "LinearSolve", "Lux", "MLUtils", "ModelingToolkit", "Optim", "OptimizationLBFGSB", "OptimizationMOI", "OptimizationOptimJL", "OptimizationOptimisers", "OrdinaryDiffEqTsit5", "Pkg", "Random", "ReverseDiff", "SafeTestsets", "SciMLSensitivity", "SparseArrays", "Symbolics", "Test", "Tracker", "Zygote", "Mooncake", "SciMLLogging"]
+test = ["BenchmarkTools", "Boltz", "ComponentArrays", "DiffEqFlux", "Enzyme", "FiniteDiff", "Flux", "ForwardDiff", "Ipopt", "IterTools", "LinearSolve", "Lux", "MLUtils", "ModelingToolkit", "Optim", "OptimizationLBFGSB", "OptimizationMOI", "OptimizationOptimJL", "OptimizationOptimisers", "OrdinaryDiffEqTsit5", "Pkg", "Random", "ReverseDiff", "SafeTestsets", "SciMLSensitivity", "SparseArrays", "Symbolics", "Test", "Tracker", "Zygote", "Mooncake", "SciMLLogging"]

test/qa/Project.toml

@@ -0,0 +1,15 @@
+[deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
+Optimization = "7f7a1694-90dd-40f0-9382-eb1efda571ba"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+
+[sources]
+Optimization = {path = "../.."}
+
+[compat]
+Aqua = "0.8"
+JET = "0.9, 0.10, 0.11"
+Optimization = "5"
+Test = "1.10"
+julia = "1.10"

test/qa.jl test/qa/qa.jltest/qa.jl renamed to test/qa/qa.jl

@@ -1,4 +1,6 @@
 using Optimization, Aqua, JET
+using Test
+
 @testset "Aqua" begin
     Aqua.find_persistent_tasks_deps(Optimization)
     Aqua.test_ambiguities(Optimization, recursive = false)

test/runtests.jl

@@ -9,6 +9,17 @@ function activate_downstream_env()
     return Pkg.instantiate()
 end
 
+# QA (Aqua + JET) runs in an isolated environment (test/qa) so its tooling deps
+# never enter the main test target's resolve. On Julia < 1.11 the [sources] table
+# is ignored, so develop the package by path to test the PR branch code.
+function activate_qa_env()
+    Pkg.activate(joinpath(@__DIR__, "qa"))
+    if VERSION < v"1.11.0-DEV.0"
+        Pkg.develop(PackageSpec(path = dirname(@__DIR__)))
+    end
+    return Pkg.instantiate()
+end
+
 @time begin
     # Detect sublibrary test groups.
     # GROUP can be a bare sublibrary name (Core test group) or
@@ -74,7 +85,6 @@ end
         end
     elseif GROUP == "Core"
         @testset verbose = true "Optimization.jl" begin
-            @safetestset "Quality Assurance" include("qa.jl")
             @safetestset "Utils Tests" include("utils.jl")
             @safetestset "Verbosity Tests" include("verbosity.jl")
             @safetestset "AD Tests" include("ADtests.jl")
@@ -86,6 +96,10 @@ end
             # @safetestset "DiffEqFlux" include("diffeqfluxtests.jl")
             @safetestset "Interface Compatibility" include("interface_tests.jl")
             @safetestset "Sense Handling" include("sense_tests.jl")
+            # QA runs last so the isolated qa environment is activated only after the
+            # main-environment tests above have finished.
+            activate_qa_env()
+            @safetestset "Quality Assurance" include("qa/qa.jl")
         end
     elseif GROUP == "GPU"
         activate_downstream_env()