More sublibrary QA fixes: compat entries + JET nothing-guard

- OptimizationManopt: add [compat] for the Aqua-check_extras extras (Aqua,
  QuadraticModels, Random, ReverseDiff, RipQP, Test, Zygote); its Aqua run was
  previously masked by the qa.jl syntax error.
- OptimizationBase: add Mooncake weakdep compat ("0.4.138, 0.5", matching the
  root project) for Aqua check_weakdeps.
- OptimizationBase (function.jl): guard `open_brkt_ind` against `nothing`
  before subtracting in the AD-package-not-loaded error path. JET could not
  prove the elseif branches return an Int, so it flagged `-(::Nothing, ::Int64)`
  (same fix as SimpleOptimization, which copied this code).

With this, the earlier DISparseExt hoist cleared OptimizationBase's 6
cons_oop/lagrangian JET findings, leaving only this one, now fixed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: jClugstor

lib/OptimizationBase/Project.toml

@@ -66,6 +66,7 @@ LinearAlgebra = "1.9, 1.10"
 Lux = "1.12"
 MLDataDevices = "1"
 MLUtils = "0.4"
+Mooncake = "0.4.138, 0.5"
 Manifolds = "0.10, 0.11"
 ModelingToolkit = "11"
 Optim = ">= 1.4.1"

lib/OptimizationBase/src/function.jl

@@ -273,6 +273,7 @@ function instantiate_function(
     else
         min(open_nrmlbrkt_ind, open_squigllybrkt_ind)
     end
-    adpkg = adtypestr[strtind:(open_brkt_ind - 1)]
+    lastidx = isnothing(open_brkt_ind) ? lastindex(adtypestr) : (open_brkt_ind - 1)
+    adpkg = adtypestr[strtind:lastidx]
     throw(ArgumentError("The passed automatic differentiation backend choice is not available. Please load the corresponding AD package $adpkg."))
 end

lib/OptimizationManopt/Project.toml

@@ -33,8 +33,15 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 OptimizationBase = {path = "../OptimizationBase"}
 
 [compat]
+Aqua = "0.8"
 Pkg = "1"
+QuadraticModels = "0.9"
+Random = "1.10"
+ReverseDiff = "1.14"
+RipQP = "0.7"
 SafeTestsets = "0.1"
+Test = "1.10"
+Zygote = "0.6.67, 0.7"
 julia = "1.10"
 Dates = "1.10"
 DifferentiationInterface = "0.7.13"