Skip to content

Commit a965256

Browse files
jClugstorclaude
andcommitted
Revert OptimizationManopt edits; split into separate PR
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 1de3795 commit a965256

2 files changed

Lines changed: 10 additions & 30 deletions

File tree

lib/OptimizationManopt/Project.toml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ OptimizationBase = "bca83a33-5cc9-4baa-983d-23429ab6bcbb"
88
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
99
ManifoldsBase = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
1010
ManifoldDiff = "af67fdf4-a580-4b9f-bbec-742ef357defd"
11+
Manifolds = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
1112
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
1213
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
1314

@@ -24,37 +25,23 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
2425
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
2526
FiniteDiff = "6a86dc24-6348-571c-b903-95158fe2bd41"
2627
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
27-
Manifolds = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
28-
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
29-
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
3028

3129
[sources]
3230
OptimizationBase = {path = "../OptimizationBase"}
3331

3432
[compat]
35-
Aqua = "0.8"
33+
Pkg = "1"
34+
SafeTestsets = "0.1"
35+
julia = "1.10"
3636
DifferentiationInterface = "0.7"
37-
Enzyme = "0.13"
38-
FiniteDiff = "2"
39-
ForwardDiff = "0.10, 1"
40-
JET = "0.9, 0.10, 0.11"
41-
LinearAlgebra = "1.10"
42-
ManifoldDiff = "0.4"
43-
Manifolds = "0.10, 0.11"
44-
ManifoldsBase = "1"
4537
Manopt = "0.5.25"
4638
OptimizationBase = "5.1"
47-
Pkg = "1"
48-
QuadraticModels = "0.9"
49-
Random = "1.10"
39+
LinearAlgebra = "1.10"
40+
ManifoldsBase = "1"
41+
ManifoldDiff = "0.4"
42+
Manifolds = "0.10"
5043
Reexport = "1.2"
51-
ReverseDiff = "1"
52-
RipQP = "0.6"
53-
SafeTestsets = "0.1"
5444
SciMLBase = "2.122.1, 3"
55-
Test = "1.10"
56-
Zygote = "0.6, 0.7"
57-
julia = "1.10"
5845

5946
[targets]
60-
test = ["Aqua", "DifferentiationInterface", "Enzyme", "ForwardDiff", "FiniteDiff", "JET", "Manifolds", "QuadraticModels", "Random", "ReverseDiff", "RipQP", "Test", "Zygote", "SafeTestsets", "Pkg"]
47+
test = ["DifferentiationInterface", "Enzyme", "ForwardDiff", "FiniteDiff", "QuadraticModels", "Random", "ReverseDiff", "RipQP", "Test", "Zygote", "SafeTestsets", "Pkg"]

lib/OptimizationManopt/test/qa/qa.jl

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,7 @@ using OptimizationManopt, Aqua, JET
22
using Test
33

44
@testset "Aqua" begin
5-
# `@reexport using Manopt` exports `solve!`, which clashes with SciMLBase's `solve!`
6-
# brought in transitively via OptimizationBase. The clash leaves OptimizationManopt's
7-
# `solve!` export pointing at neither binding; mark broken until the reexport is
8-
# restructured.
9-
Aqua.test_all(
10-
OptimizationManopt;
11-
undefined_exports = (; broken = true)
12-
)
5+
Aqua.test_all(OptimizationManopt)
136
end
147

158
@testset "JET static analysis" begin

0 commit comments

Comments
 (0)