Commit cff51dd
Fix OptimizationMOI Aqua QA: allowed piracy + ReverseDiff compat
Two pre-existing Aqua failures in the OptimizationMOI QA suite:
- Declare the SciMLBase solver-trait methods defined on the MathOptInterface
optimizer types (`__init`, `allowsbounds`, `requiresgradient`, ...) as allowed
via `piracies = (treat_as_own = [...],)`. These are an intentional interface
extension, not piracy.
- Add the missing `[compat]` bound for `ReverseDiff` (a test-only `[extras]`
dependency), which Aqua's deps_compat check requires.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RtJAi7bALH5XkakjS6Yb6j1 parent a3a7104 commit cff51dd
2 files changed
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
6 | 16 | | |
7 | 17 | | |
8 | 18 | | |
| |||
0 commit comments