Commit 855b081
committed
Make weave_folder re-throw at end if any .jmd failed
Per-file ProcessFailedException was previously caught and only @error'd,
so benchmark.jl always exited 0 even when one or more .jmd files
actually failed — CI showed green despite real failures (e.g. the
ComplicatedPDE/Filament.jmd ADTypes missing-dep bug masked until #1589).
Collect failures and throw at end. Per-file 'continue on failure'
behaviour is preserved (so one bad .jmd doesn't block others from
producing artifacts), but the job now exits non-zero if anything failed.
This will cause master CI to start showing red for folders that have
been silently failing — that's the intended behaviour; the goal is for
red CI to reflect real failures.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>1 parent a4a9639 commit 855b081
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
98 | 99 | | |
99 | 100 | | |
100 | 101 | | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
| 105 | + | |
103 | 106 | | |
104 | 107 | | |
105 | 108 | | |
| |||
0 commit comments