Make tests more resilient (#124)

* feat: make tests work more consistently
* fix: improve visibility detection
* chore: update CI
---------

Signed-off-by: Luca Foppiano <luca@foppiano.org>

Author: lfoppiano

.github/workflows/ci-build.yml

@@ -1,6 +1,9 @@
 name: Build unstable
 
-on: [ push, pull_request ]
+on:
+  push:
+    branches: [ main ]
+  pull_request:
 
 concurrency:
   group: unstable
@@ -18,13 +21,13 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}
           cache: 'pip'
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{matrix.node-version}}
       - name: build frontend

.github/workflows/ci-bump-version.yml

@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout the code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Bump version
         id: bump

.github/workflows/ci-release.yml

@@ -14,13 +14,13 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Set up Python 3.9
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.9"
           cache: 'pip'
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v6
         with:
           node-version: "18"
       - name: build frontend

streamlit_pdf_viewer/frontend/src/PdfViewer.vue

@@ -381,6 +381,8 @@ export default {
 
     const handleResize = async () => {
       if (isRendering.value) return;
+      // Skip render if container is hidden (e.g., inactive Streamlit tab)
+      if (pdfContainer.value && pdfContainer.value.clientWidth === 0) return;
       isRendering.value = true;
       try {
         const binaryDataUrl = `data:application/pdf;base64,${props.args.binary}`;
@@ -464,15 +466,29 @@ export default {
 
     const debouncedHandleResize = debounce(handleResize, 200);
 
+    let lastContainerWidth = 0;
+    const resizeObserver = new ResizeObserver((entries) => {
+      const entry = entries[0];
+      const newWidth = entry.contentRect.width;
+      if (lastContainerWidth === 0 && newWidth > 0) {
+        debouncedHandleResize();
+      }
+      lastContainerWidth = newWidth;
+    });
+
     onMounted(() => {
       debouncedHandleResize();
       window.addEventListener("resize", debouncedHandleResize);
       document.addEventListener('click', handleClickOutside);
+      if (pdfContainer.value) {
+        resizeObserver.observe(pdfContainer.value);
+      }
     });
 
     onUnmounted(() => {
       window.removeEventListener("resize", debouncedHandleResize);
       document.removeEventListener('click', handleClickOutside);
+      resizeObserver.disconnect();
     });
 
     return {

tests/conftest.py

@@ -16,7 +16,7 @@
 import pytest
 from pathlib import Path
 from typing import Generator, Any, Dict
-from playwright.sync_api import Browser, BrowserContext, Page
+from playwright.sync_api import Browser, BrowserContext, Page, expect
 
 from tests import ROOT_DIRECTORY
 from tests.e2e_utils import StreamlitRunner
@@ -143,7 +143,7 @@ def default_go_to_app(page: Page, default_streamlit_app: StreamlitRunner):
     """Navigate to the default streamlit app and wait for it to load."""
     page.goto(default_streamlit_app.server_url)
     # Wait for app to load
-    page.get_by_role("img", name="Running...").is_hidden()
+    expect(page.get_by_role("img", name="Running...")).not_to_be_visible()
 
 
 @pytest.fixture(autouse=True, scope="module")
@@ -164,4 +164,4 @@ def go_to_app(page: Page, streamlit_app: StreamlitRunner):
     """
     page.goto(streamlit_app.server_url)
     # Wait for app to load
-    page.get_by_role("img", name="Running...").is_hidden()
+    expect(page.get_by_role("img", name="Running...")).not_to_be_visible()

tests/e2e_utils.py

@@ -160,7 +160,7 @@ def is_server_running(self, timeout: int = 30) -> bool:
                     if response.text == "ok":
                         return True
                 time.sleep(3)
-                if time.time() - start_time > 60 * timeout:
+                if time.time() - start_time > timeout:
                     return False
 
     @property

tests/test_accessibility.py

@@ -83,11 +83,9 @@ def test_accessibility_high_contrast_mode(page: Page):
         }
     """)
 
-    page.wait_for_timeout(1000)
-    
     iframe_components = page.locator('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]')
     expect(iframe_components).to_have_count(1)
-    
+
     # Check that the viewer is still visible and functional in high contrast
     iframe_frame = page.frame_locator('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]').nth(0)
     pdf_viewer = iframe_frame.locator('div[id="pdfViewer"]')
@@ -109,8 +107,8 @@ def test_accessibility_responsive_text_sizing(page: Page):
 
     for viewport in viewports:
         page.set_viewport_size(viewport)
-        page.wait_for_timeout(1000)
-        
+        page.wait_for_timeout(500)
+
         iframe_components = page.locator('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]')
         expect(iframe_components).to_have_count(1)
 

tests/test_alignment_center.py

@@ -31,7 +31,7 @@ def streamlit_app():
 def go_to_app(page: Page, streamlit_app: StreamlitRunner):
     page.goto(streamlit_app.server_url)
     # Wait for app to load
-    page.get_by_role("img", name="Running...").is_hidden()
+    expect(page.get_by_role("img", name="Running...")).not_to_be_visible()
 
 
 def test_should_render_with_center_alignment(page: Page):

tests/test_alignment_left.py

@@ -31,7 +31,7 @@ def streamlit_app():
 def go_to_app(page: Page, streamlit_app: StreamlitRunner):
     page.goto(streamlit_app.server_url)
     # Wait for app to load
-    page.get_by_role("img", name="Running...").is_hidden()
+    expect(page.get_by_role("img", name="Running...")).not_to_be_visible()
 
 
 def test_should_render_with_left_alignment(page: Page):

tests/test_alignment_right.py

@@ -31,7 +31,7 @@ def streamlit_app():
 def go_to_app(page: Page, streamlit_app: StreamlitRunner):
     page.goto(streamlit_app.server_url)
     # Wait for app to load
-    page.get_by_role("img", name="Running...").is_hidden()
+    expect(page.get_by_role("img", name="Running...")).not_to_be_visible()
 
 
 def test_should_render_with_right_alignment(page: Page):