Skip to content

Commit 0415abb

Browse files
nseidandantuzi
authored andcommitted
Respond to Pablo's feedback
1 parent 7e27e50 commit 0415abb

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

rre-dataset-generator/src/search_engine/opensearch_engine.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def fetch_for_query_generation(self,
2727
documents_filter: Union[None, List[Dict[str, List[str]]]],
2828
doc_number: int,
2929
doc_fields: List[str]) -> List[Document]:
30+
"""Fetches a list of documents for query generation based on optional filters."""
3031
filters = []
3132
if documents_filter:
3233
for field_values in documents_filter:
@@ -60,6 +61,7 @@ def fetch_for_query_generation(self,
6061
return self._search(payload)
6162

6263
def fetch_for_evaluation(self, query_template: str, doc_fields: List[str], keyword: str = "*") -> List[Document]:
64+
"""Fetches documents for evaluation by executing a query built from a template."""
6365
query = query_template.replace(self.PLACEHOLDER, keyword)
6466
fields = doc_fields if self.UNIQUE_KEY in doc_fields else doc_fields + [self.UNIQUE_KEY]
6567

@@ -74,7 +76,9 @@ def fetch_for_evaluation(self, query_template: str, doc_fields: List[str], keywo
7476
return self._search(payload)
7577

7678
def _search(self, payload: Dict[str, Any]) -> List[Document]:
79+
"""Perform a search to OpenSearch and return matching documents based on the given payload."""
7780
search_url = f"{self.endpoint}/_search"
81+
log.debug(f"User-specified fields: {payload.get('_source')}")
7882
try:
7983
response = requests.post(search_url, headers=self.HEADERS, json=payload)
8084
response.raise_for_status()
@@ -87,6 +91,7 @@ def _search(self, payload: Dict[str, Any]) -> List[Document]:
8791

8892
for hit in hits:
8993
source = hit.get("_source", {})
94+
log.debug(f"Opensearch returns fields based on payload: {list(source.items())}")
9095
doc_id = source.get("id", hit.get("_id"))
9196

9297
fields = {

0 commit comments

Comments
 (0)