Updated - fixed minors

Author: Intrinsical-AI

rre-dataset-generator/src/model/query_rating_context.py

@@ -70,4 +70,5 @@ def to_dict(self) -> Dict[str, Any]:
             "query_id": self._id,
             "query_text": self._query,
             "doc_ratings": self._doc_id_to_rating_score
-        }
+        }
+

rre-dataset-generator/tests/unit/test_data_store.py

@@ -29,68 +29,68 @@ def sample_store():
 
 @pytest.fixture
 def set_tmp_file(tmp_path, monkeypatch):
-    """Fija la ruta del datastore a un archivo temporal y la devuelve."""
+    """Sets the datastore path to a temporary file and returns it."""
     path = tmp_path / "datastore.json"
     monkeypatch.setattr(data_store, "TMP_FILE", str(path), raising=False)
     return path
 
 
-def test_add_and_get_document(empty_store):
+def test_datastore_add_and_get_document__expects__retrieve(empty_store):
     doc = Document(id="dX", fields={"title": "New"})
     empty_store.add_document("dX", doc)
     assert empty_store.get_document("dX") == doc
 
 
-def test_add_duplicate_document_raises(empty_store):
+def test_datastore_add_duplicate_document__expects__raises_error(empty_store):
     doc = Document(id="d1", fields={"text": "some text"})
     empty_store.add_document("d1", doc)
     with pytest.raises(KeyError):
         empty_store.add_document("d1", doc)
 
 
-def test_add_query_rating_and_has_rating_flag(empty_store):
+def test_datastore_add_query__expect__query_rating_and_has_rating(empty_store):
     qid = empty_store.add_query("test", doc_id="d1")
-    # centinela: sin rating aún
+    # sentinel: without rating yet
     assert empty_store.has_rating_score(qid, "d1") is False
     empty_store.add_rating_score(qid, "d1", 1)
     assert empty_store.get_rating_score(qid, "d1") == 1
     assert empty_store.has_rating_score(qid, "d1") is True
 
 
-def test_add_query_same_text_returns_same_id_and_adds_doc(empty_store):
+def test_datastore_add_query__expect__same_text_returns_same_id_and_adds_doc(empty_store):
     qid1 = empty_store.add_query("Q", doc_id="d1")
-    # mismo texto de query -> mismo id; añade doc_id nuevo
+    # same query text -> same id; adds new doc_id
     qid2 = empty_store.add_query("Q", doc_id="d2")
     assert qid1 == qid2
     ctx = empty_store.get_query(qid1)
     assert set(ctx.get_doc_ids()) == {"d1", "d2"}
-    # el nuevo doc todavía no tiene rating
+    # the new doc still has no rating
     assert empty_store.has_rating_score(qid1, "d2") is False
 
 
-def test_save_raises_if_query_refs_missing_doc(empty_store, set_tmp_file):
-    # referencia a doc inexistente -> save debe fallar
+def test_datastore_save__expect__raises_if_query_references_missing_doc(empty_store, set_tmp_file):
+    # reference to non-existent doc -> save must fail
     qid = empty_store.add_query("missing-doc-case", doc_id="d_missing")
     with pytest.raises(KeyError):
         empty_store.save_tmp_file_content()
 
 
-def test_save_and_load_roundtrip(set_tmp_file):
+def test_datastore_save_and_load__expects__valid_happy_path(set_tmp_file):
     ds1 = DataStore(ignore_saved_data=True)
     doc = Document(id="d1", fields={"text": "some text"})
     ds1.add_document("d1", doc)
     qid = ds1.add_query("test", doc_id="d1")
     ds1.add_rating_score(qid, "d1", 1)
     ds1.save_tmp_file_content()
 
-    # Carga automática en __init__ porque ignore_saved_data=False
+    # Auto load in __init__ because ignore_saved_data=False
     ds2 = DataStore(ignore_saved_data=False)
     assert ds2.get_query(qid).get_query_text() == "test"
     assert ds2.get_rating_score(qid, "d1") == 1
     assert ds2.get_document("d1") == doc
 
 
-def test_load_with_duplicate_query_text(set_tmp_file):
+def test_datastore_load__expects__error_on_duplicate_query_text(set_tmp_file):
     content = {
         "queries": {
             "q1": {"query_id": "q1", "query_text": "dup", "doc_ratings": {}},
@@ -105,18 +105,18 @@ def test_load_with_duplicate_query_text(set_tmp_file):
 
 
 @pytest.mark.parametrize("content", [
-    # Mismatch outer (key) vs inner query_id -> debe fallar
+    # Mismatch outer (key) vs inner query_id -> must fail
     {
         "queries": {"q1": {"query_id": "DIFF", "query_text": "x", "doc_ratings": {}}},
         "documents": {},
     },
-    # Documento con id interno distinto al de la clave -> debe fallar
+    # Document with internal id different from the key -> must fail
     {
         "queries": {},
         "documents": {"d1": {"id": "dX", "fields": {"text": "x"}}},
     },
 ])
-def test_load_rejects_inconsistent_payloads(set_tmp_file, content):
+def test_datastore_load__expects__rejects_inconsistent_payloads(set_tmp_file, content):
     set_tmp_file.write_text(json.dumps(content), encoding="utf-8")
     ds = DataStore(ignore_saved_data=True)
     with pytest.raises(KeyError):