Skip to content

Commit e5219c2

Browse files
Intrinsical-AIdantuzi
authored andcommitted
Pattern implemented on test naming - unified styling with __exists__
1 parent 87bf570 commit e5219c2

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

rre-dataset-generator/tests/unit/test_query_rating_context.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,29 +4,29 @@
44
from src.model.query_rating_context import QueryRatingContext
55

66

7-
def test_initialization_with_doc_id():
7+
def test_initialization__with_doc_id__expects__context_is_created_with_unrated_doc():
88
ctx = QueryRatingContext(query="AI", doc_id="d1")
99
assert ctx.get_query_text() == "AI"
1010
assert ctx.get_doc_ids() == ["d1"]
1111
assert ctx.has_rating_score("d1") is False
1212

1313

14-
def test_add_doc_id_and_rating():
14+
def test_add_rating_score__to_existing_doc__expects__rating_is_added():
1515
ctx = QueryRatingContext(query="AI")
1616
ctx.add_doc_id("d1")
1717
ctx.add_rating_score("d1", 1)
1818
assert ctx.get_rating_score("d1") == 1
1919
assert ctx.has_rating_score("d1") is True
2020

2121

22-
def test_overwrite_rating_score():
22+
def test_add_rating_score__when_rating_exists__expects__score_is_overwritten():
2323
ctx = QueryRatingContext(query="AI", doc_id="d1")
2424
ctx.add_rating_score("d1", 0)
2525
ctx.add_rating_score("d1", 1)
2626
assert ctx.get_rating_score("d1") == 1
2727

2828

29-
def test_to_and_from_dict_roundtrip():
29+
def test_serialization__to_and_from_dict__expects__data_is_preserved():
3030
ctx1 = QueryRatingContext(query="AI")
3131
ctx1.add_doc_id("d1")
3232
ctx1.add_rating_score("d1", 1)
@@ -37,14 +37,14 @@ def test_to_and_from_dict_roundtrip():
3737
assert ctx2.get_rating_score("d1") == 1
3838

3939

40-
def test_duplicate_doc_id_is_ignored():
40+
def test_add_doc_id__when_doc_id_exists__expects__duplicate_is_ignored():
4141
ctx = QueryRatingContext(query="AI")
4242
ctx.add_doc_id("d1")
4343
ctx.add_doc_id("d1") # should not raise or duplicate
4444
assert ctx.get_doc_ids() == ["d1"]
4545

4646

47-
def test_missing_rating_raises_keyerror():
47+
def test_get_rating_score__when_no_rating_exists__expects__keyerror_is_raised():
4848
ctx = QueryRatingContext(query="AI")
4949
ctx.add_doc_id("d1")
5050
with pytest.raises(KeyError):

0 commit comments

Comments
 (0)