[dotnet] Add C# 14 extension to polyfill ArgumentNullException.ThrowIfNull (#16697)

Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>

Author: RenderMichael

dotnet/BUILD.bazel

@@ -32,6 +32,9 @@ pkg_zip(
 filegroup(
     name = "source_files_support_needs_from_core",
     srcs = [
+        "//dotnet/src/webdriver:Properties/ArgumentNullExceptionExtensions.cs",
+        "//dotnet/src/webdriver:Properties/CallerArgumentExpressionAttribute.cs",
+        "//dotnet/src/webdriver:Properties/NullableAttributes.cs",
         "//dotnet/src/webdriver:Properties/StringSyntaxAttribute.cs",
         "//dotnet/src/webdriver:Properties/StringSyntaxConstants.cs",
     ],

dotnet/src/support/Events/EventFiringWebDriver.cs

@@ -36,7 +36,8 @@ public class EventFiringWebDriver : IWebDriver, IJavaScriptExecutor, ITakesScree
     /// <exception cref="ArgumentNullException">If <paramref name="parentDriver"/> is <see langword="null"/>.</exception>
     public EventFiringWebDriver(IWebDriver parentDriver)
     {
-        this.WrappedDriver = parentDriver ?? throw new ArgumentNullException(nameof(parentDriver));
+        ArgumentNullException.ThrowIfNull(parentDriver);
+        this.WrappedDriver = parentDriver;
     }
 
     /// <summary>
@@ -537,10 +538,7 @@ protected virtual async ValueTask DisposeAsyncCore()
     /// </remarks>
     public object? ExecuteScript(PinnedScript script, params object?[] args)
     {
-        if (script == null)
-        {
-            throw new ArgumentNullException(nameof(script));
-        }
+        ArgumentNullException.ThrowIfNull(script);
 
         if (this.WrappedDriver is not IJavaScriptExecutor javascriptDriver)
         {
@@ -808,7 +806,8 @@ private class EventFiringNavigation : INavigation
         /// <param name="driver">Driver in use</param>
         public EventFiringNavigation(EventFiringWebDriver driver)
         {
-            this.parentDriver = driver ?? throw new ArgumentNullException(nameof(driver));
+            ArgumentNullException.ThrowIfNull(driver);
+            this.parentDriver = driver;
             this.wrappedNavigation = this.parentDriver.WrappedDriver.Navigate();
         }
 
@@ -1025,7 +1024,8 @@ private class EventFiringTargetLocator : ITargetLocator
         /// <param name="driver">The driver that is currently in use</param>
         public EventFiringTargetLocator(EventFiringWebDriver driver)
         {
-            this.parentDriver = driver ?? throw new ArgumentNullException(nameof(driver));
+            ArgumentNullException.ThrowIfNull(driver);
+            this.parentDriver = driver;
             this.wrappedLocator = this.parentDriver.WrappedDriver.SwitchTo();
         }
 
@@ -1297,8 +1297,10 @@ private class EventFiringWebElement : ITakesScreenshot, IWebElement, IWrapsEleme
         /// <param name="element">The <see cref="IWebElement"/> to wrap for event firing.</param>
         public EventFiringWebElement(EventFiringWebDriver driver, IWebElement element)
         {
-            this.WrappedElement = element ?? throw new ArgumentNullException(nameof(element));
-            this.parentDriver = driver ?? throw new ArgumentNullException(nameof(driver));
+            ArgumentNullException.ThrowIfNull(element);
+            ArgumentNullException.ThrowIfNull(driver);
+            this.WrappedElement = element;
+            this.parentDriver = driver;
         }
 
         /// <summary>
@@ -1773,7 +1775,8 @@ private class EventFiringShadowRoot : ISearchContext, IWrapsDriver, IEquatable<I
         /// <param name="searchContext">The <see cref="ISearchContext"/> to wrap for event firing.</param>
         public EventFiringShadowRoot(EventFiringWebDriver driver, ISearchContext searchContext)
         {
-            this.WrappedSearchContext = searchContext ?? throw new ArgumentNullException(nameof(searchContext));
+            ArgumentNullException.ThrowIfNull(searchContext);
+            this.WrappedSearchContext = searchContext;
             this.parentDriver = driver;
         }
 

dotnet/src/support/Events/FindElementEventArgs.cs

@@ -44,9 +44,11 @@ public FindElementEventArgs(IWebDriver driver, By method)
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="method"/> are <see langword="null"/>.</exception>
     public FindElementEventArgs(IWebDriver driver, IWebElement? element, By method)
     {
-        this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
+        ArgumentNullException.ThrowIfNull(driver);
+        ArgumentNullException.ThrowIfNull(method);
+        this.Driver = driver;
         this.Element = element;
-        this.FindMethod = method ?? throw new ArgumentNullException(nameof(method));
+        this.FindMethod = method;
     }
 
     /// <summary>

dotnet/src/support/Events/GetShadowRootEventArgs.cs

@@ -32,8 +32,10 @@ public class GetShadowRootEventArgs : EventArgs
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="searchContext"/> are <see langword="null"/>.</exception>
     public GetShadowRootEventArgs(IWebDriver driver, ISearchContext searchContext)
     {
-        this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
-        this.SearchContext = searchContext ?? throw new ArgumentNullException(nameof(searchContext));
+        ArgumentNullException.ThrowIfNull(driver);
+        ArgumentNullException.ThrowIfNull(searchContext);
+        this.Driver = driver;
+        this.SearchContext = searchContext;
     }
 
     /// <summary>

dotnet/src/support/Events/WebDriverExceptionEventArgs.cs

@@ -32,8 +32,10 @@ public class WebDriverExceptionEventArgs : EventArgs
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="thrownException"/> are <see langword="null"/>.</exception>
     public WebDriverExceptionEventArgs(IWebDriver driver, Exception thrownException)
     {
-        this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
-        this.ThrownException = thrownException ?? throw new ArgumentNullException(nameof(thrownException));
+        ArgumentNullException.ThrowIfNull(driver);
+        ArgumentNullException.ThrowIfNull(thrownException);
+        this.Driver = driver;
+        this.ThrownException = thrownException;
     }
 
     /// <summary>

dotnet/src/support/Events/WebDriverNavigationEventArgs.cs

@@ -42,8 +42,9 @@ public WebDriverNavigationEventArgs(IWebDriver driver)
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> is <see langword="null"/>.</exception>
     public WebDriverNavigationEventArgs(IWebDriver driver, string? url)
     {
+        ArgumentNullException.ThrowIfNull(driver);
         this.Url = url;
-        this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
+        this.Driver = driver;
     }
 
     /// <summary>

dotnet/src/support/Events/WebDriverScriptEventArgs.cs

@@ -34,8 +34,10 @@ public class WebDriverScriptEventArgs : EventArgs
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="script"/> are <see langword="null"/>.</exception>
     public WebDriverScriptEventArgs(IWebDriver driver, [StringSyntax(StringSyntaxConstants.JavaScript)] string script)
     {
-        this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
-        this.Script = script ?? throw new ArgumentNullException(nameof(script));
+        ArgumentNullException.ThrowIfNull(driver);
+        ArgumentNullException.ThrowIfNull(script);
+        this.Driver = driver;
+        this.Script = script;
     }
 
     /// <summary>

dotnet/src/support/Events/WebElementEventArgs.cs

@@ -32,8 +32,10 @@ public class WebElementEventArgs : EventArgs
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> or <paramref name="element"/> are <see langword="null"/>.</exception>
     public WebElementEventArgs(IWebDriver driver, IWebElement element)
     {
-        this.Driver = driver ?? throw new ArgumentNullException(nameof(driver));
-        this.Element = element ?? throw new ArgumentNullException(nameof(element));
+        ArgumentNullException.ThrowIfNull(driver);
+        ArgumentNullException.ThrowIfNull(element);
+        this.Driver = driver;
+        this.Element = element;
     }
 
     /// <summary>

dotnet/src/support/Selenium.WebDriver.Support.csproj

@@ -44,6 +44,9 @@
     <!--Workaround for being unable to have two different types of the same name in WebDriver and in Support, despite both being internal-->
     <Compile Include="$(CsprojIncludePath)\Properties\StringSyntaxAttribute.cs" Link="Properties\StringSyntaxAttribute.cs" />
     <Compile Include="$(CsprojIncludePath)\Properties\StringSyntaxConstants.cs" Link="Properties\StringSyntaxConstants.cs" />
+    <Compile Include="$(CsprojIncludePath)\Properties\NullableAttributes.cs" Link="Properties\NullableAttributes.cs" />
+    <Compile Include="$(CsprojIncludePath)\Properties\CallerArgumentExpressionAttribute.cs" Link="Properties\CallerArgumentExpressionAttribute.cs" />
+    <Compile Include="$(CsprojIncludePath)\Properties\ArgumentNullExceptionExtensions.cs" Link="Properties\ArgumentNullExceptionExtensions.cs" />
   </ItemGroup>
 
 </Project>

dotnet/src/support/UI/PopupWindowFinder.cs

@@ -84,7 +84,8 @@ public PopupWindowFinder(IWebDriver driver, TimeSpan timeout)
     /// <exception cref="ArgumentNullException">If <paramref name="driver"/> is <see langword="null"/>.</exception>
     public PopupWindowFinder(IWebDriver driver, TimeSpan timeout, TimeSpan sleepInterval)
     {
-        this.driver = driver ?? throw new ArgumentNullException(nameof(driver));
+        ArgumentNullException.ThrowIfNull(driver);
+        this.driver = driver;
         this.timeout = timeout;
         this.sleepInterval = sleepInterval;
     }