[build] aggregate all lint errors instead of failing fast (#17637)

* [build] aggregate all lint errors instead of failing fast

* [build] remove counts from error message

Author: titusfortner

Rakefile

@@ -143,13 +143,17 @@ task :format do |_task, arguments|
   Rake::Task['all:format'].invoke(*args)
 end
 
-desc 'Run linters (may auto-fix some issues; stricter checks than :format)'
-task :lint do
-  puts 'Linting shell scripts and GitHub Actions...'
+def lint_actions
   shellcheck = Bazel.execute('build', [], '@multitool//tools/shellcheck')
   Bazel.execute('run', ['--', '-shellcheck', shellcheck], '@multitool//tools/actionlint:cwd')
+end
 
-  Rake::Task['all:lint'].invoke
+desc 'Run linters (may auto-fix some issues; stricter checks than :format)'
+task :lint do
+  SeleniumRake.aggregate_errors(
+    shellcheck_and_actionlint: -> { lint_actions },
+    all: -> { Rake::Task['all:lint'].invoke }
+  )
 end
 
 # Legacy aliases - call namespaced tasks
@@ -215,24 +219,18 @@ namespace :all do
   desc 'Validate release credentials for all languages'
   task :check_credentials do |_task, arguments|
     args = arguments.to_a
-    failures = []
-    %w[java py rb dotnet node].each do |lang|
-      Rake::Task["#{lang}:check_credentials"].invoke(*args)
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:check_credentials"].invoke(*args) }]
     end
-    raise "Credential check failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Verify all packages are published to their registries'
   task :verify do
-    failures = []
-    %w[java py rb dotnet node].each do |lang|
-      Rake::Task["#{lang}:verify"].invoke
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:verify"].invoke }]
     end
-    raise "Verification failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Release all artifacts for all language bindings'
@@ -257,15 +255,10 @@ namespace :all do
 
   desc 'Run linters for all language bindings'
   task :lint do
-    all_langs = %w[java py rb dotnet node]
-    failures = []
-    all_langs.each do |lang|
-      puts "Linting #{lang}..."
-      Rake::Task["#{lang}:lint"].invoke
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:lint"].invoke }]
     end
-    raise "Lint failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Update versions for all language bindings'

rake_tasks/common.rb

@@ -107,6 +107,20 @@ def self.update_changelog(version, language, path, changelog, header)
     File.write(changelog, "#{header}\n#{entries}\n\n#{content}")
   end
 
+  def self.aggregate_errors(**steps)
+    failures = steps.filter_map do |name, closure|
+      label = name.to_s.tr('_', ' ')
+      puts "Running #{label}..." unless name == :all
+      closure.call
+      nil
+    rescue StandardError => e
+      "#{label}: #{e.message}"
+    end
+    return if failures.empty?
+
+    raise failures.join("\n\n")
+  end
+
   def self.verify_package_published(url)
     puts "Verifying #{url}..."
     uri = URI(url)

rake_tasks/dotnet.rake

@@ -127,14 +127,16 @@ end
 
 desc 'Run .NET linter (dotnet format analyzers, docs)'
 task :lint do
-  puts '  Running dotnet format analyzers...'
-  Bazel.execute('run', ['--', 'analyzers', '--verify-no-changes'], '//dotnet:format')
-  Rake::Task['dotnet:docs_generate'].invoke
+  steps = {
+    dotnet_format_analyzers: -> { Bazel.execute('run', ['--', 'analyzers', '--verify-no-changes'], '//dotnet:format') },
+    dotnet_docs: -> { Rake::Task['dotnet:docs_generate'].invoke }
+  }
 
-  # TODO: Identify specific diagnostics that we want to enforce but can't be auto-corrected (e.g., 'IDE0060'):
   enforced_diagnostics = []
-  next if enforced_diagnostics.empty?
+  if enforced_diagnostics&.any?
+    arguments = %w[-- style --severity info --verify-no-changes --diagnostics] + enforced_diagnostics
+    steps[:dotnet_format_style] = -> { Bazel.execute('run', arguments, '//dotnet:format') }
+  end
 
-  arguments = %w[-- style --severity info --verify-no-changes --diagnostics] + enforced_diagnostics
-  Bazel.execute('run', arguments, '//dotnet:format')
+  SeleniumRake.aggregate_errors(**steps)
 end

rake_tasks/python.rake

@@ -172,9 +172,9 @@ end
 
 desc 'Run Python linters (ruff check --no-fix, mypy, docs)'
 task :lint do
-  puts '  Running ruff check (verify)...'
-  Bazel.execute('run', ['--', '--no-fix'], '//py:ruff-check')
-  puts '  Running mypy...'
-  Bazel.execute('run', [], '//py:mypy')
-  Rake::Task['py:docs_generate'].invoke
+  SeleniumRake.aggregate_errors(
+    ruff_check: -> { Bazel.execute('run', ['--', '--no-fix'], '//py:ruff-check') },
+    mypy: -> { Bazel.execute('run', [], '//py:mypy') },
+    python_docs: -> { Rake::Task['py:docs_generate'].invoke }
+  )
 end

rake_tasks/ruby.rake

@@ -163,11 +163,11 @@ end
 desc 'Run Ruby linters (rubocop, steep, docs)'
 task :lint do |_task, arguments|
   flag = arguments.to_a.include?('-A') ? '-A' : '-a'
-  puts '  Running rubocop...'
-  Bazel.execute('run', ['--', flag], '//rb:rubocop')
-  puts '  Running steep type checker...'
-  Bazel.execute('run', [], '//rb:steep')
-  Rake::Task['rb:docs_generate'].invoke
+  SeleniumRake.aggregate_errors(
+    rubocop: -> { Bazel.execute('run', ['--', flag], '//rb:rubocop') },
+    steep_type_checker: -> { Bazel.execute('run', [], '//rb:steep') },
+    ruby_docs: -> { Rake::Task['rb:docs_generate'].invoke }
+  )
 end
 
 desc 'Sync gem checksums from Gemfile.lock to MODULE.bazel (use force to re-download all)'