[dotnet] [build] Don't skip tests#17295
Merged
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom Apr 2, 2026
Merged
Conversation
Contributor
Review Summary by QodoRe-enable skipped dotnet tests in build configuration
WalkthroughsDescription• Remove dotnet test exclusions from skipped tests list • Re-enable NetworkInterceptionTests and FirefoxDriverTests • Allow previously skipped dotnet tests to run File Changes1. .skipped-tests
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s test-skip configuration to ensure several previously excluded .NET test targets are no longer skipped, allowing them to run again in CI/build workflows.
Changes:
- Removed skip-list entries for
NetworkInterceptionTestson Chrome/Edge in.NETcommon tests. - Removed the skip-list entry for
.NETFirefoxDriverTests.
Member
Author
|
Passes. |
AutomatedTester
pushed a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some tests from the skipped lists.
💥 What does this PR do?
This pull request updates the
.skipped-testsfile to remove several test exclusions, allowing these tests to run again. This suggests that the previously skipped tests are now expected to pass.