Initial Creation of the Selenium CLI Tool#17327
Initial Creation of the Selenium CLI Tool#17327AutomatedTester wants to merge 2 commits intotrunkfrom
Conversation
This creates a new binary called sel for easy use and reuses a lot of the selenium manager crate for downloading and installing things. This add the * Install command * Version Command The install will download via selenium manager and will add a JRE for the grid if one is not found. Tests are included.
bonigarcia
left a comment
There was a problem hiding this comment.
I think #17326 is a great idea. Thanks a lot, @AutomatedTester, for leading this effort.
About #17327, my main concern is duplication. This PR proposes using the Selenium Manager Rust core as the basis for two CLIs: selenium-manager and sel. But personally, I don't see a big benefit of having two separate CLIs.
As an idea. What if we rebrand "Selenium Manager" to "Selenium CLI" and make it the only CLI tool for the Selenium project?
This PR will become much simpler. We should only need to include the new module (jre.rs) in the new "Selenium CLI" and the required logic to use it. This will avoid all the duplicated code in both CLIs (e.g., lines 57 to 166 in sel.rs) or the setup and use of SM (lines 331 to 354 in sel.rs).
What do you think?
|
+1 for unified tool. SM could be just a command. selenium manager install --browser chromeAlso |
|
I think Selenium Manager doesn't convey the direction of where I think this tools should go. I am happy, like @nvborisenko suggests, to have this as selenium and we can move |
PR Implementation ChecklistDirection and Scope
Remove Duplicate CLI Surface
Keep and Integrate P0 Value in Existing CLI
Testing and Validation
PR Hygiene
Definition of Done
|
This adds the P0 tasks from this product brief in #17326
🔗 Related Issues
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes