fix(inference): exclude eagle from STP filter; skip quick filters on trends tab

Author: adibarra

packages/app/src/components/inference/InferenceContext.tsx

@@ -59,7 +59,12 @@ import { filterRunsByModel, getDisplayLabel } from '@/lib/utils';
 
 import { useChartData } from './hooks/useChartData';
 import { resolveComparisonEntries } from './utils/comparisonEntry';
-import type { DisaggMode, QuickFilters, SpecMode } from './utils/quickFilters';
+import {
+  EMPTY_QUICK_FILTERS,
+  type DisaggMode,
+  type QuickFilters,
+  type SpecMode,
+} from './utils/quickFilters';
 
 /** @internal Exported for test provider wrapping only. */
 export const InferenceContext = createContext<InferenceChartContextType | undefined>(undefined);
@@ -181,6 +186,10 @@ export function InferenceProvider({
     }),
     [quickFilterVendors, quickFilterFrameworks, quickFilterDisagg, quickFilterSpec],
   );
+  // The Historical Trends tab hides the quick-filter pills (hideGpuComparison), so
+  // don't silently narrow its chart with selections carried in via share links or
+  // the inference tab — there would be no pill to clear them.
+  const dataQuickFilters = activeTab === 'historical' ? EMPTY_QUICK_FILTERS : quickFilters;
   const { highContrast, setHighContrast, isLegendExpanded, setIsLegendExpanded } = useChartUIState({
     urlPrefix: 'i_',
   });
@@ -303,7 +312,7 @@ export function InferenceProvider({
     latestDate,
     compareGpuPair ?? null,
     asOfRunId,
-    quickFilters,
+    dataQuickFilters,
   );
 
   // For GPU comparison date picker — use shared availability data from global filters

packages/app/src/components/inference/utils/quickFilters.test.ts

@@ -152,6 +152,17 @@ describe('matchesQuickFilters', () => {
     expect(matchesQuickFilters(point({ hwKey: 'h100_vllm' }), stpFilter)).toBe(true);
   });
 
+  it('treats non-standard spec methods (e.g. eagle) as neither MTP nor STP', () => {
+    const eagle = point({ hwKey: 'h200_trt_eagle', spec_decoding: 'eagle' });
+    expect(matchesQuickFilters(eagle, filters({ spec: ['mtp'] }))).toBe(false);
+    expect(matchesQuickFilters(eagle, filters({ spec: ['stp'] }))).toBe(false);
+    // Excluded under either spec selection, but unconstrained when spec is empty.
+    expect(matchesQuickFilters(eagle, filters({ spec: ['mtp', 'stp'] }))).toBe(false);
+    expect(matchesQuickFilters(eagle, EMPTY_QUICK_FILTERS)).toBe(true);
+    // An eagle-only point contributes to neither spec pill.
+    expect(computeAvailableQuickFilters([eagle]).spec).toEqual([]);
+  });
+
   it('ANDs categories together', () => {
     const f = filters({ vendors: ['AMD'], disagg: ['disagg'], spec: ['stp'] });
     expect(

packages/app/src/components/inference/utils/quickFilters.ts

@@ -83,8 +83,9 @@ export function computeAvailableQuickFilters(
     if (fam) frameworks.add(fam);
     if (p.disagg) hasDisagg = true;
     else hasAgg = true;
-    if (pointIsMtp(p)) hasMtp = true;
-    else hasStp = true;
+    const specMode = pointSpecMode(p);
+    if (specMode === 'mtp') hasMtp = true;
+    else if (specMode === 'stp') hasStp = true;
   }
   const disagg: DisaggMode[] = [];
   if (hasAgg) disagg.push('agg');
@@ -117,6 +118,19 @@ function pointIsMtp(point: InferenceData): boolean {
   return point.spec_decoding === 'mtp' || String(point.hwKey).endsWith('_mtp');
 }
 
+/**
+ * Classify a point for the spec-decoding filter, or `null` when it is neither
+ * plain MTP nor standard decoding. STP means *standard* (no speculative method),
+ * which the DB marks `none` (and the hwKey carries no spec suffix). Other methods
+ * such as EAGLE are neither MTP nor STP, so they must not fall through to STP.
+ */
+function pointSpecMode(point: InferenceData): SpecMode | null {
+  if (pointIsMtp(point)) return 'mtp';
+  const s = point.spec_decoding;
+  if (s === 'none' || s === '' || s === undefined || s === null) return 'stp';
+  return null;
+}
+
 /** Whether a single data point satisfies every active quick-filter category. */
 export function matchesQuickFilters(point: InferenceData, f: QuickFilters): boolean {
   if (f.vendors.length > 0) {
@@ -132,8 +146,8 @@ export function matchesQuickFilters(point: InferenceData, f: QuickFilters): bool
     if (!f.disagg.includes(mode)) return false;
   }
   if (f.spec.length > 0) {
-    const mode: SpecMode = pointIsMtp(point) ? 'mtp' : 'stp';
-    if (!f.spec.includes(mode)) return false;
+    const mode = pointSpecMode(point);
+    if (!mode || !f.spec.includes(mode)) return false;
   }
   return true;
 }