Add collection and search filtering & sorting to skeleton template #9214
danielqiuuci.yml
on: pull_request
🔧 Node version sync
5s
⬣ ESLint
1m 21s
⬣ Prettier
27s
Typescript
2m 5s
⬣ E2E tests
5m 15s
⬣ E2E Customer Account tests
2m 32s
⬣ Unit tests
3m 43s
⬣ Validate Recipes
1m 27s
Matrix: test_scaffolding
Annotations
12 errors
|
Typescript
Process completed with exit code 2.
|
|
Typescript
skeleton#typecheck: command (/home/runner/work/hydrogen/hydrogen/templates/skeleton) /home/runner/setup-pnpm/node_modules/.bin/pnpm run typecheck exited (2)
|
|
Typescript
Type 'InputMaybe<number>' is not assignable to type 'number | undefined'.
|
|
⬣ Unit tests
Process completed with exit code 1.
|
|
src/commands/hydrogen/upgrade.test.ts > upgrade > fetchChangelog > successfully loads changelog when network is available:
packages/cli/src/commands/hydrogen/upgrade.test.ts#L426
AssertionError: expected undefined not to be undefined
❯ src/commands/hydrogen/upgrade.test.ts:426:45
|
|
src/commands/hydrogen/upgrade.test.ts > upgrade > fetchChangelog > fetches the latest changelog from the hydrogen repo:
packages/cli/src/commands/hydrogen/upgrade.test.ts#L378
AssertionError: expected { …(10) } to have property "devDependencies"
❯ src/commands/hydrogen/upgrade.test.ts:378:31
|
|
src/commands/hydrogen/init.test.ts > init > project validity > typechecks the project:
packages/cli/src/commands/hydrogen/init.test.ts#L116
AssertionError: promise rejected "Error: Command failed with exit code 2: n… { …(7) }" instead of resolving
❯ src/commands/hydrogen/init.test.ts:116:7
Caused by: Error: Command failed with exit code 2: npm run typecheck
> test-project-init-1775786535613-3olot8@2026.4.0 typecheck
> react-router typegen && tsc --noEmit
app/components/ProductFilters.tsx(72,51): error TS2322: Type 'InputMaybe<number>' is not assignable to type 'number | undefined'.
Type 'null' is not assignable to type 'number | undefined'.
❯ makeError ../../node_modules/.pnpm/execa@7.2.0/node_modules/execa/lib/error.js:60:11
❯ handlePromise ../../node_modules/.pnpm/execa@7.2.0/node_modules/execa/index.js:124:26
❯ Module.exec ../../node_modules/.pnpm/@Shopify+cli-kit@3.80.4_@types+react@18.3.28/node_modules/@shopify/cli-kit/src/public/node/system.ts:95:5
❯ src/commands/hydrogen/init.test.ts:114:7
|
|
⬣ Unit tests
Type 'InputMaybe<number>' is not assignable to type 'number | undefined'.
|
|
⬣ Unit tests
@shopify/cli-hydrogen#test: command (/home/runner/work/hydrogen/hydrogen/packages/cli) /home/runner/setup-pnpm/node_modules/.bin/pnpm run test exited (1)
|
|
⬣ Scaffolding tests (windows-latest / npm)
Canceling since a higher priority waiting request for ci-scaffolding-windows-latest-npm-refs/pull/3618/merge exists
|
|
⬣ E2E tests
Canceling since a higher priority waiting request for ci-e2e-refs/pull/3618/merge exists
|
|
⬣ E2E tests
The operation was canceled.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
playwright-report-customer-account
|
225 KB |
sha256:c89efd7136021a0b598fca0f904ad3244d7e1b62c05d06b7e9518bfb529180a2
|
|