fix(windGround): emit ground direction to environment.wind.directionGround#245
Open
msallin wants to merge 1 commit into
Open
fix(windGround): emit ground direction to environment.wind.directionGround#245msallin wants to merge 1 commit into
msallin wants to merge 1 commit into
Conversation
The calculator uses SOG (speed over ground) to compute ground-frame wind, but was writing its direction output to environment.wind.directionTrue, which the SK spec reserves for the water-frame true wind direction. This overwrote any value produced by the water-frame true wind calculator when both were enabled. Rename the output path to environment.wind.directionGround and flip the test lock.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment.wind.directionTruetoenvironment.wind.directionGround.Context
Reported in #186. The main
windGroundcalc derives wind direction in the ground frame (uses SOG) but was writing toenvironment.wind.directionTrue, which per the SK spec is the water-frame true wind direction. Tracked in #244.Test plan
// BUG:lock intest/windGround.tsdirectionGroundnpm test— 300 pass, 1 pre-existing moon failure unrelated to this change