[thread-direct] remove legacy peer-to-peer (P2P) implementation

The P2P feature was a provisional mechanism for peer-to-peer link
establishment via MLE. It is superseded by Thread Direct, which
implements the same use case through a MAC-layer handshake defined
in the Thread specification.

This commit removes all P2P code and configuration.

- `include/openthread/provisional/link.h` is retained; it defines the
  shared wakeup types (`otWakeupId`, `otWakeupType`, `otWakeupRequest`)
  used by the MAC layer independently of P2P. This will be cleaned up
  further later.
- `otThreadWakeup` returns `OT_ERROR_NOT_IMPLEMENTED` in this
  intermediate state pending the scheduler moving off Mle.

Author: suveshpratapa

doc/ot_api_doc.h

@@ -183,7 +183,6 @@
  * @{
  *
  * @defgroup api-provisional-link        Link
- * @defgroup api-provisional-p2p         Peer-to-Peer
  *
  * @}
  *

doc/ot_config_doc.h

@@ -73,7 +73,6 @@
  * @defgroup config-nat64                    NAT64
  * @defgroup config-netdata-publisher        Network Data Publisher
  * @defgroup config-network-diagnostic       Network Diagnostics
- * @defgroup config-p2p                      Peer-to-Peer
  * @defgroup config-parent-search            Parent Search
  * @defgroup config-ping-sender              Ping Sender
  * @defgroup config-platform                 Platform Specific Services

etc/cmake/options.cmake

@@ -242,7 +242,7 @@ ot_option(OT_NETDIAG_CLIENT OPENTHREAD_CONFIG_TMF_NETDIAG_CLIENT_ENABLE "Network
 ot_option(OT_NETDIAG_VENDOR_INFO OPENTHREAD_CONFIG_NET_DIAG_VENDOR_INFO_SET_API_ENABLE "Allow setting vendor info at runtime")
 ot_option(OT_OPERATIONAL_DATASET_AUTO_INIT OPENTHREAD_CONFIG_OPERATIONAL_DATASET_AUTO_INIT "operational dataset auto init")
 ot_option(OT_OTNS OPENTHREAD_CONFIG_OTNS_ENABLE "OTNS")
-ot_option(OT_P2P OPENTHREAD_CONFIG_P2P_ENABLE "peer to peer")
+
 ot_option(OT_PING_SENDER OPENTHREAD_CONFIG_PING_SENDER_ENABLE "ping sender" ${OT_APP_CLI})
 ot_option(OT_PLATFORM_BOOTLOADER_MODE OPENTHREAD_CONFIG_PLATFORM_BOOTLOADER_MODE_ENABLE "platform bootloader mode")
 ot_option(OT_PLATFORM_DNSSD OPENTHREAD_CONFIG_PLATFORM_DNSSD_ENABLE "platform dnssd")

include/openthread/BUILD.gn

@@ -118,7 +118,6 @@ source_set("openthread") {
     "platform/trel.h",
     "platform/udp.h",
     "provisional/link.h",
-    "provisional/p2p.h",
     "radio_stats.h",
     "random_crypto.h",
     "random_noncrypto.h",

include/openthread/instance.h

@@ -52,7 +52,7 @@ extern "C" {
  *
  * @note This number versions both OpenThread platform and user APIs.
  */
-#define OPENTHREAD_API_VERSION (605)
+#define OPENTHREAD_API_VERSION (606)
 
 /**
  * @addtogroup api-instance

include/openthread/provisional/p2p.h

@@ -137,7 +137,6 @@ build_simulation()
         options+=("-DOT_LINK_METRICS_INITIATOR=ON")
         options+=("-DOT_LINK_METRICS_SUBJECT=ON")
         options+=("-DOT_LINK_METRICS_MANAGER=ON")
-        options+=("-DOT_P2P=ON")
         options+=("-DOT_WAKEUP_COORDINATOR=ON")
         options+=("-DOT_WAKEUP_END_DEVICE=ON")
     fi
@@ -187,7 +186,6 @@ build_posix()
         options+=("-DOT_LINK_METRICS_INITIATOR=ON")
         options+=("-DOT_LINK_METRICS_SUBJECT=ON")
         options+=("-DOT_LINK_METRICS_MANAGER=ON")
-        options+=("-DOT_P2P=ON")
         options+=("-DOT_WAKEUP_COORDINATOR=ON")
         options+=("-DOT_WAKEUP_END_DEVICE=ON")
     fi

script/test

@@ -89,7 +89,6 @@ Done
 - [networkname](#networkname)
 - [networktime](#networktime)
 - [nexthop](#nexthop)
-- [p2p](#p2p-link-extaddr-extaddr)
 - [panid](#panid)
 - [parent](#parent)
 - [parentpriority](#parentpriority)
@@ -3296,28 +3295,6 @@ nexthop 0x8001
 Done
 ```
 
-### p2p link extaddr \<extaddr\>
-
-Wakes up the peer identified by the extended address and establishes a peer-to-peer link with the peer.
-
-`OPENTHREAD_CONFIG_P2P_ENABLE` and `OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE` are required.
-
-```bash
-> p2p link extaddr dead00beef00cafe
-Done
-```
-
-### p2p unlink \<extaddress\>
-
-Tears down the P2P link identified by the extended address.
-
-`OPENTHREAD_CONFIG_P2P_ENABLE` is required.
-
-```bash
-> p2p unlink dead00beef00cafe
-Done
-```
-
 ### panid
 
 Get the IEEE 802.15.4 PAN ID value.

src/cli/README.md

@@ -8213,83 +8213,6 @@ template <> otError Interpreter::Process<Cmd("verhoeff")>(Arg aArgs[])
 
 #endif // OPENTHREAD_CONFIG_VERHOEFF_CHECKSUM_ENABLE
 
-#if OPENTHREAD_CONFIG_P2P_ENABLE
-template <> otError Interpreter::Process<Cmd("p2p")>(Arg aArgs[])
-{
-    otError error = OT_ERROR_NONE;
-
-    if (aArgs[0] == "unlink")
-    {
-        otExtAddress extAddress;
-
-        /**
-         * @cli p2p unlink
-         * @code
-         * p2p unlink dead00beef00cafe
-         * Done
-         * @endcode
-         * @cparam p2p unlink @ca{extended-address}
-         * @par
-         * `OPENTHREAD_CONFIG_P2P_ENABLE` is required.
-         * @par
-         * Tears down the P2P link identified by the extended address.
-         */
-        SuccessOrExit(error = aArgs[1].ParseAsHexString(extAddress.m8));
-        SuccessOrExit(error = otP2pUnlink(GetInstancePtr(), &extAddress, HandleP2pUnlinkDone, this));
-        error = OT_ERROR_PENDING;
-    }
-#if OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE
-    else if (aArgs[0] == "link")
-    {
-        otP2pRequest p2pRequest;
-
-        /**
-         * @cli p2p link
-         * @code
-         * p2p link extaddr dead00beef00cafe
-         * Done
-         * @endcode
-         * @cparam p2p link extaddr @ca{extended-address}
-         * @par
-         * `OPENTHREAD_CONFIG_P2P_ENABLE` and `OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE` are required.
-         * @par
-         * Wakes up the Wake-up Listener identified by the extended address and establishes a peer-to-peer link with the
-         * peer.
-         */
-        if (aArgs[1] == "extaddr")
-        {
-            SuccessOrExit(error = aArgs[2].ParseAsHexString(p2pRequest.mWakeupRequest.mShared.mExtAddress.m8));
-            p2pRequest.mWakeupRequest.mType = OT_WAKEUP_TYPE_EXT_ADDRESS;
-        }
-        else
-        {
-            ExitNow(error = OT_ERROR_INVALID_ARGS);
-        }
-
-        SuccessOrExit(error = otP2pWakeupAndLink(GetInstancePtr(), &p2pRequest, HandleP2pLinkDone, this));
-        error = OT_ERROR_PENDING;
-    }
-#endif
-    else
-    {
-        error = OT_ERROR_INVALID_ARGS;
-    }
-
-exit:
-    return error;
-}
-
-#if OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE
-void Interpreter::HandleP2pLinkDone(void *aContext) { static_cast<Interpreter *>(aContext)->HandleP2pLinkDone(); }
-
-void Interpreter::HandleP2pLinkDone(void) { OutputResult(OT_ERROR_NONE); }
-#endif
-
-void Interpreter::HandleP2pUnlinkDone(void *aContext) { static_cast<Interpreter *>(aContext)->HandleP2pUnlinkDone(); }
-
-void Interpreter::HandleP2pUnlinkDone(void) { OutputResult(OT_ERROR_NONE); }
-#endif //  OPENTHREAD_CONFIG_P2P_ENABLE
-
 #if OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE || OPENTHREAD_CONFIG_WAKEUP_END_DEVICE_ENABLE
 template <> otError Interpreter::Process<Cmd("wakeup")>(Arg aArgs[])
 {
@@ -8681,9 +8604,6 @@ otError Interpreter::ProcessCommand(Arg aArgs[])
 #endif
 #if OPENTHREAD_FTD
         CmdEntry("nexthop"),
-#endif
-#if OPENTHREAD_CONFIG_P2P_ENABLE && OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE
-        CmdEntry("p2p"),
 #endif
         CmdEntry("panid"),
         CmdEntry("parent"),

src/cli/cli.cpp

@@ -364,16 +364,6 @@ class Interpreter : public otCliInterpreter, public OutputImplementer, public Ut
     static void HandleIp6Receive(otMessage *aMessage, void *aContext);
 #endif
 
-#if OPENTHREAD_CONFIG_P2P_ENABLE
-#if OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE
-    static void HandleP2pLinkDone(void *aContext);
-    void        HandleP2pLinkDone(void);
-#endif
-
-    static void HandleP2pUnlinkDone(void *aContext);
-    void        HandleP2pUnlinkDone(void);
-#endif
-
 #if OPENTHREAD_CONFIG_WAKEUP_COORDINATOR_ENABLE
     static void HandleWakeupResult(otError aError, void *aContext);
     void        HandleWakeupResult(otError aError);