[crypto] update mbedtls psa crypto context structs

Author: silabs-HarshaK

include/openthread/platform/crypto.h

@@ -123,6 +123,9 @@ typedef struct otCryptoKey
  * @struct otCryptoContext
  *
  * Stores the context object for platform APIs.
+ *
+ * If `OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS` is enabled, platform allocates and populates this.
+ * Otherwise it is input.
  */
 typedef struct otCryptoContext
 {
@@ -319,12 +322,15 @@ void otPlatCryptoFree(void *aPtr);
 /**
  * Initialize the HMAC operation.
  *
- * @param[in]  aContext          Context for HMAC operation.
+ * @param[in,out]  aContext      Context for HMAC operation.
  *
  * @retval OT_ERROR_NONE          Successfully initialized HMAC operation.
  * @retval OT_ERROR_FAILED        Failed to initialize HMAC operation.
  * @retval OT_ERROR_INVALID_ARGS  @p aContext was NULL
  *
+ * @note If `OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS` is enabled, @p aContext is output and platform MUST
+ *       populate it. Otherwise @p aContext is input.
+ *
  * @note The platform driver shall point the context to the correct object such as psa_mac_operation_t or
  *       mbedtls_md_context_t.
  */
@@ -382,13 +388,16 @@ otError otPlatCryptoHmacSha256Finish(otCryptoContext *aContext, uint8_t *aBuf, s
 /**
  * Initialise the AES operation.
  *
- * @param[in]  aContext           Context for AES operation.
+ * @param[in,out]  aContext       Context for AES operation.
  *
  * @retval OT_ERROR_NONE          Successfully Initialised AES operation.
  * @retval OT_ERROR_FAILED        Failed to Initialise AES operation.
  * @retval OT_ERROR_INVALID_ARGS  @p aContext was NULL
  * @retval OT_ERROR_NO_BUFS       Cannot allocate the context.
  *
+ * @note If `OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS` is enabled, @p aContext is output and platform MUST
+ *       populate it. Otherwise @p aContext is input.
+ *
  * @note The platform driver shall point the context to the correct object such as psa_key_id
  *       or mbedtls_aes_context_t.
  */
@@ -433,12 +442,15 @@ otError otPlatCryptoAesFree(otCryptoContext *aContext);
 /**
  * Initialise the HKDF context.
  *
- * @param[in]  aContext           Context for HKDF operation.
+ * @param[in,out]  aContext       Context for HKDF operation.
  *
  * @retval OT_ERROR_NONE          Successfully Initialised AES operation.
  * @retval OT_ERROR_FAILED        Failed to Initialise AES operation.
  * @retval OT_ERROR_INVALID_ARGS  @p aContext was NULL
  *
+ * @note If `OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS` is enabled, @p aContext is output and platform MUST
+ *       populate it. Otherwise @p aContext is input.
+ *
  * @note The platform driver shall point the context to the correct object such as psa_key_derivation_operation_t
  *       or HmacSha256::Hash
  */
@@ -493,12 +505,14 @@ otError otPlatCryptoHkdfDeinit(otCryptoContext *aContext);
 /**
  * Initialise the SHA-256 operation.
  *
- * @param[in]  aContext           Context for SHA-256 operation.
+ * @param[in,out]  aContext       Context for SHA-256 operation.
  *
  * @retval OT_ERROR_NONE          Successfully initialised SHA-256 operation.
  * @retval OT_ERROR_FAILED        Failed to initialise SHA-256 operation.
  * @retval OT_ERROR_INVALID_ARGS  @p aContext was NULL
  *
+ * @note If `OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS` is enabled, @p aContext is output and platform MUST
+ *       populate it. Otherwise @p aContext is input.
  *
  * @note The platform driver shall point the context to the correct object such as psa_hash_operation_t
  *       or mbedtls_sha256_context.

src/core/config/platform.h

@@ -177,6 +177,15 @@
 #define OPENTHREAD_CONFIG_PLATFORM_POWER_CALIBRATION_ENABLE 0
 #endif
 
+/**
+ * @def OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
+ *
+ * Define to 1 to enable platform allocation of crypto contexts.
+ */
+#ifndef OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
+#define OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS 0
+#endif
+
 #if OPENTHREAD_CONFIG_PLATFORM_RADIO_PROPRIETARY_SUPPORT
 #if (!defined(OPENTHREAD_CONFIG_PLATFORM_RADIO_PROPRIETARY_CHANNEL_PAGE) || \
      !defined(OPENTHREAD_CONFIG_PLATFORM_RADIO_PROPRIETARY_CHANNEL_MIN) ||  \

src/core/crypto/aes_ecb.cpp

@@ -40,8 +40,13 @@ namespace Crypto {
 
 AesEcb::AesEcb(void)
 {
+#if OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
+    mContext.mContext     = nullptr;
+    mContext.mContextSize = 0;
+#else
     mContext.mContext     = mContextStorage;
     mContext.mContextSize = sizeof(mContextStorage);
+#endif
     SuccessOrAssert(otPlatCryptoAesInit(&mContext));
 }
 

src/core/crypto/aes_ecb.hpp

@@ -86,7 +86,9 @@ class AesEcb
 
 private:
     otCryptoContext mContext;
+#if !OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
     OT_DEFINE_ALIGNED_VAR(mContextStorage, kAesContextSize, uint64_t);
+#endif
 };
 
 /**

src/core/crypto/hkdf_sha256.cpp

@@ -44,8 +44,13 @@ namespace Crypto {
 
 HkdfSha256::HkdfSha256(void)
 {
+#if OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
+    mContext.mContext     = nullptr;
+    mContext.mContextSize = 0;
+#else
     mContext.mContext     = mContextStorage;
     mContext.mContextSize = sizeof(mContextStorage);
+#endif
     SuccessOrAssert(otPlatCryptoHkdfInit(&mContext));
 }
 

src/core/crypto/hkdf_sha256.hpp

@@ -94,7 +94,9 @@ class HkdfSha256
 
 private:
     otCryptoContext mContext;
+#if !OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
     OT_DEFINE_ALIGNED_VAR(mContextStorage, kHkdfContextSize, uint64_t);
+#endif
 };
 
 /**

src/core/crypto/hmac_sha256.cpp

@@ -41,8 +41,13 @@ namespace Crypto {
 
 HmacSha256::HmacSha256(void)
 {
+#if OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
+    mContext.mContext     = nullptr;
+    mContext.mContextSize = 0;
+#else
     mContext.mContext     = mContextStorage;
     mContext.mContextSize = sizeof(mContextStorage);
+#endif
 
     SuccessOrAssert(otPlatCryptoHmacSha256Init(&mContext));
 }

src/core/crypto/hmac_sha256.hpp

@@ -124,7 +124,9 @@ class HmacSha256
 
 private:
     otCryptoContext mContext;
+#if !OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
     OT_DEFINE_ALIGNED_VAR(mContextStorage, kHmacSha256ContextSize, uint64_t);
+#endif
 };
 
 /**

src/core/crypto/sha256.cpp

@@ -42,8 +42,14 @@ namespace Crypto {
 
 Sha256::Sha256(void)
 {
+#if OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
+    mContext.mContext     = nullptr;
+    mContext.mContextSize = 0;
+#else
     mContext.mContext     = mContextStorage;
     mContext.mContextSize = sizeof(mContextStorage);
+#endif
+
     SuccessOrAssert(otPlatCryptoSha256Init(&mContext));
 }
 

src/core/crypto/sha256.hpp

@@ -136,7 +136,9 @@ class Sha256
 
 private:
     otCryptoContext mContext;
+#if !OPENTHREAD_CONFIG_PLATFORM_ALLOCS_CRYPTO_CONTEXTS
     OT_DEFINE_ALIGNED_VAR(mContextStorage, kSha256ContextSize, uint64_t);
+#endif
 };
 
 /**