You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(plan): require negative tests to assert the failure reason
The Task 1 review caught a weak assertion this plan mandated verbatim:
unknown_fields_are_rejected checked only is_err(), which passes when an
unrelated error fires. Fix the offending snippet and lift the rule into
Global Constraints so the remaining tasks inherit the bar
open_connector/config.rs:607-619 already sets. Also record that cargo is
not on this machine's default PATH.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
-**Failure fuse:** on a failed attempt the TTL re-arms to `clamp(ttl_seconds / 4, 30, 300)` seconds — bounded above zero even under `ttl_seconds: 0`.
30
30
-**Every commit compiles and its tests pass** with `--features rss` and without (the workspace must stay green when the feature is off). Run `cargo fmt --all` before every commit (CI gates on it).
31
+
-**Negative tests assert the reason, not just the failure.** Every test that expects an error asserts on a substring identifying *that* error (the offending field name, the failing stage, the blocked range). A bare `assert!(result.is_err())` passes when an unrelated error fires and is treated as a test that asserts nothing — the bar `open_connector/config.rs:607-619` sets.
32
+
-**Toolchain note (this machine):**`cargo` is not on the default PATH. Prefix every invocation with `export PATH="/opt/homebrew/opt/rustup/bin:$PATH"`.
31
33
32
34
### Decisions made by this plan (approved with the plan; deviations from spec flagged)
0 commit comments