Skip to content

Commit bb51347

Browse files
authored
Merge pull request #17 from SkardiLabs/change_source_crates_name
Refactored sources directory
2 parents 1e30a2a + 2b4da89 commit bb51347

28 files changed

Lines changed: 35 additions & 30 deletions

Cargo.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ license = "Apache-2.0"
1010
[workspace]
1111
members = [ "crates/cli",
1212
"crates/engine",
13-
"crates/source",
13+
"crates/sources",
1414
"crates/model",
1515
"crates/pipeline",
1616
"crates/server"]

crates/cli/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ object_store = { workspace = true, features = ["aws", "gcp", "azure", "http"] }
2626
serde = { workspace = true }
2727
serde_json = { workspace = true }
2828
serde_yaml = { workspace = true }
29-
source = { path = "../source" }
29+
sources = { path = "../sources" }
3030
tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }
3131
url = { workspace = true }
3232

crates/cli/src/main.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ use object_store::azure::MicrosoftAzureBuilder;
1616
use object_store::gcp::GoogleCloudStorageBuilder;
1717
use object_store::http::HttpBuilder;
1818
use serde::Deserialize;
19-
use source::lance::knn_table_function::register_lance_knn_udtf;
20-
use source::providers::{
19+
use sources::providers::lance::knn_table_function::register_lance_knn_udtf;
20+
use sources::providers::{
2121
iceberg::register_iceberg_table, lance::register_lance_table, mongo::register_mongo_tables,
2222
mysql::register_mysql_tables, sqlite::register_sqlite_tables,
2323
sqlx::postgres::register_postgres_tables,
@@ -254,7 +254,7 @@ impl UrlTableFactory for SkardiUrlTableFactory {
254254

255255
if !table_name.is_empty() {
256256
let provider =
257-
source::providers::sqlite::create_sqlite_table_provider(db_path, table_name)
257+
sources::providers::sqlite::create_sqlite_table_provider(db_path, table_name)
258258
.await
259259
.map_err(|e| {
260260
datafusion::error::DataFusionError::Execution(e.to_string())

crates/model/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ tokio = {workspace = true, features = ["macros", "rt-multi-thread", "sync"]}
2020
tracing = { workspace = true }
2121

2222
[dev-dependencies]
23-
source = { path = "../source" }
23+
sources = { path = "../sources" }
2424

2525
[lints]
2626
workspace = true

crates/model/examples/ncf_demo.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ async fn main() -> Result<()> {
1111
let mut ctx = SessionContext::new();
1212

1313
// 2. Register the movie_embeddings Lance dataset as a table
14-
source::providers::lance::register_lance_table(
14+
sources::providers::lance::register_lance_table(
1515
&mut ctx,
1616
"movie_embeddings",
1717
"data/movie_embeddings.lance",

crates/server/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ serde_json = { workspace = true }
2323
serde_yaml = { workspace = true }
2424
skardi-engine = { path = "../engine" }
2525
pipeline = { path = "../pipeline" }
26-
source = { path = "../source" }
26+
sources = { path = "../sources" }
2727
model = { path = "../model" }
2828
anyhow = "1.0"
2929
thiserror = "1.0"

crates/server/src/config.rs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use std::sync::Arc;
1111
use thiserror::Error;
1212

1313
use crate::remote_storage::{RemoteStorage, S3Storage};
14-
pub use source::AccessMode;
14+
pub use sources::AccessMode;
1515

1616
/// CLI arguments for the Skardi server
1717
#[derive(Parser, Debug)]
@@ -538,15 +538,15 @@ fn validate_pipeline_sql(
538538
sql: &str,
539539
data_sources: &[DataSource],
540540
) -> Result<()> {
541-
use source::sql_validator::{validate_sql, SqlValidatorConfig};
541+
use sources::sql_validator::{validate_sql, SqlValidatorConfig};
542542

543543
// Build validator config from data sources
544544
let mut validator_config = SqlValidatorConfig::new();
545545
for ds in data_sources {
546546
let mode = if ds.access_mode.is_read_write() {
547-
source::sql_validator::AccessMode::ReadWrite
547+
sources::sql_validator::AccessMode::ReadWrite
548548
} else {
549-
source::sql_validator::AccessMode::ReadOnly
549+
sources::sql_validator::AccessMode::ReadOnly
550550
};
551551
validator_config = validator_config.with_table(&ds.name, mode);
552552
}
@@ -742,7 +742,7 @@ async fn register_data_source(
742742
);
743743

744744
// Register PostgreSQL table using the sqlx-based provider
745-
source::providers::sqlx::postgres::register_postgres_tables(
745+
sources::providers::sqlx::postgres::register_postgres_tables(
746746
session_ctx,
747747
&source.name,
748748
connection_string,
@@ -782,7 +782,7 @@ async fn register_data_source(
782782
source.options
783783
);
784784

785-
source::providers::mysql::register_mysql_tables(
785+
sources::providers::mysql::register_mysql_tables(
786786
session_ctx,
787787
&source.name,
788788
connection_string,
@@ -815,7 +815,7 @@ async fn register_data_source(
815815
error: "Invalid SQLite database path".to_string(),
816816
})?;
817817

818-
source::providers::sqlite::register_sqlite_tables(
818+
sources::providers::sqlite::register_sqlite_tables(
819819
session_ctx,
820820
&source.name,
821821
db_path,
@@ -847,7 +847,7 @@ async fn register_data_source(
847847
error: "Invalid warehouse path".to_string(),
848848
})?;
849849

850-
source::providers::iceberg::register_iceberg_table(
850+
sources::providers::iceberg::register_iceberg_table(
851851
session_ctx,
852852
&source.name,
853853
warehouse_path,
@@ -878,7 +878,7 @@ async fn register_data_source(
878878
source.options
879879
);
880880

881-
source::providers::mongo::register_mongo_tables(
881+
sources::providers::mongo::register_mongo_tables(
882882
session_ctx,
883883
&source.name,
884884
connection_string,
@@ -909,7 +909,7 @@ async fn register_data_source(
909909
source.options
910910
);
911911

912-
source::redis::datasource::register_redis_tables(
912+
sources::providers::redis::datasource::register_redis_tables(
913913
session_ctx,
914914
&source.name,
915915
connection_string,
@@ -934,7 +934,7 @@ async fn register_data_source(
934934
let dataset_registry = optimizer_registry.map(|reg| reg.lance_datasets());
935935

936936
// Register Lance dataset using the providers module
937-
source::providers::lance::register_lance_table(
937+
sources::providers::lance::register_lance_table(
938938
session_ctx,
939939
&source.name,
940940
source.path.to_str().unwrap(),

crates/server/src/handlers.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ mod tests {
666666
use datafusion::prelude::SessionContext;
667667
use pipeline::pipeline::{Pipeline, StandardPipeline};
668668
use skardi_engine::datafusion::DataFusionEngine;
669-
use source::AccessMode;
669+
use sources::AccessMode;
670670
use std::fs;
671671
use std::path::PathBuf;
672672
use std::sync::{Arc, RwLock};

crates/server/src/optimizer_registry.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ impl OptimizerRegistry {
9595
tracing::info!("Registering Lance table functions");
9696

9797
// Register lance_knn table function
98-
source::lance::knn_table_function::register_lance_knn_udtf(ctx, self.lance_datasets());
98+
sources::providers::lance::knn_table_function::register_lance_knn_udtf(
99+
ctx,
100+
self.lance_datasets(),
101+
);
99102

100103
tracing::info!("✓ Registered lance_knn table function");
101104
Ok(())

0 commit comments

Comments
 (0)