Parse bigints in the correct culture (#550)

Author: Smaug123

ConsumePlugin/GeneratedJson.fs

@@ -280,7 +280,12 @@ module ToGetExtensionMethodJsonParseExtension =
                             sprintf "Required key '%s' not found on JSON object" ("whiskey")
                         )
                     )
-                | Some node -> System.Numerics.BigInteger.Parse (node.ToJsonString ())
+                | Some node ->
+                    System.Numerics.BigInteger.Parse (
+                        node.ToJsonString (),
+                        System.Globalization.NumberStyles.Float,
+                        System.Globalization.CultureInfo.InvariantCulture
+                    )
 
             let arg_19 =
                 match node.["victor"] |> Option.ofObj with
@@ -505,3 +510,28 @@ module ToGetExtensionMethodJsonParseExtension =
                 Victor = arg_19
                 Whiskey = arg_20
             }
+namespace ConsumePlugin
+
+/// Module containing JSON parsing methods for the ContainsABigInt type
+[<RequireQualifiedAccess ; CompilationRepresentation(CompilationRepresentationFlags.ModuleSuffix)>]
+module ContainsABigInt =
+    /// Parse from a JSON node.
+    let jsonParse (node : System.Text.Json.Nodes.JsonNode) : ContainsABigInt =
+        let arg_0 =
+            match node.["bigNum"] |> Option.ofObj with
+            | None ->
+                raise (
+                    System.Collections.Generic.KeyNotFoundException (
+                        sprintf "Required key '%s' not found on JSON object" ("bigNum")
+                    )
+                )
+            | Some node ->
+                System.Numerics.BigInteger.Parse (
+                    node.ToJsonString (),
+                    System.Globalization.NumberStyles.Float,
+                    System.Globalization.CultureInfo.InvariantCulture
+                )
+
+        {
+            BigNum = arg_0
+        }

ConsumePlugin/JsonRecord.fs

@@ -82,3 +82,9 @@ type ToGetExtensionMethod =
 [<RequireQualifiedAccess>]
 module ToGetExtensionMethod =
     let thisModuleWouldClash = 3
+
+[<WoofWare.Myriad.Plugins.JsonParse>]
+type ContainsABigInt =
+    {
+        BigNum : bigint
+    }

WoofWare.Myriad.Plugins.Test/TestJsonParse/TestJsonParse.fs

@@ -2,6 +2,7 @@ namespace WoofWare.Myriad.Plugins.Test
 
 open System
 open System.Collections.Generic
+open System.Globalization
 open System.Text.Json.Nodes
 open ConsumePlugin
 open NUnit.Framework
@@ -118,3 +119,21 @@ module TestJsonParse =
         |> JsonNode.Parse
         |> SomeEnum.jsonParse
         |> shouldEqual expected
+
+    [<Test>]
+    [<NonParallelizable>]
+    let ``Bigints are parsed in the invariant culture`` () =
+        let currentCulture = CultureInfo.CurrentCulture
+        let desiredCulture = CultureInfo.CreateSpecificCulture "for-test"
+        desiredCulture.NumberFormat.NegativeSign <- "!"
+
+        CultureInfo.CurrentCulture <- desiredCulture
+
+        try
+            """{"bigNum": -3}"""
+            |> JsonNode.Parse
+            |> ContainsABigInt.jsonParse
+            |> _.BigNum
+            |> shouldEqual (bigint -3)
+        finally
+            CultureInfo.CurrentCulture <- currentCulture

WoofWare.Myriad.Plugins/JsonParseGenerator.fs

@@ -455,10 +455,16 @@ module internal JsonParseGenerator =
                 )
                 |> SynExpr.pipeThroughFunction (SynExpr.createLongIdent [ "Map" ; "ofSeq" ])
         | BigInt ->
-            node
-            |> SynExpr.callMethod "ToJsonString"
-            |> SynExpr.paren
-            |> SynExpr.applyFunction (SynExpr.createLongIdent [ "System" ; "Numerics" ; "BigInteger" ; "Parse" ])
+            SynExpr.createLongIdent [ "System" ; "Numerics" ; "BigInteger" ; "Parse" ]
+            |> SynExpr.applyTo (
+                SynExpr.tuple
+                    [
+                        node |> SynExpr.callMethod "ToJsonString"
+                        SynExpr.createLongIdent [ "System" ; "Globalization" ; "NumberStyles" ; "Float" ]
+                        SynExpr.createLongIdent [ "System" ; "Globalization" ; "CultureInfo" ; "InvariantCulture" ]
+                    ]
+            )
+
         | Measure (_measure, primType) ->
             parseNumberType options propertyName node primType
             |> SynExpr.pipeThroughFunction (Measure.getLanguagePrimitivesMeasure primType)