ff-* libs in dpo-voyager repository

[carschno]

I noticed that the dpo-voyager repository contains the ff-* libraries from framefactory in its libs folder. Looking at ff-core, this seems to be an exact copy of the original repository.

What is the purpose of having copies in the repository instead of declaring those libraries as dependencies through the npm package manager?

For context: I also wonder about the best approach of adding functionality to the dpo-voyager. Is adapting the local ff-* libraries in the dpo-voyager repository "allowed", or should changes really be limited to the files in source/client?

[gjcope]

Hi @carschno ,

These dependencies were forked some time ago for maintenance/update purposes. ff-core (and I believe all of the others) have local commits and differ from the original repository in one way or another. At one point these moved from module dependencies to library includes just to improve management of the project.

Modifying the local ff-* libraries is definitely allowed, especially when appropriate for supporting higher level functionality. A good example of this is all the work done in lights by @sdumetz to support expanded light types and light helper widgets.