Skip to content

"Share" embed code uses the current page as the source. #466

@ericpugh

Description

@ericpugh

When embedding a model on a page using the <voyager-explorer /> tag, the "embed code" the user can copy from the "share" links provides and iframe that uses the URL of the current page the 3D model is embedded on as the iframe source.

Here's an example page with such an embed: https://americanart.si.edu/artwork/model-of-the-greek-slave-20060

Clicking the share icon provides the following:

<iframe name="Smithsonian Voyager" src="https://americanart.si.edu/artwork/model-of-the-greek-slave-20060" width="800" height="450" allow="xr; xr-spatial-tracking; fullscreen"></iframe>

Since the "src" attribute is https://americanart.si.edu/, if a user were to actually use that code on some other page it wouldn't work as intended. (They'd be getting the entire page, instead of just the 3D model).

I'm guessing the "src" attribute should always point to the resource on https://3d-api.si.edu/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions