controls="False" doesn't survive calls to reloadDocument

[sdumetz]

When reloading document (manually or triggered by an attribute change), pointerEnabled is forced to true with <voyager-explorer controls="False" >.

I don't think this is intended behavior?

[gjcope]

Hi @sdumetz - do you have steps to reproduce? This does not sound like intended behavior, but I'm not seeing a document reload triggered by an attribute change having any effect on pointerEnabled (navigation property).

[gjcope]

@sdumetz Pinging on this - any clues on how to reproduce? Thanks!

[sdumetz]

I got this when initializing voyager with no document, like so:

<voyager-explorer
      dracoRoot="/dist/client/js/draco/"
      resourceRoot="/dist/client/"
      uiMode="none"
      bgStyle="solid"
      bgColor="black"
      controls="False"
      reader="False"
    ></voyager-explorer>

then when I load a scene by changing the root or document attributes, navigation is no longer disabled.

Interestingly (and what I failed to spot initially), if voyager is started with valid document/root attributes, the problem doesn't happen. I am not sure why.

[gjcope]

Got it, thanks! I was missing the no initial document piece.

[gjcope]

The issue should be addressed in 9df3bd8

There were two problems at play.

1. SceneView was relying on scene specific component callbacks that only get set on the first document load. This should be addressed. I believe all cases have been covered.
2. The component-level configuration attributes are set in a post-document load callback. So when no document is loaded, they don't get set. I've never liked how this works, as it can result in a 'flicker' with some attributes like background color, but addresses the issue that they should override corresponding scene-defined attributes. This has not been addressed but suggestions are welcome!