Skip to content

Commit 0d6566c

Browse files
committed
fix(boringssl-ci): inline NASM via choco in existing Windows toolchain steps
BoringSSL's CMakeLists.txt unconditionally calls enable_language(ASM_NASM) on Windows regardless of target arch. Linux/macOS runners ship nasm by default; Windows runners do not, so cmake configure dies with "No CMAKE_ASM_NASM_COMPILER could be found" on both win32-x64 and win32-arm64. Add nasm to the existing `choco install` line in both Windows toolchain steps (x64 + arm64-cross-compile) and append the choco install dir to $GITHUB_PATH so cmake's enable_language probe finds it. Prior attempt added a standalone `ilammy/setup-nasm@SHA` step but that produced repeated GHA startup_failure on dispatch (root cause not isolated; reverted in 8509ed7 + 53e7c30). Inline choco install matches the cmake/ccache/golang pattern that already works on these runners.
1 parent 53e7c30 commit 0d6566c

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/boringssl.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,12 +365,16 @@ jobs:
365365
shell: bash
366366
run: |
367367
for i in 1 2 3; do
368-
if choco install cmake mingw ccache golang -y; then
368+
if choco install cmake mingw ccache golang nasm -y; then
369369
break
370370
fi
371371
echo "Attempt $i failed, retrying in 10 seconds..."
372372
sleep 10
373373
done
374+
# choco installs nasm to `C:\Program Files\NASM` which isn't
375+
# added to PATH automatically; cmake's enable_language(ASM_NASM)
376+
# probes for `nasm` on PATH and dies if missing.
377+
echo "C:\Program Files\NASM" >> $GITHUB_PATH
374378
375379
- name: Setup build toolchain (Windows ARM64 cross-compile)
376380
if: |
@@ -380,12 +384,16 @@ jobs:
380384
shell: bash
381385
run: |
382386
for i in 1 2 3; do
383-
if choco install cmake ccache golang -y; then
387+
if choco install cmake ccache golang nasm -y; then
384388
break
385389
fi
386390
echo "Attempt $i failed, retrying in 10 seconds..."
387391
sleep 10
388392
done
393+
# See Setup build toolchain (Windows x64) for why NASM path is
394+
# added manually. ARM64 cross-compile path also calls
395+
# enable_language(ASM_NASM) at cmake configure time.
396+
echo "C:\Program Files\NASM" >> $GITHUB_PATH
389397
390398
- name: Install llvm-mingw (Windows ARM64 cross-compile)
391399
if: |

0 commit comments

Comments
 (0)