Commit 0d6566c
committed
fix(boringssl-ci): inline NASM via choco in existing Windows toolchain steps
BoringSSL's CMakeLists.txt unconditionally calls
enable_language(ASM_NASM) on Windows regardless of target arch.
Linux/macOS runners ship nasm by default; Windows runners do not,
so cmake configure dies with "No CMAKE_ASM_NASM_COMPILER could be
found" on both win32-x64 and win32-arm64.
Add nasm to the existing `choco install` line in both Windows
toolchain steps (x64 + arm64-cross-compile) and append the choco
install dir to $GITHUB_PATH so cmake's enable_language probe finds
it.
Prior attempt added a standalone `ilammy/setup-nasm@SHA` step but
that produced repeated GHA startup_failure on dispatch (root cause
not isolated; reverted in 8509ed7 + 53e7c30). Inline choco install
matches the cmake/ccache/golang pattern that already works on these
runners.1 parent 53e7c30 commit 0d6566c
1 file changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
368 | | - | |
| 368 | + | |
369 | 369 | | |
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
374 | 378 | | |
375 | 379 | | |
376 | 380 | | |
| |||
380 | 384 | | |
381 | 385 | | |
382 | 386 | | |
383 | | - | |
| 387 | + | |
384 | 388 | | |
385 | 389 | | |
386 | 390 | | |
387 | 391 | | |
388 | 392 | | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
389 | 397 | | |
390 | 398 | | |
391 | 399 | | |
| |||
0 commit comments