Remove vanilla::ends_with in favor of C++20 ends_with

Author: SpaceManiac

source/ham/appdata.cpp

@@ -349,7 +349,7 @@ const char* EscapeBinDirectory() {
 			perror("EscapeBinDirectory: getcwd");
 			ham_strcpy(bin_dir_buf, ".");
 		}
-		if (vanilla::ends_with(bin_dir_buf, "/build/install") || vanilla::ends_with(bin_dir_buf, "\\build\\install")) {
+		if (std::string_view(bin_dir_buf).ends_with("/build/install") || std::string_view(bin_dir_buf).ends_with("\\build\\install")) {
 			if (chdir("../..") < 0) {
 				perror("EscapeBinDirectory: chdir");
 			}

source/launcher/main.cpp

@@ -557,7 +557,7 @@ struct Launcher
 void CopyToAddonsFolder(std::string_view addonsFolder, std::string_view sourcePath)
 {
 	// .zip files only
-	if (!vanilla::ends_with(sourcePath, ".zip"))
+	if (!sourcePath.ends_with(".zip"))
 	{
 		return;
 	}

source/vanilla_extract/include/vfs.h

@@ -14,8 +14,6 @@ struct SDL_IOStream;
 
 namespace vanilla
 {
-	bool ends_with(std::string_view haystack, std::string_view suffix);
-
 	struct CaseInsensitive
 	{
 		bool operator() (const std::string& lhs, const std::string& rhs) const;

source/vanilla_extract/src/vfs.cpp

@@ -12,11 +12,6 @@ namespace vanilla {
 // ----------------------------------------------------------------------------
 // Simple helpers
 
-bool ends_with(std::string_view lhs, std::string_view rhs)
-{
-	return lhs.size() >= rhs.size() && lhs.compare(lhs.size() - rhs.size(), std::string_view::npos, rhs) == 0;
-}
-
 bool vanilla::CaseInsensitive::operator() (const std::string& lhs, const std::string& rhs) const
 {
 	return strcasecmp(lhs.c_str(), rhs.c_str()) < 0;
@@ -153,7 +148,7 @@ static void list_dir_inner(std::string_view prefix, Vfs* vfs, const char* direct
 			continue;
 
 		each.insert(0, prefix);
-		if (ends_with(each, TOMBSTONE_SUFFIX))
+		if (each.ends_with(TOMBSTONE_SUFFIX))
 		{
 			each.erase(each.size() - TOMBSTONE_SUFFIX.size());
 			output->erase(each);