Skip to content

Commit 19cbee0

Browse files
committed
update files
Signed-off-by: tqqq <dirtysalt1987@gmail.com>
1 parent 8e6784c commit 19cbee0

3 files changed

Lines changed: 14 additions & 7 deletions

File tree

be/src/connector/hive_connector.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,14 +430,13 @@ void HiveDataSource::_init_tuples_and_slots(RuntimeState* state) {
430430
_scanner_params.partition_index_in_chunk.push_back(i);
431431
_scanner_params._partition_index_in_hdfs_partition_columns.push_back(
432432
_hive_table->get_partition_col_index(slots[i]));
433-
_scanner_params._partition_index_in_hdfs_partition_columns.push_back(
434-
_hive_table->get_partition_col_index(slots[i]));
435433
} else if (int32_t index = scan_range_indicate_const_column_index(slots[i]->id()); index >= 0) {
436434
_scanner_params.partition_slots.push_back(slots[i]);
437435
_scanner_params.partition_index_in_chunk.push_back(i);
438436
_scanner_params._partition_index_in_hdfs_partition_columns.push_back(index);
439437
} else if (int32_t extended_col_index = extended_column_index(slots[i]->id()); extended_col_index >= 0) {
440438
_scanner_params.extended_col_slots.push_back(slots[i]);
439+
_scanner_params.extended_col_index_in_chunk.push_back(i);
441440
_scanner_params.index_in_extended_columns.push_back(extended_col_index);
442441
} else {
443442
_scanner_params.materialize_slots.push_back(slots[i]);

be/src/exec/hdfs_scanner/hdfs_scanner.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ Status HdfsScanner::reinterpret_status(const Status& st) {
526526

527527
void HdfsScanner::update_counter() {
528528
HdfsScannerProfile* profile = &_scanner_params.profile;
529-
if (profile == nullptr) return;
529+
if (profile->runtime_profile == nullptr) return;
530530

531531
update_hdfs_counter(profile);
532532

be/test/exec/hdfs_scanner/hdfs_scanner_test.cpp

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,12 @@ TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithDefaultValue) {
327327
{"c2", TypeDescriptor::from_logical_type(LogicalType::TYPE_INT)},
328328
{""}};
329329
auto* tuple_desc = _create_tuple_desc(descs);
330+
HdfsScannerParams scanner_params;
330331
HdfsScannerContext ctx;
332+
ctx.params = &scanner_params;
331333
ctx.not_existed_slots.push_back(tuple_desc->slots()[0]);
332334
ctx.not_existed_slots.push_back(tuple_desc->slots()[1]);
333-
ctx.params->materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "42");
335+
scanner_params.materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "42");
334336

335337
ChunkPtr chunk = RuntimeChunkHelper::new_chunk(*tuple_desc, 0);
336338
ASSERT_OK(ctx.append_or_update_not_existed_columns_to_chunk(&chunk, 1));
@@ -342,9 +344,11 @@ TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithDefaultValue) {
342344
TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithEmptyDefaultNullable) {
343345
SlotDesc descs[] = {{"c1", TypeDescriptor::from_logical_type(LogicalType::TYPE_VARCHAR)}, {""}};
344346
auto* tuple_desc = _create_tuple_desc(descs);
347+
HdfsScannerParams scanner_params;
345348
HdfsScannerContext ctx;
349+
ctx.params = &scanner_params;
346350
ctx.not_existed_slots.push_back(tuple_desc->slots()[0]);
347-
ctx.params->materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "");
351+
scanner_params.materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "");
348352

349353
ChunkPtr chunk = RuntimeChunkHelper::new_chunk(*tuple_desc, 0);
350354
ASSERT_OK(ctx.append_or_update_not_existed_columns_to_chunk(&chunk, 1));
@@ -356,9 +360,11 @@ TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithEmptyDefaultNullable) {
356360
TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithEmptyDefaultNonNullable) {
357361
SlotDesc descs[] = {{"c1", TypeDescriptor::from_logical_type(LogicalType::TYPE_VARCHAR)}, {""}};
358362
auto* tuple_desc = _create_tuple_desc_with_nullable(descs, false);
363+
HdfsScannerParams scanner_params;
359364
HdfsScannerContext ctx;
365+
ctx.params = &scanner_params;
360366
ctx.not_existed_slots.push_back(tuple_desc->slots()[0]);
361-
ctx.params->materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "");
367+
scanner_params.materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "");
362368

363369
ChunkPtr chunk = RuntimeChunkHelper::new_chunk(*tuple_desc, 0);
364370
ASSERT_OK(ctx.append_or_update_not_existed_columns_to_chunk(&chunk, 1));
@@ -369,9 +375,11 @@ TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithEmptyDefaultNonNullable) {
369375
TEST_F(HdfsScannerTest, TestFillNotExistedColumnWithEmptyDefaultNonString) {
370376
SlotDesc descs[] = {{"c1", TypeDescriptor::from_logical_type(LogicalType::TYPE_INT)}, {""}};
371377
auto* tuple_desc = _create_tuple_desc(descs);
378+
HdfsScannerParams scanner_params;
372379
HdfsScannerContext ctx;
380+
ctx.params = &scanner_params;
373381
ctx.not_existed_slots.push_back(tuple_desc->slots()[0]);
374-
ctx.params->materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "");
382+
scanner_params.materialize_slot_default_values.emplace(tuple_desc->slots()[0]->id(), "");
375383

376384
ChunkPtr chunk = RuntimeChunkHelper::new_chunk(*tuple_desc, 0);
377385
auto status = ctx.append_or_update_not_existed_columns_to_chunk(&chunk, 1);

0 commit comments

Comments
 (0)