Skip to content

Commit 470e591

Browse files
committed
update files
Signed-off-by: tqqq <dirtysalt1987@gmail.com>
1 parent ec7d649 commit 470e591

3 files changed

Lines changed: 12 additions & 7 deletions

File tree

be/src/connector/hive_connector.cpp

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -583,17 +583,25 @@ void HiveDataSource::_init_counter(RuntimeState* state) {
583583
_scanner_ctx.profile.rows_read_counter = ADD_COUNTER(_runtime_profile, "RowsRead", TUnit::UNIT);
584584
_scanner_ctx.profile.late_materialize_skip_rows_counter =
585585
ADD_COUNTER(_runtime_profile, "LateMaterializeSkipRows", TUnit::UNIT);
586+
// Row count: rows filtered out before lazy columns were read.
586587
_scanner_ctx.profile.parquet_lazy_col_skip_rows_counter =
587588
ADD_COUNTER(_runtime_profile, "ParquetLazyColSkipRows", TUnit::UNIT);
589+
590+
// Event count: how many lazy slots were materialized on-demand during
591+
// predicate evaluation via MissingColumnProvider.
588592
_scanner_ctx.profile.parquet_lazy_slot_triggered_counter =
589593
ADD_COUNTER(_runtime_profile, "ParquetLazySlotTriggered", TUnit::UNIT);
594+
595+
// Operation count: lazy column read_range() calls (includes both
596+
// on-demand triggers and backfill reads).
590597
_scanner_ctx.profile.parquet_lazy_read_count_counter =
591598
ADD_COUNTER(_runtime_profile, "ParquetLazyReadCount", TUnit::UNIT);
599+
600+
// Time spent reading lazy columns (on-demand + backfill).
592601
_scanner_ctx.profile.parquet_lazy_read_timer = ADD_TIMER(_runtime_profile, "ParquetLazyReadTime");
593-
_scanner_ctx.profile.parquet_lazy_materialization_enabled_counter =
594-
ADD_COUNTER(_runtime_profile, "ParquetLazyMaterializationEnabled", TUnit::UNIT);
595-
COUNTER_SET(_scanner_ctx.profile.parquet_lazy_materialization_enabled_counter,
596-
static_cast<int64_t>(config::parquet_late_materialization_enable ? 1 : 0));
602+
603+
// Row group count: row groups where every classified-lazy column was
604+
// triggered on-demand (suggests active/lazy classification misprediction).
597605
_scanner_ctx.profile.parquet_lazy_full_trigger_count_counter =
598606
ADD_COUNTER(_runtime_profile, "ParquetLazyFullTriggerCount", TUnit::UNIT);
599607
_scanner_ctx.profile.scan_ranges_counter = ADD_COUNTER(_runtime_profile, "ScanRanges", TUnit::UNIT);

be/src/exec/hdfs_scanner/hdfs_scanner.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ struct HdfsScannerProfile {
165165
RuntimeProfile::Counter* parquet_lazy_slot_triggered_counter = nullptr;
166166
RuntimeProfile::Counter* parquet_lazy_read_count_counter = nullptr;
167167
RuntimeProfile::Counter* parquet_lazy_read_timer = nullptr;
168-
RuntimeProfile::Counter* parquet_lazy_materialization_enabled_counter = nullptr;
169168
RuntimeProfile::Counter* parquet_lazy_full_trigger_count_counter = nullptr;
170169
RuntimeProfile::Counter* scan_ranges_counter = nullptr;
171170
RuntimeProfile::Counter* scan_ranges_size = nullptr;

be/src/exec/hdfs_scanner/hdfs_scanner_parquet.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,6 @@ Status HdfsParquetScanner::do_open(RuntimeState* runtime_state) {
268268
}
269269

270270
Status HdfsParquetScanner::do_get_next(RuntimeState* runtime_state, ChunkPtr* chunk) {
271-
// Multi-slot conjuncts are now evaluated inside GroupReader (step 2b)
272-
// with lazy-materialization support, making a post-hoc pass unnecessary.
273271
return _reader->get_next(chunk);
274272
}
275273

0 commit comments

Comments
 (0)