Remove BrpcStubCacheTest friend declaration from production header

Replace white-box _timer assertions with behavioral assertions via
public API in the two singleton-reinitialize tests.

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

Author: kaijianding

be/src/common/brpc/brpc_stub_cache.h

@@ -55,7 +55,6 @@
 namespace starrocks {
 
 class MetricRegistry;
-class BrpcStubCacheTest;
 
 constexpr int TIMER_TASK_RUNNING = 1;
 
@@ -125,8 +124,6 @@ class BrpcStubCache {
     template <typename CacheT>
     friend void reset_state_for_rebind(CacheT* cache, BthreadTimer* timer);
 
-    friend class starrocks::BrpcStubCacheTest;
-
     void replace_cleanup_task_locked(const butil::EndPoint& endpoint,
                                      std::shared_ptr<EndpointCleanupTask<BrpcStubCache>> task);
 
@@ -170,8 +167,6 @@ class HttpBrpcStubCache {
     template <typename CacheT>
     friend void reset_state_for_rebind(CacheT* cache, BthreadTimer* timer);
 
-    friend class starrocks::BrpcStubCacheTest;
-
     void replace_cleanup_task_locked(const butil::EndPoint& endpoint,
                                      std::shared_ptr<EndpointCleanupTask<HttpBrpcStubCache>> task);
 
@@ -209,8 +204,6 @@ class LakeServiceBrpcStubCache {
     template <typename CacheT>
     friend void reset_state_for_rebind(CacheT* cache, BthreadTimer* timer);
 
-    friend class starrocks::BrpcStubCacheTest;
-
     void replace_cleanup_task_locked(const butil::EndPoint& endpoint,
                                      std::shared_ptr<EndpointCleanupTask<LakeServiceBrpcStubCache>> task);
 

be/test/common/brpc/brpc_stub_cache_test.cpp

@@ -270,7 +270,6 @@ TEST_F(BrpcStubCacheTest, http_singleton_reinitialize_rebinds_pipeline_timer) {
     HttpBrpcStubCache::initialize(_timer.get());
     auto* cache = HttpBrpcStubCache::getInstance();
     ASSERT_NE(nullptr, cache);
-    ASSERT_EQ(_timer.get(), cache->_timer);
 
     TNetworkAddress address;
     address.hostname = "127.0.0.1";
@@ -280,10 +279,9 @@ TEST_F(BrpcStubCacheTest, http_singleton_reinitialize_rebinds_pipeline_timer) {
     ASSERT_NE(nullptr, *stub);
 
     cache->shutdown();
-    ASSERT_EQ(nullptr, cache->_timer);
+    ASSERT_FALSE(cache->get_http_stub(address).ok());
 
     HttpBrpcStubCache::initialize(timer2.get());
-    ASSERT_EQ(timer2.get(), cache->_timer);
 
     auto rebound_stub = cache->get_http_stub(address);
     ASSERT_TRUE(rebound_stub.ok());
@@ -300,17 +298,15 @@ TEST_F(BrpcStubCacheTest, lake_singleton_reinitialize_rebinds_pipeline_timer) {
     LakeServiceBrpcStubCache::initialize(_timer.get());
     auto* cache = LakeServiceBrpcStubCache::getInstance();
     ASSERT_NE(nullptr, cache);
-    ASSERT_EQ(_timer.get(), cache->_timer);
 
     auto stub = cache->get_stub("127.0.0.1", 123);
     ASSERT_TRUE(stub.ok());
     ASSERT_NE(nullptr, *stub);
 
     cache->shutdown();
-    ASSERT_EQ(nullptr, cache->_timer);
+    ASSERT_FALSE(cache->get_stub("127.0.0.1", 123).ok());
 
     LakeServiceBrpcStubCache::initialize(timer2.get());
-    ASSERT_EQ(timer2.get(), cache->_timer);
 
     auto rebound_stub = cache->get_stub("127.0.0.1", 123);
     ASSERT_TRUE(rebound_stub.ok());