[BugFix] Fix analysis time nullability for ROLLUP keys (backport #76149)#76408
Closed
mergify[bot] wants to merge 1 commit into
Closed
[BugFix] Fix analysis time nullability for ROLLUP keys (backport #76149)#76408mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Christopher Sapinski <christopher.sapinski@celerdata.com> (cherry picked from commit 0829123) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/SelectAnalyzer.java
Contributor
Author
|
Cherry-pick of 0829123 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
#75684 introduced a bug for
GROUP BY ROLLUP / CUBE / GROUPING SETSproduces NULLs in the grouping key columns, whileSelectAnalyzerderives output field nullability solely from the expression itself (item.getExpr().isNullable(), i.e. the base column's nullability). This widening normally happens at the optimizer level, but due to ArrowFlight, the schema needs to be correct at analysis time.What I'm doing:
Fix the bug for nullable columns when there are grouping clauses.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #76149 done by [Mergify](https://mergify.com).