chore: migrate certificate contract to soroban sdk v22 and fix compilation

Author: Vicky08100

contracts/certificate/Cargo.toml

@@ -15,7 +15,7 @@ categories = ["cryptography::cryptocurrencies", "web-programming"]
 crate-type = ["lib", "cdylib"]
 
 [dependencies]
-soroban-sdk = { workspace = true }
+soroban-sdk = { workspace = true, features = ["alloc"] }
 shared = { path = "../shared" }
 
 [dev-dependencies]

contracts/certificate/src/events.rs

@@ -2,9 +2,9 @@ use shared::emit_certification_event;
 use shared::event_schema::{
     BatchCompletedEvent, CertificateReissuedEvent, CertificateSharedEvent,
     CertificateVerifiedEvent, CertificationEventData, CertificationIssuedEvent,
-    CertificationRevokedEvent, ComplianceCheckedEvent, MultisigApprovalGrantedEvent,
-    MultisigConfigUpdatedEvent, MultisigRequestApprovedEvent, MultisigRequestCreatedEvent,
-    MultisigRequestRejectedEvent, TemplateCreatedEvent,
+    CertificationRevokedEvent, ComplianceCheckedEvent, ComplianceViolationEvent,
+    MultisigApprovalGrantedEvent, MultisigConfigUpdatedEvent, MultisigRequestApprovedEvent,
+    MultisigRequestCreatedEvent, MultisigRequestRejectedEvent, TemplateCreatedEvent,
 };
 use soroban_sdk::{symbol_short, Address, BytesN, Env, String};
 
@@ -187,7 +187,7 @@ pub fn emit_compliance_violation(
     env: &Env,
     certificate_id: &BytesN<32>,
     standard: &str,
-    details: &str,
+    details: String,
 ) {
     emit_certification_event!(
         env,
@@ -196,7 +196,7 @@ pub fn emit_compliance_violation(
         CertificationEventData::ComplianceViolation(ComplianceViolationEvent {
             certificate_id: certificate_id.clone(),
             standard: String::from_str(env, standard),
-            violation_details: String::from_str(env, details),
+            violation_details: details,
         })
     );
 }

contracts/certificate/src/lib.rs

@@ -1133,15 +1133,7 @@ impl CertificateContract {
         }
 
         // Perform substitution in description
-        let mut description = params.description.clone();
-        for (name, value) in field_values.iter() {
-            // Substitution logic note: 
-            // While full string replacement is expensive on-chain, we store the values
-            // here to ensure the certificate remains fully audit-compliant and 
-            // substitution can be verified deterministically.
-            let _ = (name, value);
-        }
-
+        let description = params.description.clone();
         storage::set_template_values(&env, &params.certificate_id, &field_values);
 
         let anchor = generate_blockchain_anchor(&env, &params.certificate_id);
@@ -1183,7 +1175,13 @@ impl CertificateContract {
             a.active_certificates += 1;
         });
 
-        record_audit(&env, &params.certificate_id, AuditAction::Executed, &admin, "Issued with template");
+        record_audit(
+            &env,
+            &params.certificate_id,
+            AuditAction::Executed,
+            &admin,
+            "Issued with template",
+        );
 
         Ok(params.certificate_id)
     }
@@ -1199,6 +1197,13 @@ impl CertificateContract {
         let template =
             storage::get_template(&env, &template_id).ok_or(CertificateError::TemplateNotFound)?;
 
+        // Validate required fields
+        for field in template.fields.iter() {
+            if field.is_required && !field_values.contains_key(field.field_name.clone()) {
+                return Err(CertificateError::MissingRequiredField);
+            }
+        }
+
         Ok(Certificate {
             certificate_id: BytesN::from_array(&env, &[0u8; 32]),
             course_id,
@@ -1397,28 +1402,24 @@ impl CertificateContract {
         // 1. Expiry Check
         if cert.expiry_date != 0 && env.ledger().timestamp() > cert.expiry_date {
             is_compliant = false;
-            violation_details = String::from_str(&env, "Certificate has expired; ");
+            violation_details = String::from_str(&env, "Expired");
         }
-
         // 2. Status Check
-        if cert.status != CertificateStatus::Active {
+        else if cert.status != CertificateStatus::Active {
             is_compliant = false;
-            let status_msg = match cert.status {
-                CertificateStatus::Revoked => "Revoked",
-                CertificateStatus::Suspended => "Suspended",
-                CertificateStatus::Expired => "Expired",
-                CertificateStatus::Reissued => "Reissued",
-                _ => "Inactive",
+            violation_details = match cert.status {
+                CertificateStatus::Revoked => String::from_str(&env, "Status: Revoked"),
+                CertificateStatus::Suspended => String::from_str(&env, "Status: Suspended"),
+                CertificateStatus::Expired => String::from_str(&env, "Status: Expired"),
+                CertificateStatus::Reissued => String::from_str(&env, "Status: Reissued"),
+                CertificateStatus::NonCompliant => String::from_str(&env, "Status: Non-Compliant"),
+                _ => String::from_str(&env, "Status: Inactive"),
             };
-            violation_details = String::from_str(&env, "Certificate status is ");
-            violation_details.append(&String::from_str(&env, status_msg));
-            violation_details.append(&String::from_str(&env, "; "));
         }
-
         // 3. Provenance Check
-        if cert.blockchain_anchor.is_none() {
+        else if cert.blockchain_anchor.is_none() {
             is_compliant = false;
-            violation_details = String::from_str(&env, "Blockchain anchor is missing; ");
+            violation_details = String::from_str(&env, "Missing Anchor");
         }
 
         if !is_compliant {
@@ -1440,7 +1441,7 @@ impl CertificateContract {
                 &env,
                 &certificate_id,
                 "Standard Automated Check",
-                &violation_details.to_string(),
+                violation_details,
             );
             record_audit(
                 &env,
@@ -1472,8 +1473,8 @@ impl CertificateContract {
         require_initialized(&env)?;
         require_compliance_officer(&env, &officer)?;
 
-        let mut cert =
-            storage::get_certificate(&env, &certificate_id).ok_or(CertificateError::CertificateNotFound)?;
+        let mut cert = storage::get_certificate(&env, &certificate_id)
+            .ok_or(CertificateError::CertificateNotFound)?;
         cert.status = CertificateStatus::NonCompliant;
         storage::set_certificate(&env, &certificate_id, &cert);
 
@@ -1485,7 +1486,7 @@ impl CertificateContract {
             &env,
             &certificate_id,
             "Manual Compliance Override",
-            &notes,
+            notes.clone(),
         );
 
         record_audit(
@@ -1512,6 +1513,7 @@ impl CertificateContract {
                     CertificateStatus::Expired => String::from_str(&env, "Expired"),
                     CertificateStatus::Suspended => String::from_str(&env, "Suspended"),
                     CertificateStatus::Reissued => String::from_str(&env, "Reissued"),
+                    CertificateStatus::NonCompliant => String::from_str(&env, "Non-Compliant"),
                 },
             );
             report.set(

contracts/certificate/src/storage.rs

@@ -1,4 +1,4 @@
-use soroban_sdk::{IntoVal, RawVal, Address, BytesN, Env, Map, String, Vec};
+use soroban_sdk::{Address, BytesN, Env, IntoVal, Map, String, Val, Vec};
 
 use crate::types::{
     CertDataKey, Certificate, CertificateAnalytics, CertificateBackup, CertificateTemplate,
@@ -14,7 +14,7 @@ const MIN_PERSISTENT_TTL: u32 = 518_400; // ~30 days in ledgers (assuming 5s per
 /// TTL Extension: 90 days
 const EXTEND_TTL_TO: u32 = 1_555_200; // ~90 days
 
-fn extend_ttl_persistent<K: IntoVal<Env, RawVal>>(env: &Env, key: &K) {
+fn extend_ttl_persistent<K: IntoVal<Env, Val>>(env: &Env, key: &K) {
     env.storage().persistent().extend_ttl(key, MIN_PERSISTENT_TTL, EXTEND_TTL_TO);
 }
 
@@ -222,15 +222,15 @@ pub fn set_template(env: &Env, template_id: &String, template: &CertificateTempl
     // Add to template list if not already present
     let mut list: Vec<String> =
         env.storage().persistent().get(&CertDataKey::TemplateList).unwrap_or_else(|| Vec::new(env));
-    
+
     let mut exists = false;
     for id in list.iter() {
         if id == *template_id {
             exists = true;
             break;
         }
     }
-    
+
     if !exists {
         list.push_back(template_id.clone());
         env.storage().persistent().set(&CertDataKey::TemplateList, &list);
@@ -286,6 +286,7 @@ pub fn get_analytics(env: &Env) -> CertificateAnalytics {
         active_certificates: 0,
         pending_requests: 0,
         avg_approval_time: 0,
+        compliance_violations_count: 0,
         last_updated: 0,
     })
 }

contracts/certificate/src/test.rs

@@ -1,13 +1,14 @@
 use shared::monitoring::ContractHealthStatus;
 use soroban_sdk::{
     testutils::{Address as _, Ledger as _},
-    Address, BytesN, Env, String, Vec,
+    Address, BytesN, Env, Map, String, Vec,
 };
 
 use crate::{
     types::{
-        CertificatePriority, CertificateStatus, ComplianceStandard, FieldType,
-        MintCertificateParams, MultiSigConfig, MultiSigRequestStatus, TemplateField,
+        CertDataKey, CertRateLimitConfig, CertificatePriority, CertificateStatus,
+        ComplianceStandard, FieldType, MintCertificateParams, MultiSigConfig,
+        MultiSigRequestStatus, TemplateField,
     },
     CertificateContract, CertificateContractClient,
 };
@@ -583,7 +584,8 @@ fn test_create_and_use_template() {
 
     let mut field_values: Map<String, String> = Map::new(&env);
     field_values.set(String::from_str(&env, "student_name"), String::from_str(&env, "John Doe"));
-    field_values.set(String::from_str(&env, "completion_date"), String::from_str(&env, "2026-02-25"));
+    field_values
+        .set(String::from_str(&env, "completion_date"), String::from_str(&env, "2026-02-25"));
 
     let cert_id = client.issue_with_template(&admin, &template_id, &params, &field_values);
     assert_eq!(cert_id, params.certificate_id);
@@ -645,7 +647,12 @@ fn test_automated_compliance_audit() {
     assert!(is_compliant);
 
     // Revoke and check again
-    client.revoke_certificate(&admin, &params.certificate_id, &String::from_str(&env, "Revoked"), &false);
+    client.revoke_certificate(
+        &admin,
+        &params.certificate_id,
+        &String::from_str(&env, "Revoked"),
+        &false,
+    );
     let is_compliant_after = client.automated_compliance_audit(&params.certificate_id);
     assert!(!is_compliant_after);
 }
@@ -1131,44 +1138,43 @@ fn test_health_check_before_init() {
 fn test_compliance_officer_and_manual_override() {
     let (env, client, admin) = setup_env();
     let officer = Address::generate(&env);
-    
+
     // Set officer
     client.set_compliance_officer(&admin, &officer);
-    
+
     // Issue certificate
     let student = Address::generate(&env);
     let params = make_cert_params(&env, "OVERRIDE_COURSE", &student);
     let mut list = Vec::new(&env);
     list.push_back(params.clone());
     client.batch_issue_certificates(&admin, &list);
-    
+
     // Manual override
     client.manual_compliance_override(
         &officer,
         &params.certificate_id,
         &String::from_str(&env, "Flagged for manual review"),
     );
-    
+
     let cert = client.get_certificate(&params.certificate_id).unwrap();
     assert_eq!(cert.status, CertificateStatus::NonCompliant);
-    
+
     let analytics = client.get_analytics();
     assert_eq!(analytics.compliance_violations_count, 1);
 }
 
 #[test]
 fn test_automated_compliance_audit_rate_limit() {
     let (env, client, admin) = setup_env();
-    
+
     // Issue certificate
     let student = Address::generate(&env);
     let params = make_cert_params(&env, "RL_COURSE", &student);
     let mut list = Vec::new(&env);
     list.push_back(params.clone());
     client.batch_issue_certificates(&admin, &list);
-    
+
     // Configure strict rate limit (3 calls per day)
-    client.set_admin(&admin, &admin); // Ensure admin can configure
     env.as_contract(&client.address, || {
         env.storage().instance().set(
             &CertDataKey::RateLimitCfg,
@@ -1177,10 +1183,10 @@ fn test_automated_compliance_audit_rate_limit() {
     });
 
     // Call 1, 2, 3: Succeed
-    assert!(client.automated_compliance_audit(&params.certificate_id).is_ok());
-    assert!(client.automated_compliance_audit(&params.certificate_id).is_ok());
-    assert!(client.automated_compliance_audit(&params.certificate_id).is_ok());
-    
+    assert!(client.try_automated_compliance_audit(&params.certificate_id).is_ok());
+    assert!(client.try_automated_compliance_audit(&params.certificate_id).is_ok());
+    assert!(client.try_automated_compliance_audit(&params.certificate_id).is_ok());
+
     // Call 4: Fail
     let res = client.try_automated_compliance_audit(&params.certificate_id);
     assert!(res.is_err());