Merge pull request #366 from popsman01/feature/issue-94-performance-optimization

feat(perf): infrastructure performance optimization

Author: Mystery-CLI

PERFORMANCE.md

@@ -13,25 +13,54 @@ The script checks:
 1. **Slow queries** — `pg_stat_statements` top 10 by mean execution time
 2. **Index usage** — tables with low index-scan ratio (candidates for new indexes)
 3. **API latency** — live data from `/health/metrics`
-4. **Container resources** — CPU/memory via `docker stats`
-5. **Redis hit rate** — `keyspace_hits` vs `keyspace_misses`
+4. **APM bottlenecks** — live data from `/performance/bottlenecks` (slow queries + index usage + cache stats)
+5. **Container resources** — CPU/memory via `docker stats`
+6. **Redis hit rate** — `keyspace_hits` vs `keyspace_misses`
+
+### Live Bottleneck API
+
+`GET /performance/bottlenecks` returns a JSON report combining:
+- Top 10 slow queries from `pg_stat_statements`
+- Tables with low index-scan ratio
+- Current cache hit/miss stats
+
+```bash
+curl http://localhost:3000/performance/bottlenecks | jq .
+```
+
+### Slow Query Threshold
+
+Queries exceeding **100ms** are automatically logged to the `slow_query_log` table.
+Query the table to find recurring slow patterns:
+
+```sql
+SELECT query_hash, query_text, round(avg(duration_ms)::numeric, 1) AS avg_ms, count(*) AS hits
+FROM slow_query_log
+WHERE recorded_at > NOW() - INTERVAL '24 hours'
+GROUP BY query_hash, query_text
+ORDER BY avg_ms DESC
+LIMIT 20;
+```
 
 ---
 
 ## Caching Strategy
 
 ### Redis API Cache (`indexer/src/cache.rs`)
 
-| Endpoint pattern | TTL | Rationale |
-|-----------------|-----|-----------|
-| `GET /events*` | 10s | High-frequency reads; Stellar ledger closes every ~5s |
-| `GET /search*` | 30s | Search results change infrequently |
-| `GET /stats` | 60s | Aggregate — expensive to compute |
-| `POST /events/replay` | no cache | Mutating |
+| Endpoint pattern | TTL | Config key | Rationale |
+|-----------------|-----|-----------|-----------|
+| `GET /events*` | 10s | `events_ttl_secs` | High-frequency reads; Stellar ledger closes every ~5s |
+| `GET /search*` | 30s | `search_ttl_secs` | Search results change infrequently |
+| `GET /stats` | 60s | `stats_ttl_secs` | Aggregate — expensive to compute |
+| `GET /analytics/dashboard` | 60s | `analytics_ttl_secs` | Heavy aggregation query |
+| `POST /events/replay` | no cache | — | Mutating |
 
-**Activate:** set `redis_url` in `config.toml` or `REDIS_URL` env var.  
+**Activate:** set `redis_url` in `config.toml` or `STELLAR_ESCROW__CACHE__REDIS_URL` env var.  
 **Fallback:** if Redis is unavailable, all requests hit Postgres directly — no errors.
 
+All TTLs are configurable in `indexer/config.toml` under `[cache]`.
+
 ### Client-Side Cache (`frontend/performance.js`)
 
 `cachedFetch()` provides an in-memory TTL cache (default 30s) for API responses.  
@@ -50,6 +79,17 @@ Call `invalidateCache(url)` after any write operation to keep the UI consistent.
 
 ## Resource Allocation
 
+### Docker Resource Limits
+
+Applied in `docker-compose.yml` for all application services:
+
+| Service | CPU limit | Memory limit | CPU reservation | Memory reservation |
+|---------|-----------|-------------|-----------------|-------------------|
+| indexer | 1.0 | 512M | 0.25 | 128M |
+| api | 0.5 | 256M | 0.1 | 64M |
+
+Adjust limits based on observed usage from `docker stats` or the Grafana infrastructure dashboard.
+
 ### Database Connection Pool
 
 Configured in `indexer/config.toml`:
@@ -63,6 +103,8 @@ min_connections = 2    # keep warm connections ready
 **Rule of thumb:** `max_connections = (2 × CPU cores) + effective_spindle_count`  
 For a 4-core host: set `max_connections = 10–15`.
 
+Monitor pool saturation via `GET /performance/bottlenecks` → `index_usage` or the Grafana PostgreSQL connections panel.
+
 ### Nginx (`performance.nginx.conf`)
 
 - `worker_processes auto` — one worker per CPU core
@@ -143,8 +185,11 @@ Metrics are collected at three layers:
 ## Quick Wins Checklist
 
 - [ ] Enable Redis (`redis_url` in config) — eliminates repeat DB hits for read-heavy endpoints
-- [ ] Enable `pg_stat_statements` extension — required for slow query analysis
+- [ ] Enable `pg_stat_statements` extension — required for slow query analysis (migration `20260329000001_perf_optimization.sql` does this)
 - [ ] Set `max_connections` based on actual CPU count
 - [ ] Include `performance.nginx.conf` in nginx http block
-- [ ] Add `REDIS_URL` to docker-compose environment
+- [ ] Add `STELLAR_ESCROW__CACHE__REDIS_URL` to docker-compose environment
 - [ ] Run `perf-analyze.sh` weekly and track trends
+- [ ] Review `GET /performance/bottlenecks` after each deploy
+- [ ] Check `slow_query_log` table weekly for recurring slow patterns
+- [ ] Tune Docker resource limits based on `docker stats` observations

docker-compose.yml

@@ -57,6 +57,14 @@ services:
     read_only: true
     tmpfs:
       - /tmp
+    deploy:
+      resources:
+        limits:
+          cpus: '1.0'
+          memory: 512M
+        reservations:
+          cpus: '0.25'
+          memory: 128M
     depends_on:
       postgres:
         condition: service_healthy
@@ -87,6 +95,14 @@ services:
     read_only: true
     tmpfs:
       - /tmp
+    deploy:
+      resources:
+        limits:
+          cpus: '0.5'
+          memory: 256M
+        reservations:
+          cpus: '0.1'
+          memory: 64M
     depends_on:
       postgres:
         condition: service_healthy

indexer/config.toml

@@ -10,6 +10,9 @@ min_connections = 2
 redis_url = ""          # Set to redis://localhost:6379 to enable
 default_ttl_secs = 30
 events_ttl_secs = 10
+search_ttl_secs = 30
+analytics_ttl_secs = 60
+stats_ttl_secs = 60
 
 [stellar]
 network = "testnet"

indexer/migrations/20260329000001_perf_optimization.sql

@@ -0,0 +1,27 @@
+-- Enable pg_stat_statements for slow query analysis
+CREATE EXTENSION IF NOT EXISTS pg_stat_statements;
+
+-- Slow query log table: populated by the application when a query exceeds the threshold
+CREATE TABLE IF NOT EXISTS slow_query_log (
+    id          BIGSERIAL PRIMARY KEY,
+    recorded_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    query_hash  TEXT        NOT NULL,
+    query_text  TEXT        NOT NULL,
+    duration_ms DOUBLE PRECISION NOT NULL,
+    rows_returned INT
+);
+
+CREATE INDEX IF NOT EXISTS idx_slow_query_recorded ON slow_query_log (recorded_at DESC);
+CREATE INDEX IF NOT EXISTS idx_slow_query_duration ON slow_query_log (duration_ms DESC);
+
+-- Partial index on events.data for trade_id lookups (already exists, kept for reference)
+-- Composite covering index for the most common paginated event query
+CREATE INDEX IF NOT EXISTS idx_events_type_ledger_id
+    ON events (event_type, ledger DESC, id)
+    WHERE event_type IS NOT NULL;
+
+-- Covering index for search_trades hot path
+CREATE INDEX IF NOT EXISTS idx_events_trade_search
+    ON events (ledger DESC, timestamp DESC, event_type)
+    INCLUDE (id, data)
+    WHERE category = 'trade';

indexer/src/cache_service/mod.rs

@@ -115,6 +115,24 @@ impl CacheService {
         self.invalidate(&key).await;
     }
 
+    pub async fn get_search<T: serde::de::DeserializeOwned>(&self, cache_key: &str) -> Option<T> {
+        self.get(cache_key).await
+    }
+
+    pub async fn set_search<T: serde::Serialize>(&self, cache_key: &str, value: &T) {
+        let ttl = Duration::from_secs(self.config.search_ttl_secs);
+        self.set(cache_key, value, ttl).await;
+    }
+
+    pub async fn get_analytics<T: serde::de::DeserializeOwned>(&self) -> Option<T> {
+        self.get(KEY_ANALYTICS_DASHBOARD).await
+    }
+
+    pub async fn set_analytics<T: serde::Serialize>(&self, value: &T) {
+        let ttl = Duration::from_secs(self.config.analytics_ttl_secs);
+        self.set(KEY_ANALYTICS_DASHBOARD, value, ttl).await;
+    }
+
     /// Warm the cache by pre-loading frequently accessed keys.
     /// Called at startup and periodically.
     pub async fn warm<F, Fut>(&self, loader: F)

indexer/src/config.rs

@@ -143,14 +143,22 @@ pub struct CacheConfig {
     /// TTL for event list responses (seconds, default: 10)
     #[serde(default = "default_events_ttl")]
     pub events_ttl_secs: u64,
-}
-
-fn default_cache_ttl() -> u64 {
-    30
-}
-fn default_events_ttl() -> u64 {
-    10
-}
+    /// TTL for search results (seconds, default: 30)
+    #[serde(default = "default_search_ttl")]
+    pub search_ttl_secs: u64,
+    /// TTL for analytics dashboard (seconds, default: 60)
+    #[serde(default = "default_analytics_ttl")]
+    pub analytics_ttl_secs: u64,
+    /// TTL for platform stats (seconds, default: 60)
+    #[serde(default = "default_stats_ttl")]
+    pub stats_ttl_secs: u64,
+}
+
+fn default_cache_ttl() -> u64 { 30 }
+fn default_events_ttl() -> u64 { 10 }
+fn default_search_ttl() -> u64 { 30 }
+fn default_analytics_ttl() -> u64 { 60 }
+fn default_stats_ttl() -> u64 { 60 }
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct StellarConfig {

indexer/src/database.rs

@@ -55,6 +55,95 @@ impl Database {
         Self { pool }
     }
 
+    /// Record a slow query to the slow_query_log table (fire-and-forget).
+    /// Only logs queries exceeding `threshold_ms`.
+    pub fn log_slow_query(
+        pool: PgPool,
+        query_hash: String,
+        query_text: String,
+        duration_ms: f64,
+        rows_returned: Option<i32>,
+    ) {
+        const THRESHOLD_MS: f64 = 100.0;
+        if duration_ms < THRESHOLD_MS {
+            return;
+        }
+        tokio::spawn(async move {
+            let _ = sqlx::query(
+                "INSERT INTO slow_query_log (query_hash, query_text, duration_ms, rows_returned) \
+                 VALUES ($1, $2, $3, $4)",
+            )
+            .bind(&query_hash)
+            .bind(&query_text)
+            .bind(duration_ms)
+            .bind(rows_returned)
+            .execute(&pool)
+            .await;
+        });
+    }
+
+    /// Fetch the top slow queries from pg_stat_statements.
+    pub async fn get_slow_queries(&self, limit: i64) -> Result<Vec<serde_json::Value>, sqlx::Error> {
+        let rows = sqlx::query(
+            r#"
+            SELECT query,
+                   calls,
+                   round(mean_exec_time::numeric, 2)  AS mean_ms,
+                   round(total_exec_time::numeric, 2) AS total_ms,
+                   round(stddev_exec_time::numeric, 2) AS stddev_ms
+            FROM pg_stat_statements
+            ORDER BY mean_exec_time DESC
+            LIMIT $1
+            "#,
+        )
+        .bind(limit.clamp(1, 50))
+        .fetch_all(&self.pool)
+        .await?;
+
+        Ok(rows
+            .into_iter()
+            .map(|r| {
+                serde_json::json!({
+                    "query":    r.get::<String, _>("query"),
+                    "calls":    r.get::<i64, _>("calls"),
+                    "mean_ms":  r.get::<f64, _>("mean_ms"),
+                    "total_ms": r.get::<f64, _>("total_ms"),
+                    "stddev_ms":r.get::<f64, _>("stddev_ms"),
+                })
+            })
+            .collect())
+    }
+
+    /// Fetch tables with low index-scan ratio (candidates for new indexes).
+    pub async fn get_index_usage(&self) -> Result<Vec<serde_json::Value>, sqlx::Error> {
+        let rows = sqlx::query(
+            r#"
+            SELECT relname AS table,
+                   seq_scan, idx_scan,
+                   CASE WHEN seq_scan + idx_scan = 0 THEN 0
+                        ELSE round(100.0 * idx_scan / (seq_scan + idx_scan), 1)
+                   END AS idx_pct
+            FROM pg_stat_user_tables
+            ORDER BY idx_pct ASC
+            LIMIT 20
+            "#,
+        )
+        .fetch_all(&self.pool)
+        .await?;
+
+        Ok(rows
+            .into_iter()
+            .map(|r| {
+                serde_json::json!({
+                    "table":    r.get::<String, _>("table"),
+                    "seq_scan": r.get::<i64, _>("seq_scan"),
+                    "idx_scan": r.get::<i64, _>("idx_scan"),
+                    "idx_pct":  r.get::<f64, _>("idx_pct"),
+                })
+            })
+            .collect())
+    }
+
     pub async fn insert_event(&self, event: &Event) -> Result<(), AppError> {
         sqlx::query(
             r#"

indexer/src/handlers.rs

@@ -597,6 +597,21 @@ pub async fn get_performance_history(
     Ok(Json(serde_json::json!({ "hours": rows })))
 }
 
+/// GET /performance/bottlenecks — slow queries + index usage analysis.
+pub async fn get_performance_bottlenecks(
+    State(state): State<AppState>,
+) -> Result<Json<serde_json::Value>, AppError> {
+    let (slow_queries, index_usage) = tokio::join!(
+        state.database.get_slow_queries(10),
+        state.database.get_index_usage(),
+    );
+    Ok(Json(serde_json::json!({
+        "slow_queries": slow_queries.unwrap_or_default(),
+        "index_usage":  index_usage.unwrap_or_default(),
+        "cache":        state.cache_service.get_stats_snapshot().await,
+    })))
+}
+
 // =============================================================================
 // Analytics Handlers
 // =============================================================================

indexer/src/main.rs

@@ -294,6 +294,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .route("/performance/alerts", get(get_performance_alerts))
         .route("/performance/record", post(record_performance_sample))
         .route("/performance/history", get(get_performance_history))
+        .route("/performance/bottlenecks", get(get_performance_bottlenecks))
         // Compliance
         .route("/compliance/check", post(run_compliance_check))
         .route("/compliance/status/:address", get(get_compliance_status))

scripts/perf-analyze.sh

@@ -60,6 +60,14 @@ API_METRICS=$(curl -sf "${API_BASE}/health/metrics" 2>/dev/null || echo "unavail
 log "$API_METRICS"
 REPORT[api_metrics]="$API_METRICS"
 
+# ── 3b. APM bottleneck report ─────────────────────────────────────────────────
+log ""
+log "## APM Bottleneck Report (slow queries + index usage + cache)"
+sep
+APM_BOTTLENECKS=$(curl -sf "${API_BASE}/performance/bottlenecks" 2>/dev/null || echo "unavailable")
+log "$APM_BOTTLENECKS"
+REPORT[apm_bottlenecks]="$APM_BOTTLENECKS"
+
 # ── 4. Docker container resource usage ───────────────────────────────────────
 log ""
 log "## Container Resource Usage"