Close authorization gaps around RPC retries, fee quotes, and chain interactions in `src/starknet/client.ts`

[Jagadeeshftw]

Description

The current behavior needs an explicit security boundary so privilege checks cannot drift. src/starknet/client.ts owns RPC retries, fee quotes, and chain interactions, but the current behavior does not yet define the contract tightly enough for safe maintenance. Design the change so the runtime path, tests, and docs all describe the same behavior.

Requirements and context

• Keep the contract specific to src/starknet/client.ts and its existing callers.
• Add coverage for the success path and the failure or boundary path relevant to this issue.
• Preserve compatibility where older callers or existing tests already rely on the current shape.
• Keep the change easy to review and small enough for one focused PR.

Suggested execution

Fork the repo and create a branch

git checkout -b starknet-client-security-187

Implement changes

• Update/Write: src/starknet/client.ts
• Write comprehensive tests: src/starknet/client.test.ts
• Add documentation: docs/starknet/client.md
• Keep any new helper names consistent with the rest of src/

Test and commit

• Run pnpm test
• Run pnpm lint
• Add a note for any edge cases that are intentionally out of scope

Example commit message

security: tighten authorization and sensitive-data handling

Guidelines

• WCAG 2.1 AA is not relevant here; keep the focus on correctness and maintainability.
• Prefer a narrow, well-documented fix over a broad refactor.
• Timeframe: 96 hours

[devOgazi]

@devOgazi has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hello, I'm interested in resolving this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @devOgazi to this issue.

[drips-wave]

Congratulations, @devOgazi! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

🧑‍💻 @devOgazi: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[Jagadeeshftw]

Thanks for applying here. Please also join our Telegram group here: https://t.me/+vTbe0hOUKrFhNTJl. It helps us keep communication clear while we review contributions.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

@devOgazi's PR #543 was approved and merged by @Jagadeeshftw.

🏆 @devOgazi: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (258 total points). Track your full progress on GrantFox.

👏 Great work, @devOgazi! Keep contributing to Stellopay.