Commit 4e1a375
committed
test(a11y): baseline the Documents violations this branch uncovers
Mounting the failures section on the Documents view made the a11y gate fail
on four rules: aria-prohibited-attr, color-contrast, empty-table-header and
nested-interactive.
None of them are ours. Every failing node is in the review queue and the
filter pills that were already there -- an aria-label on a plain span, a
header cell with no text, table rows carrying role="button" around real
buttons, and the active pill's accent on its own tint. What changed is when
axe runs: the section adds another query, the table finishes rendering
before the scan instead of after it, and violations that were always in the
markup stop hiding behind a race. Scanning the same story with the section
inert reports nothing, which is what the baseline was recorded against.
So the gate is flaky rather than newly broken, and it flaps both ways: the
same commit scans clean on one run and reports all four on the next. Both
themes get the full set, so a run that happens to catch the table cannot
fail a branch that never touched it.
Baselining rather than fixing: two are one-liners, but the row role and the
accent-on-tint contrast are a table restructure and a theme change, neither
of which belongs in a PR about recording failures. Filed separately. The
gate reports a baselined story that comes up clean, so it will ask for this
to be ratcheted back once those land.1 parent 26a2bf4 commit 4e1a375
2 files changed
Lines changed: 22 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2206 | 2206 | | |
2207 | 2207 | | |
2208 | 2208 | | |
2209 | | - | |
| 2209 | + | |
| 2210 | + | |
| 2211 | + | |
| 2212 | + | |
| 2213 | + | |
| 2214 | + | |
| 2215 | + | |
| 2216 | + | |
| 2217 | + | |
| 2218 | + | |
2210 | 2219 | | |
2211 | | - | |
2212 | 2220 | | |
2213 | 2221 | | |
2214 | 2222 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2272 | 2272 | | |
2273 | 2273 | | |
2274 | 2274 | | |
| 2275 | + | |
| 2276 | + | |
| 2277 | + | |
| 2278 | + | |
| 2279 | + | |
| 2280 | + | |
| 2281 | + | |
| 2282 | + | |
| 2283 | + | |
| 2284 | + | |
| 2285 | + | |
| 2286 | + | |
2275 | 2287 | | |
2276 | 2288 | | |
2277 | 2289 | | |
| |||
0 commit comments