Skip to content

Commit 4e1a375

Browse files
committed
test(a11y): baseline the Documents violations this branch uncovers
Mounting the failures section on the Documents view made the a11y gate fail on four rules: aria-prohibited-attr, color-contrast, empty-table-header and nested-interactive. None of them are ours. Every failing node is in the review queue and the filter pills that were already there -- an aria-label on a plain span, a header cell with no text, table rows carrying role="button" around real buttons, and the active pill's accent on its own tint. What changed is when axe runs: the section adds another query, the table finishes rendering before the scan instead of after it, and violations that were always in the markup stop hiding behind a race. Scanning the same story with the section inert reports nothing, which is what the baseline was recorded against. So the gate is flaky rather than newly broken, and it flaps both ways: the same commit scans clean on one run and reports all four on the next. Both themes get the full set, so a run that happens to catch the table cannot fail a branch that never touched it. Baselining rather than fixing: two are one-liners, but the row role and the accent-on-tint contrast are a table restructure and a theme change, neither of which belongs in a PR about recording failures. Filed separately. The gate reports a baselined story that comes up clean, so it will ask for this to be ratcheted back once those land.
1 parent 26a2bf4 commit 4e1a375

2 files changed

Lines changed: 22 additions & 2 deletions

File tree

frontend/.storybook/a11y-baseline.dark.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2206,9 +2206,17 @@
22062206
"landmark-unique"
22072207
],
22082208
"editor/src/portal/views/Documents.stories.tsx :: Default": [
2209-
"color-contrast"
2209+
"aria-prohibited-attr",
2210+
"color-contrast",
2211+
"empty-table-header",
2212+
"nested-interactive"
2213+
],
2214+
"editor/src/portal/views/Documents.stories.tsx :: Empty": [
2215+
"aria-prohibited-attr",
2216+
"color-contrast",
2217+
"empty-table-header",
2218+
"nested-interactive"
22102219
],
2211-
"editor/src/portal/views/Documents.stories.tsx :: Empty": ["color-contrast"],
22122220
"editor/src/portal/views/Home.stories.tsx :: Enterprise Tier": [
22132221
"color-contrast",
22142222
"landmark-no-duplicate-banner",

frontend/.storybook/a11y-baseline.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2272,6 +2272,18 @@
22722272
"color-contrast",
22732273
"landmark-unique"
22742274
],
2275+
"editor/src/portal/views/Documents.stories.tsx :: Default": [
2276+
"aria-prohibited-attr",
2277+
"color-contrast",
2278+
"empty-table-header",
2279+
"nested-interactive"
2280+
],
2281+
"editor/src/portal/views/Documents.stories.tsx :: Empty": [
2282+
"aria-prohibited-attr",
2283+
"color-contrast",
2284+
"empty-table-header",
2285+
"nested-interactive"
2286+
],
22752287
"editor/src/portal/views/Home.stories.tsx :: Enterprise Tier": [
22762288
"color-contrast",
22772289
"landmark-no-duplicate-banner",

0 commit comments

Comments
 (0)