Commit 7337fc2
authored
Wrap IndexedDB-restored files before upload so Safari sends their bytes (#7889)
On Safari and DuckDuckGo 26.5+, a file read back from IndexedDB uploads
as an empty body (Content-Length 0). The server rejects the request
before any controller runs, so a policy run on that file never starts
and no failure is recorded. Chrome is unaffected.
The file comes out of IndexedDB with a disk path attached. WebKit
uploads any file with a path by reading it from disk, and since 26.5 the
process doing the upload isn't allowed to read that path. It gets
nothing back and sends empty bytes instead of an error.
**Fix:** wrap the file in a fresh `File` before putting it in the form.
The wrapper has no path, so every browser uploads it through the blob
route. No bytes are copied.
This is a patch while we wait for the upstream fix:
https://bugs.webkit.org/show_bug.cgi?id=319985. It stays correct after
that fix lands, whatever shape it takes, because the wrapper never
depends on the path route.
Verified in Safari 26.6.2 with a probe page: the raw IndexedDB file
uploads 0 bytes, the wrapped file uploads the full body, including after
the stored record is rewritten or deleted and with several uploads in
parallel.
Only the policy run path is covered here. The other upload sites share
the exposure and are tracked separately.1 parent e2a0a58 commit 7337fc2
4 files changed
Lines changed: 82 additions & 1 deletion
File tree
- frontend/editor/src
- core/utils
- proprietary/services
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
21 | 30 | | |
22 | 31 | | |
23 | 32 | | |
| |||
45 | 54 | | |
46 | 55 | | |
47 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
48 | 68 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
| 41 | + | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
| |||
0 commit comments