Skip to content

Commit c898eb8

Browse files
committed
Move CODEOWNERS to review teams and drop DarioGii
1 parent fa11034 commit c898eb8

4 files changed

Lines changed: 24 additions & 16 deletions

File tree

.github/CODEOWNERS

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,28 @@
1-
# All PRs must be approved by Frooodle or Ludy87
2-
* @Frooodle @Ludy87 @jbrunton96 @ConnorYoh
1+
# Review ownership is assigned to teams where possible.
2+
# Teams can only contain org members, so outside collaborators are listed by hand.
3+
#
4+
# @Stirling-Tools/maintainers - Frooodle, jbrunton96, ConnorYoh
5+
# @Stirling-Tools/backend-reviewers - Frooodle, jbrunton96, ConnorYoh
6+
# @Stirling-Tools/frontend-reviewers - Frooodle, jbrunton96, ConnorYoh, reecebrowne, EthanHealy01
7+
# @Stirling-Tools/devops-reviewers - Frooodle, jbrunton96, ConnorYoh
8+
# @Stirling-Tools/all - all of the above
9+
#
10+
# Outside collaborators (need Write access to count as owners): @Ludy87 @balazs-szucs
311

4-
# Backend
5-
/app/** @DarioGii @Frooodle @Ludy87 @jbrunton96 @ConnorYoh @balazs-szucs
12+
# Default owners for everything
13+
* @Stirling-Tools/maintainers @Ludy87
614

7-
#V2 frontend
8-
/frontend/** @reecebrowne @ConnorYoh @EthanHealy01 @jbrunton96 @Frooodle @balazs-szucs
9-
/app/core/src/main/resources/static/** @reecebrowne @ConnorYoh @EthanHealy01 @jbrunton96 @Frooodle @Ludy87 @balazs-szucs
15+
# Backend
16+
/app/** @Stirling-Tools/backend-reviewers @Ludy87 @balazs-szucs
1017

11-
#V2 docker
12-
/docker/backend/** @Frooodle @Ludy87 @DarioGii
13-
/docker/frontend/** @reecebrowne @ConnorYoh @EthanHealy01 @jbrunton96 @Frooodle @Ludy87
14-
/docker/compose/** @reecebrowne @ConnorYoh @EthanHealy01 @DarioGii @jbrunton96 @Frooodle @Ludy87
18+
# V2 frontend
19+
/frontend/** @Stirling-Tools/frontend-reviewers @balazs-szucs
20+
/app/core/src/main/resources/static/** @Stirling-Tools/frontend-reviewers @Ludy87 @balazs-szucs
1521

22+
# V2 docker
23+
/docker/backend/** @Stirling-Tools/devops-reviewers @Ludy87
24+
/docker/frontend/** @Stirling-Tools/frontend-reviewers @Stirling-Tools/devops-reviewers @Ludy87
25+
/docker/compose/** @Stirling-Tools/frontend-reviewers @Stirling-Tools/devops-reviewers @Ludy87
1626

17-
#GHA (All users)
18-
/.github/** @reecebrowne @ConnorYoh @EthanHealy01 @DarioGii @jbrunton96 @Frooodle @Ludy87 @balazs-szucs
27+
# GHA (all users)
28+
/.github/** @Stirling-Tools/all @Ludy87 @balazs-szucs

.github/config/repo_devs.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
"LaserKaspar",
1212
"sbplat",
1313
"reecebrowne",
14-
"DarioGii",
1514
"ConnorYoh",
1615
"EthanHealy01",
1716
"jbrunton96",

.github/workflows/PR-Auto-Deploy-V2.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
fi
8787
fi
8888
else
89-
auth_users=("Frooodle" "sf298" "Ludy87" "LaserKaspar" "sbplat" "reecebrowne" "DarioGii" "ConnorYoh" "EthanHealy01" "jbrunton96" "balazs-szucs")
89+
auth_users=("Frooodle" "sf298" "Ludy87" "LaserKaspar" "sbplat" "reecebrowne" "ConnorYoh" "EthanHealy01" "jbrunton96" "balazs-szucs")
9090
is_auth=false; for u in "${auth_users[@]}"; do [ "$u" = "$PR_AUTHOR" ] && is_auth=true && break; done
9191
if [ "$is_auth" = true ]; then
9292
should=true

.github/workflows/PR-Demo-Comment-with-react.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ jobs:
5454
github.event.comment.user.login == 'Ludy87' ||
5555
github.event.comment.user.login == 'balazs-szucs' ||
5656
github.event.comment.user.login == 'reecebrowne' ||
57-
github.event.comment.user.login == 'DarioGii' ||
5857
github.event.comment.user.login == 'EthanHealy01' ||
5958
github.event.comment.user.login == 'jbrunton96' ||
6059
github.event.comment.user.login == 'ConnorYoh'

0 commit comments

Comments
 (0)