Don't register the placeholder command if the user has previously enabled PB

If an experienced user wants PB to be disabled, then it should be completely disabled

Author: Fallen-Breath

prime_backup/mcdr/command/disabled_command_helper.py

@@ -0,0 +1,42 @@
+from pathlib import Path
+
+from mcdreforged.api.all import PluginServerInterface, SimpleCommandBuilder, CommandSource, RColor
+
+from prime_backup import logger
+from prime_backup.config.config import Config
+from prime_backup.mcdr.text_components import TextComponents
+from prime_backup.utils import mcdr_utils
+
+
+class DisabledCommandHelper:
+	def __init__(self, server: PluginServerInterface, self_name: str):
+		self.config = Config.get()
+		self.logger = logger.get()
+
+		self.server = server
+		self.self_name = self_name
+		self.__mark_file = Path(server.get_data_folder()) / '.enabled_mark'
+
+	def on_disabled(self):
+		if self.__mark_file.exists():
+			return
+		self.__register_disabled_command()
+
+	def __register_disabled_command(self):
+		builder = SimpleCommandBuilder()
+
+		@builder.command(self.config.command.prefix)
+		def handle_root(source: CommandSource):
+			with source.preferred_language_context():
+				doc_url = mcdr_utils.tr('command.disabled.doc_url').to_plain_text()
+			mcdr_utils.reply_message(source, mcdr_utils.tr('command.disabled.disabled_by_config', self.self_name).set_color(RColor.yellow))
+			mcdr_utils.reply_message(source, mcdr_utils.tr('command.disabled.read_doc', self.self_name, TextComponents.url(doc_url)))
+
+		builder.register(self.server)
+
+	def on_enabled(self):
+		try:
+			if not self.__mark_file.exists():
+				self.__mark_file.write_bytes(b'')
+		except Exception as e:
+			self.logger.error('Failed to create enabled mark file at {}: {}'.format(self.__mark_file, e))

prime_backup/mcdr/mcdr_entrypoint.py

@@ -11,11 +11,11 @@
 from prime_backup.db.access import DbAccess
 from prime_backup.mcdr import mcdr_globals
 from prime_backup.mcdr.command.commands import CommandManager
+from prime_backup.mcdr.command.disabled_command_helper import DisabledCommandHelper
 from prime_backup.mcdr.crontab_manager import CrontabManager
 from prime_backup.mcdr.online_player_counter import OnlinePlayerCounter
 from prime_backup.mcdr.task_manager import TaskManager
-from prime_backup.mcdr.text_components import TextComponents
-from prime_backup.utils import misc_utils, mcdr_utils
+from prime_backup.utils import misc_utils
 
 config: Optional[Config] = None
 task_manager: Optional[TaskManager] = None
@@ -72,27 +72,18 @@ def init():
 		init_ok = is_enabled()
 		server.logger.debug('{} init done, init_ok={}'.format(self_name, init_ok))
 
-	def register_disabled_command():
-		from mcdreforged.api.all import SimpleCommandBuilder, CommandSource, RColor
-		builder = SimpleCommandBuilder()
-
-		@builder.command(config.command.prefix)
-		def handle_root(source: CommandSource):
-			with source.preferred_language_context():
-				doc_url = mcdr_utils.tr('command.disabled.doc_url').to_plain_text()
-			mcdr_utils.reply_message(source, mcdr_utils.tr('command.disabled.disabled_by_config', self_name).set_color(RColor.yellow))
-			mcdr_utils.reply_message(source, mcdr_utils.tr('command.disabled.read_doc', self_name, TextComponents.url(doc_url)))
-
-		builder.register(server)
-
 	global config, task_manager, command_manager, crontab_manager, online_player_counter
 	with handle_init_error():
 		config = server.load_config_simple(target_class=Config, failure_policy='raise')
 		set_config_instance(config)
+
+		disabled_command_helper = DisabledCommandHelper(server, self_name)
 		if not is_enabled():
 			server.logger.warning('{} is disabled by config'.format(self_name))
-			register_disabled_command()
+			disabled_command_helper.on_disabled()
 			return
+		else:
+			disabled_command_helper.on_enabled()
 
 		task_manager = TaskManager()
 		crontab_manager = CrontabManager(task_manager)