fix(runner/vod): Apply suggestions from comments

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: joschahenningsen

runner/handlers.go

@@ -63,5 +63,5 @@ func (r *Runner) HandleVOD(_ context.Context, req *protobuf.HandleVODRequest) (*
 	jID := r.RunAction(a, data, r.log.With("stream_id", req.GetStreamId(), "stream_version", req.GetVersion(), "input", req.GetFilepath()))
 	r.log.Info("job added", "ID", jID)
 
-	return &protobuf.HandleVODResponse{}, nil
+	return &protobuf.HandleVODResponse{JobId: ptr.Take(jID)}, nil
 }

runner/pkg/actions/mkvod.go

@@ -33,9 +33,17 @@ func MkVOD(ctx context.Context, logger *slog.Logger, notify chan *protobuf.Notif
 	}
 	var recording string
 	if rec, ok := d["recording"]; ok {
-		recording = rec.(string)
+		if recStr, ok := rec.(string); ok {
+			recording = recStr
+		} else {
+			return AbortingError(fmt.Errorf("recording value is not a string"))
+		}
 	} else if dir, ok := d["recordingDir"]; ok {
-		recording = path.Join(dir.(string), "playlist.m3u8")
+		if dirStr, ok := dir.(string); ok {
+			recording = path.Join(dirStr, "playlist.m3u8")
+		} else {
+			return AbortingError(fmt.Errorf("recordingDir value is not a string"))
+		}
 	} else {
 		return AbortingError(fmt.Errorf("no recording or recordingDir in context"))
 	}
@@ -52,7 +60,11 @@ func MkVOD(ctx context.Context, logger *slog.Logger, notify chan *protobuf.Notif
 	// Check if re-encoding is needed
 	var reencode bool
 	if needsReencode, ok := d["needsReencode"]; ok {
-		reencode = needsReencode.(bool)
+		if reencodeVal, ok := needsReencode.(bool); ok {
+			reencode = reencodeVal
+		} else {
+			return AbortingError(fmt.Errorf("needsReencode is not a bool"))
+		}
 	}
 
 	var videoCodec, audioCodec string