Commit 0298c90
test(query-core): keep setQueryData typecheck green on TypeScript 5.4 (#10985)
Under TypeScript 5.4, `NoInfer<T>` can't match an inline object literal
against the value branch of the `Updater` union in `setQueryData`, so it
falls back to the function branch and reports the literal as excess
properties (TS2353). TS >= 5.5 handles it correctly.
This surfaces in the `test:types:ts54` legacy typecheck via the project
reference chain (e.g. react-query-persist-client / react-query-devtools
build query-core's test sources). It is normally masked by the Nx remote
cache and only re-runs — and fails — when a dependent package's type
inputs change, so it can land on `main` unnoticed.
Annotate the value before passing it to `setQueryData` to sidestep the
5.4 limitation while preserving the assertions. Verified across TS
5.4–6.0.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent 4eb0ed9 commit 0298c90
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | | - | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
287 | 292 | | |
288 | 293 | | |
289 | 294 | | |
| |||
0 commit comments