Incorrect fall damage calculation/vanilla disparity

[RyeWollschlaeger]

When jumping off onto the ground from a ledge that's 2.5 blocks taller (2 blocks and 1 slab), you take 0.5 hearts of damage, instead you shouldn't take any damage at all

[mudkipdev]

@RyeWollschlaeger @hapily04

some more fall damage inaccuracies:

• fall damage is not canceled when falling onto a slime block or sweet berry bush
• fall damage is not reduced (should be 0.2x) when falling onto a hay bale or honey block
• fall distance is not reduced (should be 0.5x) when falling onto a bed
• (!!!) you take fall damage if you jump into a body of water and then sink all the way down

Source: https://minecraft.wiki/w/Damage#Fall_damage

[RyeWollschlaeger]

@mudkipdev

• (!!!) you take fall damage if you jump into a body of water and then sink all the way down

That one was actually mentioned in another issue, TogAr2 said that since it is a simple enough fix, he believes the developer should be responsible for adding water fall damage prevenrion, and that a proper implementation would require working on MinestomFluids. Nonetheless, I'd like to mention that this also affects the water of any waterlogged blocks, such as waterlogged stairs, waterlogged slabs, kelp, sea grass, etc.

[mudkipdev]

What is the reason? I thought it would be as simple as not counting fall distance when swimming.

[RyeWollschlaeger]

Just going off of what TogAr said in #46