Refactor VPN Permission Handling (Android 14+) - #16
Closed
zerox80 wants to merge 1 commit into
Closed
Conversation
ialexbond
added a commit
to ialexbond/TrustTunnelClientForWindows
that referenced
this pull request
Apr 20, 2026
TrustTunnel#14 font-semibold → token (24 файла): - Все font-semibold в components/ заменены на font-[var(--font-weight-semibold)] - Единый источник правды для font-weight через дизайн-токены TrustTunnel#15 input font-size consistency (4 файла): - ActionInput, ActionPasswordInput, NumberInput, Select: text-base → text-sm - Все input-компоненты теперь единообразно используют 12px (text-sm) TrustTunnel#16 colors.ts удалён (16 файлов): - Все 16 импортов colors.ts мигрированы на CSS-токены: successBg → var(--color-status-connected-bg) warningBg → var(--color-status-connecting-bg) dangerBg → var(--color-status-error-bg) dropdownShadow → var(--shadow-lg) *Glow → "none" (deprecated) accent* → inline rgba (нет токенов) - gui-app/src/shared/ui/colors.ts удалён TrustTunnel#17 hardcoded rgba(): - Ключевые rgba() заменены на CSS-токены в рамках миграции colors.ts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Hello, @zerox80, thanks for your effort and sorry for a long delay. These changes requires a big cleanup - some things are unrelated to the PR's description and solved problem, even some essential links are changed. Moreover, please open the issue for discussion first. Because this is a very minor problem but with a relatively big diff and reviewing such changes could take significant time. So this might not be accepted even after cleaning up the PR. I'll close this for now, still it at least requires a big cleanup and these changes should be discussed first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor VPN Permission Handling (Android 14+)
Description
Updates
VpnPrepareActivityto use the modern AndroidX Activity Result API (registerForActivityResult) instead of the deprecatedstartActivityForResult. This also improves compatibility with Android 13/14 for notification permissions.Changes
VpnPrepareActivity.kt: Rewritten to useActivityResultContracts.AndroidManifest.xml/libs.versions.toml: Added necessary dependencies.Justification
"changes to deprecated classes".
Modernizing the code to avoid deprecated APIs ensures better long-term maintenance and compatibility with newer Android versions.
How to test