CI

Changed limit-service to TypeScript and moved Ghost's queries out of it #55842

Sign in to view logs

Triggered via pull request September 3, 2026 15:37

rob-ghost

opened #30511

chore/limit-service-modernise

Status Cancelled

Total duration 14m 41s

Artifacts 23

ci.yml

on: pull_request

Build Docker Images

Matrix: job_unit-tests

Matrix: job_acceptance-tests

Admin tests - Chrome

Build E2E Public App Assets

Matrix: App Playwright Acceptance Tests

Matrix: job_legacy-tests

Check app version bump

Check migration integrity

Stripe fixture checks

Performance tests

Matrix: job_e2e_tests

Performance tests (production image)

Build Ghost-CLI archive

Matrix: publish_public_apps

Matrix: job_ghost-cli

Publish Ghost to npm

All required tests passed or skipped

Create GitHub Release

Trigger docker-library-ghost update

Notify release failure

Annotations

49 errors, 19 warnings, and 3 notices

Admin tests - Chrome

Process completed with exit code 1.

[chromium] › test/e2e/format-shortcuts.test.ts:56:9 › Editor keyboard shortcuts › text formatting shortcuts › link: koenig/koenig-lexical/test/utils/e2e.ts#L110

1) [chromium] › test/e2e/format-shortcuts.test.ts:56:9 › Editor keyboard shortcuts › text formatting shortcuts › link Error: expect(received).toEqual(expected) // deep equality - Expected - 1 + Received + 4 <p dir="ltr"> - <a dir="ltr" href="https://example.com" rel="noreferrer"> + <a + dir="ltr" + href="https://source.ghost.io/remote-works-impact-on-job-markets/" + rel="noreferrer"> <span data-lexical-text="true">test</span> </a> </p> at ../utils/e2e.ts:110 108 | ignoreCardCaptionContents 109 | }); > 110 | expect(actual).toEqual(expected); | ^ 111 | } 112 | 113 | export function prettifyHTML(string, options = {}) { at assertHTML (/home/runner/work/Ghost/Ghost/koenig/koenig-lexical/test/utils/e2e.ts:110:20) at /home/runner/work/Ghost/Ghost/koenig/koenig-lexical/test/e2e/format-shortcuts.test.ts:69:13

E2E Tests (Main 7/10)

Process completed with exit code 1.

E2E Tests (Main 5/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 9/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 6/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 4/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Analytics 1/2)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Analytics 2/2)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 10/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 10/10)

The operation was canceled.

E2E Tests (Main 2/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 2/10)

Process completed with exit code 1.

E2E Tests (Main 1/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 1/10)

The operation was canceled.

E2E Tests (Main 8/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 8/10)

Process completed with exit code 1.

E2E Tests (Main 3/10)

The strategy configuration was canceled because "job_e2e_tests.Main_main_false_7_10" failed

E2E Tests (Main 3/10)

Process completed with exit code 1.

Ghost-CLI tests (clean-install, Node 22.23.1)

Process completed with exit code 1.

Acceptance tests (Node 24.20.0, mysql8)

Process completed with exit code 1.

[integration] test/integration/services/webhook-request.test.js > Webhook delivery > using request-external (allowWebhookInternalIPs: false) > delivers webhook payload via POST: ghost/core/test/integration/services/webhook-request.test.js#L30

TypeError: LimitService is not a constructor ❯ test/integration/services/webhook-request.test.js:30:30

[integration] test/integration/services/webhook-request.test.js > Webhook delivery > using @tryghost/request (allowWebhookInternalIPs: true) > delivers webhook payload via POST: ghost/core/test/integration/services/webhook-request.test.js#L30

TypeError: LimitService is not a constructor ❯ test/integration/services/webhook-request.test.js:30:30

Ghost-CLI tests (clean-install, Node 24.20.0)

Process completed with exit code 1.

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > onError > logs a structured error for failed webhook deliveries: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > includes the event name in the JSON payload: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > uses the request payload and a timestamp to generate the hash in the signature header: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > includes a signature header when a webhook has a secret: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > triggers payload handler when there are hooks registered for an event: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > does not trigger payload handler when there are hooks registered for an event, but the custom integrations limit is active: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > does not trigger payload handler when there are no hooks registered for an event: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > constructor > uses base request library when internal IPs enabled in config: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > constructor > uses the external request library when internal IPs disabled in config: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/limits.test.js > Limit Service Init > handles limit-service incorrect usage errors gracefully with a warning: ghost/core/test/unit/server/services/limits.test.js#L37

IncorrectUsageError: We detected a misuse. Please read the stack trace. ❯ test/unit/server/services/limits.test.js:37:29 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { statusCode: 400, errorType: 'IncorrectUsageError', level: 'critical', id: 'b36d81e8-8d37-41b2-85db-fb5dc41725f5', context: undefined, help: undefined, errorDetails: undefined, code: null, property: null, redirect: null, hideStack: false }

Acceptance tests (Node 22.23.1, mysql8)

Process completed with exit code 1.

[integration] test/integration/services/webhook-request.test.js > Webhook delivery > using request-external (allowWebhookInternalIPs: false) > delivers webhook payload via POST: ghost/core/test/integration/services/webhook-request.test.js#L30

TypeError: LimitService is not a constructor ❯ test/integration/services/webhook-request.test.js:30:30

[integration] test/integration/services/webhook-request.test.js > Webhook delivery > using @tryghost/request (allowWebhookInternalIPs: true) > delivers webhook payload via POST: ghost/core/test/integration/services/webhook-request.test.js#L30

TypeError: LimitService is not a constructor ❯ test/integration/services/webhook-request.test.js:30:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > onError > logs a structured error for failed webhook deliveries: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > includes the event name in the JSON payload: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > uses the request payload and a timestamp to generate the hash in the signature header: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > includes a signature header when a webhook has a secret: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > triggers payload handler when there are hooks registered for an event: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > does not trigger payload handler when there are hooks registered for an event, but the custom integrations limit is active: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > trigger > does not trigger payload handler when there are no hooks registered for an event: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > constructor > uses base request library when internal IPs enabled in config: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/webhooks/trigger.test.js > Webhook Service > constructor > uses the external request library when internal IPs disabled in config: ghost/core/test/unit/server/services/webhooks/trigger.test.js#L40

TypeError: LimitService is not a constructor ❯ test/unit/server/services/webhooks/trigger.test.js:40:30

[unit] test/unit/server/services/limits.test.js > Limit Service Init > handles limit-service incorrect usage errors gracefully with a warning: ghost/core/test/unit/server/services/limits.test.js#L37

IncorrectUsageError: We detected a misuse. Please read the stack trace. ❯ test/unit/server/services/limits.test.js:37:29 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Serialized Error: { statusCode: 400, errorType: 'IncorrectUsageError', level: 'critical', id: 'dcef5aba-5d6c-46c9-8878-3cfe8d9d238b', context: undefined, help: undefined, errorDetails: undefined, code: null, property: null, redirect: null, hideStack: false }

Canceling since a higher priority waiting request for chore/limit-service-modernise exists

All required tests passed or skipped

Process completed with exit code 1.

'base' input parameter is ignored when action is triggered by pull request event

Lint: e2e/tests/public/comment-replies.test.ts#L24

Duplicate beforeEach in describe block

Lint: e2e/tests/global.teardown.ts#L4

Test has no assertions

Lint: e2e/tests/global.setup.ts#L6

Test has no assertions

Lint: e2e/tests/admin/two-factor-auth.test.ts#L74

Use toHaveLength() instead

Lint: e2e/tests/admin/two-factor-auth.test.ts#L61

Use toHaveLength() instead

Lint: e2e/tests/admin/analytics/overview.test.ts#L25

Use toHaveCount() instead

Lint: e2e/helpers/pages/public/public-page.ts#L56

Prefer locator methods instead of page methods

Lint: e2e/helpers/pages/admin/posts/posts-page.ts#L250

Prefer locator methods instead of page methods

Lint: e2e/helpers/pages/admin/posts/post/post-editor-page.ts#L122

Unexpected use of { force: true } option

Lint: e2e/helpers/pages/admin/analytics/analytics-web-traffic-page.ts#L127

Unexpected use of { force: true } option

Acceptance tests (Node 24.20.0, mysql8)

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: szenius/set-timezone@1f9716b0f7120e344f0c62bb7b1ee98819aefd42. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Unit tests (Node 24.20.0)

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: szenius/set-timezone@1f9716b0f7120e344f0c62bb7b1ee98819aefd42. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Unit tests (Node 24.20.0)

Unit tests attempt 2 failed — retrying

Unit tests (Node 24.20.0)

Unit tests attempt 1 failed — retrying

Acceptance tests (Node 22.23.1, mysql8)

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: szenius/set-timezone@1f9716b0f7120e344f0c62bb7b1ee98819aefd42. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Unit tests (Node 22.23.1)

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: szenius/set-timezone@1f9716b0f7120e344f0c62bb7b1ee98819aefd42. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Unit tests (Node 22.23.1)

Unit tests attempt 2 failed — retrying

Unit tests (Node 22.23.1)

Unit tests attempt 1 failed — retrying

🎭 Playwright Run Summary

4 passed (6.4s)

🎭 Playwright Run Summary

1 flaky [chromium] › test/e2e/format-shortcuts.test.ts:56:9 › Editor keyboard shortcuts › text formatting shortcuts › link 27 skipped 760 passed (2.5m)

Merge Reports

To view the Playwright report locally, run:

Artifacts

Produced during runtime

Name	Size	Digest
TryGhost~Ghost~640QAI.dockerbuild	44 KB	`sha256:cb941e6e8b8654a7389cfac13b878706a53fffcc2b068a265278ae5e277ace2d`
TryGhost~Ghost~BVVPBM.dockerbuild	24.5 KB	`sha256:dc8d9bb38bf0e19df58264ffab7d209e30e57e2c2bfe3ff7c8040d8bcab089ee`
TryGhost~Ghost~OXCVFP.dockerbuild	73.3 KB	`sha256:aa046620ce1118472f89902aaa1ff4faf48f027abf0e5015e26c5dfaf79fd8cc`
TryGhost~Ghost~P8K34Y.dockerbuild	42.4 KB	`sha256:1cbf8687de3567bf9cb9f2ce8ee57cfe5d9dce57a64e9277c4511fc94c0d6237`
activitypub-playwright-report	250 KB	`sha256:a75dbc0f2fb83bbf8b4dc857a701219728c7326d583c9891277cad103558fe62`
admin-build Expired	18.7 MB	`sha256:2dc439fc6bd8b6b9c050f31f5b49be6d117861ffd1a9a5ad385a92d31952e994`
admin-build-cd	29.9 MB	`sha256:0bd4573d82ba86cb8c304013f7504f15e57854f29409f050ef4cf93099f74482`
blob-report-Main-2 Expired	25.6 KB	`sha256:385ecf541b428b7ff43cd296c3ecff9f97e9891278509b93cf87dd9bf46738e7`
blob-report-Main-7 Expired	25.6 KB	`sha256:d6b94d794929873eab814af3097f402177aa0444df807221134ea1f2d112ae3b`
blob-report-Main-8 Expired	25.8 KB	`sha256:2551b2c339035fdbda4df8321f97ed9e2fc0692ce9e603afc4e095cb920d8df7`
comments-ui-playwright-report	295 KB	`sha256:fdfdb0785cebf94521503358b01445bfae93b7c7126a987c3d0f3bbe967a7c7e`
e2e-public-apps Expired	2.15 MB	`sha256:2c129389837679a13def19c85065df87a3e4f2ceb74616e48242a17e91306add`
ghost-npm-tarball	22.5 MB	`sha256:037643fecf6276ca9ad806a801f19a82788ec45b6db620eddedd97f59bd3e342`
ghost-release-tarball	22.5 MB	`sha256:84736e81d761803f840980e3ff102ea7bb3f97c4f1d1642e96ecc0204add08ad`
image-report	17.6 KB	`sha256:88526d7d725ee3bc92d9394983ec117c638e93c9359cd2775be2f7d3420b8e15`
kg-unsplash-selector-playwright-report	214 KB	`sha256:be7ab86547da92b3ef281f87f5360eec86c112df728928364f539d4e2734fda1`
koenig-lexical-playwright-report	1.74 MB	`sha256:41d24cce3f4b392b2c9b8d743de1d765d291e62b2dc743f30f21851093451dfa`
playwright-report	686 KB	`sha256:09b67d838601e785b975d45ea0651b56bdb932bbd423e8bfc106e68891a60fc5`
signup-form-playwright-report	221 KB	`sha256:3c7d8413a6bbfb65d46de23c44b551f5f3ebba33e9efed815ae877567578a0a5`
test-results	25.1 KB	`sha256:206403f4dffdc0708ed2a1c63717f151dde3c7c973c5aea07e45cbb505139f81`
test-results-Main-2	25.1 KB	`sha256:246410c39e1e480ea9c576579f2a6da38e57b276ab93ab61a1d70bf3be25952b`
test-results-Main-7	25.1 KB	`sha256:8a9c46526c64d215b237210ebca3d7a749158e03d4c411c20a1d6ba73bc66fa6`
test-results-Main-8	25.1 KB	`sha256:7f858e0c461fc65ed5eeb29f26cd645cd807cfe994e447004dbd577697d3bbc8`