1.)
First of all I want to thank you for this great library.
Since decades I used Easyhook in my projects.
But now I found a very ugly bug in Easyhook.
I'am hooking a third party application that is programmed very stupidly.
It creates each time a new thread to call the function that I have hooked.
Easyhook works correctly for the first approx 100 to 200 calls.
But then Easyhook does not hook the function anymore.
It becomes random if it hooks the function or not. Sometimes yes, sometimes not.
I could not find a solution for this severe problem.
I asked Copilot, and it recommended me to try MinHook.
And in deed it works without any problem.
Additionally your code is much more lightweight than EasyHook that requires three LIB files of 3 Megabyte.
I'am fascinated of your hook library.
Easy to use, small and fast and works perfectly.
2.)
The only thing that I have to critizise in your code is that you do not write ONE SINGLE comment!
Put yourself into a person who reads your code.
You have a function ProcessThreadIPs
WTF is a thread IP ??
I know IP addresses, but I never heard that threads have IP addresses.
What does patchAbove mean ?
Above what ?
What does HDE mean ?
Where are the comments explaining what your functions do ?
A code completely free of comments is not a well written code !
1.)
First of all I want to thank you for this great library.
Since decades I used Easyhook in my projects.
But now I found a very ugly bug in Easyhook.
I'am hooking a third party application that is programmed very stupidly.
It creates each time a new thread to call the function that I have hooked.
Easyhook works correctly for the first approx 100 to 200 calls.
But then Easyhook does not hook the function anymore.
It becomes random if it hooks the function or not. Sometimes yes, sometimes not.
I could not find a solution for this severe problem.
I asked Copilot, and it recommended me to try MinHook.
And in deed it works without any problem.
Additionally your code is much more lightweight than EasyHook that requires three LIB files of 3 Megabyte.
I'am fascinated of your hook library.
Easy to use, small and fast and works perfectly.
2.)
The only thing that I have to critizise in your code is that you do not write ONE SINGLE comment!
Put yourself into a person who reads your code.
You have a function
ProcessThreadIPsWTF is a thread IP ??
I know IP addresses, but I never heard that threads have IP addresses.
What does
patchAbovemean ?Above what ?
What does HDE mean ?
Where are the comments explaining what your functions do ?
A code completely free of comments is not a well written code !