refactor(26.3)!: Remove BalmHooks#blockGrowFeature() due to limited use cases that would be better covered by a bidirectional event mapper

Author: BlayTheNinth

common/src/main/java/net/blay09/mods/balm/platform/BalmHooks.java

@@ -15,15 +15,10 @@
 import net.minecraft.world.item.ItemStackTemplate;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.state.BlockState;
-import net.minecraft.world.level.levelgen.feature.ConfiguredFeature;
 import net.minecraft.world.phys.BlockHitResult;
 import org.jspecify.annotations.Nullable;
 
 public interface BalmHooks {
-    /**
-     * Forge fires SaplingGrowTreeEvent, Fabric NOPs
-     */
-    boolean blockGrowFeature(Level level, RandomSource random, BlockPos pos, @Nullable Holder<ConfiguredFeature<?, ?>> holder);
 
     /**
      * Forge adds player-sensitive version, Fabric uses normal version

fabric/src/main/java/net/blay09/mods/balm/fabric/platform/internal/FabricBalmHooks.java

@@ -23,7 +23,6 @@
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.entity.BlockEntity;
 import net.minecraft.world.level.block.state.BlockState;
-import net.minecraft.world.level.levelgen.feature.ConfiguredFeature;
 import net.minecraft.world.level.material.Fluid;
 import net.minecraft.world.level.material.Fluids;
 import net.minecraft.world.phys.BlockHitResult;
@@ -33,11 +32,6 @@
 
 public class FabricBalmHooks implements BalmHooks {
 
-    @Override
-    public boolean blockGrowFeature(Level level, RandomSource random, BlockPos pos, @Nullable Holder<ConfiguredFeature<?, ?>> holder) {
-        return true;
-    }
-
     @Override
     public boolean growCrop(ItemStack itemStack, Level level, BlockPos pos, @Nullable Player player) {
         return BoneMealItem.growCrop(itemStack, level, pos);

forge/src/main/java/net/blay09/mods/balm/forge/platform/internal/ForgeBalmHooks.java

@@ -15,7 +15,6 @@
 import net.minecraft.world.item.*;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.state.BlockState;
-import net.minecraft.world.level.levelgen.feature.ConfiguredFeature;
 import net.minecraft.world.phys.BlockHitResult;
 import net.minecraftforge.common.util.Result;
 import net.minecraftforge.event.ForgeEventFactory;
@@ -41,11 +40,6 @@ private void furnaceFuelBurnTime(FurnaceFuelBurnTimeEvent event) {
         }
     }
 
-    @Override
-    public boolean blockGrowFeature(Level level, RandomSource random, BlockPos pos, @Nullable Holder<ConfiguredFeature<?, ?>> holder) {
-        return !ForgeEventFactory.blockGrowFeature(level, random, pos, holder).getResult().equals(Result.DENY);
-    }
-
     @Override
     public boolean growCrop(ItemStack itemStack, Level level, BlockPos pos, @Nullable Player player) {
         if (player != null) {

neoforge/src/main/java/net/blay09/mods/balm/neoforge/platform/internal/NeoForgeBalmHooks.java

@@ -14,7 +14,6 @@
 import net.minecraft.world.item.*;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.state.BlockState;
-import net.minecraft.world.level.levelgen.feature.ConfiguredFeature;
 import net.minecraft.world.phys.BlockHitResult;
 import net.neoforged.neoforge.common.NeoForge;
 import net.neoforged.neoforge.common.util.FakePlayer;
@@ -41,11 +40,6 @@ private void furnaceFuelBurnTime(FurnaceFuelBurnTimeEvent event) {
         }
     }
 
-    @Override
-    public boolean blockGrowFeature(Level level, RandomSource random, BlockPos pos, @Nullable Holder<ConfiguredFeature<?, ?>> holder) {
-        return !EventHooks.fireBlockGrowFeature(level, random, pos, holder).isCanceled();
-    }
-
     @Override
     public boolean growCrop(ItemStack itemStack, Level level, BlockPos pos, @Nullable Player player) {
         if (player != null) {