Skip to content

Commit db2c410

Browse files
committed
fix: Fix race condition resulting in occasional config crash on Forge #174 TwelveIterations/Waystones#1045
1 parent ec2078a commit db2c410

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

forge/src/main/java/net/blay09/mods/balm/forge/config/ForgeBalmConfig.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,8 @@ public void registerConfig(BalmConfigSchema schema) {
225225
default -> throw new IllegalArgumentException("Unsupported config type: " + stringType + " - only 'common' and 'client' are supported.");
226226
};
227227
final var mappedConfigSpec = mapToConfigSpec(schema);
228-
modContainer.addConfig(new ModConfig(configType, mappedConfigSpec.getFirst(), modContainer));
229-
230228
properties.put(schema.identifier(), mappedConfigSpec.getSecond());
229+
modContainer.addConfig(new ModConfig(configType, mappedConfigSpec.getFirst(), modContainer));
231230
}
232231

233232
@Override

neoforge/src/main/java/net/blay09/mods/balm/neoforge/config/NeoForgeBalmConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,8 @@ public void registerConfig(BalmConfigSchema schema) {
261261
default -> throw new IllegalArgumentException("Unsupported config type: " + stringType + " - only 'common', 'client' and 'startup' are supported.");
262262
};
263263
final var mappedConfigSpec = mapToConfigSpec(schema);
264-
modContainer.registerConfig(configType, mappedConfigSpec.getFirst());
265264
properties.put(schema.identifier(), mappedConfigSpec.getSecond());
265+
modContainer.registerConfig(configType, mappedConfigSpec.getFirst());
266266

267267
if (FMLEnvironment.dist == Dist.CLIENT) {
268268
initializeConfigurationScreen(modContainer);

0 commit comments

Comments
 (0)